Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp34980226rwd; Mon, 10 Jul 2023 00:22:48 -0700 (PDT) X-Google-Smtp-Source: APBJJlG4BQMTQ8ctahaADQt1tBpqVEX1kyFaO3xtcULaG8SEj9Rd+XgLPZRUnQiqxP2aR1J2pe6x X-Received: by 2002:a17:902:c3c4:b0:1b8:9b5e:65c8 with SMTP id j4-20020a170902c3c400b001b89b5e65c8mr12077632plj.4.1688973768572; Mon, 10 Jul 2023 00:22:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688973768; cv=none; d=google.com; s=arc-20160816; b=PodBQ3Si6SfDgC+pNfw3VwqbGb0g8RjnSEVeGc6I19FZi1tQSv0ySlpZ4suzJVm/J8 NxVYjQQ4Rsjdinc2NLVZs/X4mi6p4bhh7w2tvKv3b2IwbE1OQqxEFFMja5r3+5A32LZ8 wRgSN7uDb7yJhzzJtflGYOiB4phD86KR1s5yPK/EjNsrD0yBxuHYOxf+K2wd/3guB1/N goZepM+6k+8HQr4PzEfz+hKm0kt5qp1u5B7F1M+2CBDnGboQTbvP+vkZvaQVGYHjzHuJ O7o3WcQ4ygEsqYmL+ftw/Bfj6iktU5Yd4sroKTbZzem7Loz0G7OMlAD5eSHrW2k7DRNi H3bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=IuH8LJYvcYtMLcwMqbYORbIhMXRU2KvEfyHfs6OUorc=; fh=BU3fN30PRMSz6CHkkIELW10OXAA81YxUu7sg5Oy+itI=; b=PrYhmkuIykM9eEakh2+EULKtfnPfDkqSGpbwmbHVxx4CDhyB8iHTIzMXdRcaXJJuWA NNqGxL77CiEtW003Zf4/kHeXEt/G00Iib29nKqsw7/qIDm3vCVt8gU+1NsVDwvDg8jAJ /oTfHbIxi2bS+xf33Sa6dr9gk4G287ilasUHooqla98gi0pLdzpG5UqIzpV6LsRsGT4i lUQ0i1qWJxjPQmBIqzZlCzNeNcBdj3O03K+BZtyFK2rH6QUzTD2dK4jy7p3ZaN5HVcGe SEu6DLs2+8JMenxKl2MGfhBmxOZIGlZFht8rMSMeL8tdmcxHN9FCK9TK5UnEl6CR/kRl 0kvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=OVdL0Xtj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k11-20020a170902d58b00b001a6f0eab385si8667300plh.55.2023.07.10.00.22.36; Mon, 10 Jul 2023 00:22:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=OVdL0Xtj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230167AbjGJGzH (ORCPT + 99 others); Mon, 10 Jul 2023 02:55:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230304AbjGJGzF (ORCPT ); Mon, 10 Jul 2023 02:55:05 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1B6DDA; Sun, 9 Jul 2023 23:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IuH8LJYvcYtMLcwMqbYORbIhMXRU2KvEfyHfs6OUorc=; b=OVdL0XtjMCVX+22CogqYkdhhyA QiE4e5Z8wApctUXJnJKZ0336tbFQXORdewh908tvLiioSwUuh+C7ZaJ3ZhTbxoWIKycR1De4U3ipL 2bN7TkkYz3Ii/9okTSkZ//HCBcJE3KcF3OL08YKC5hyDP8Pdhgvli7hBwSmaF/wJ5TYn6bd5JLLcg yadjKuO32T8li4lSDFZYtyMfEW41eE2hMU7vcbFu1w+j0wE5F4Hm3LgOLqR48V4LgDY7lgmRwZpmk CkZo8gdvtUIz94VEC1RDbqhbeuwWNesjO0AzAvert2a0PuCxgbwjFUPCZly3zSkmhqNg+v4XHx5RA PEb84NSA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qIknR-00Adk7-1N; Mon, 10 Jul 2023 06:54:57 +0000 Date: Sun, 9 Jul 2023 23:54:57 -0700 From: Christoph Hellwig To: Andreas Hindborg Cc: Ming Lei , Jens Axboe , Hans Holmberg , Andreas Hindborg , "open list:BLOCK LAYER" , open list , Johannes Thumshirn , Damien Le Moal , Matias Bjorling , Christoph Hellwig , Minwoo Im , gost.dev@samsung.com, Aravind Ramesh Subject: Re: [PATCH v7 1/3] ublk: add opcode offsets for DRV_IN/DRV_OUT Message-ID: References: <20230710064607.155155-1-nmi@metaspace.dk> <20230710064607.155155-2-nmi@metaspace.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710064607.155155-2-nmi@metaspace.dk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 10, 2023 at 08:46:04AM +0200, Andreas Hindborg wrote: > +#define UBLK_IO_OP_WRITE_ZEROES 5 > +/* > + * Ublk passthrough operation code ranges, and each passthrough operation > + * provides generic interface between ublk kernel driver and ublk userspace, and > + * this interface is usually used for handling generic block layer request, such > + * as command of zoned report zones. Passthrough operation is only needed iff > + * ublk kernel driver has to be involved for handling this operation. > + */ > +#define __UBLK_IO_OP_DRV_IN_START 32 > +#define __UBLK_IO_OP_DRV_IN_END 96 > +#define __UBLK_IO_OP_DRV_OUT_START __UBLK_IO_OP_DRV_IN_END > +#define __UBLK_IO_OP_DRV_OUT_END 160 I guess I was just a little late to catch this before your resend, sorry. Please look at my comment on the last iteration.