Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp34982695rwd; Mon, 10 Jul 2023 00:25:28 -0700 (PDT) X-Google-Smtp-Source: APBJJlF4tkKE/cVtkIyDVY6gYaUfh880jOnHTiuGWKgECFiMl8OoWaHjqovaVOTegwbkJIrihtEV X-Received: by 2002:a05:6a20:72a8:b0:114:7637:3451 with SMTP id o40-20020a056a2072a800b0011476373451mr11967027pzk.37.1688973928400; Mon, 10 Jul 2023 00:25:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688973928; cv=none; d=google.com; s=arc-20160816; b=g/7Vbr23s1XW+2CbrMHeeuvgGEGdMJCjMi5IWEMN3szbv4WDJafGFc7ZPw6uV40tz6 yxP80JH7+IKd1H7TjI51Aem5GUAo/mtZSmCVcTnxKv+aDnV089CAPZPZnZXuJZYmqjOY 0kd21BUSdyI0uT1aytZNPxEU8Jr5X60s7hShmFBiBR3VzI2RfuyZUYgg7b75W3iIsuz+ MR3ifoOEKzun59/ir9QpwqgnnfRU1EE+ufkoDl+33KAQokxeO5za1He1priqKF8OP5QG 1Wsp2DC2EdBP+AjPVBrnwQxF784xzNRWFAkz0spO3rVcWolM9wEWQiCcTj2q07JgN8DW QDVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:user-agent :references:in-reply-to:subject:cc:to:from:date:mime-version :dkim-signature; bh=VULbMHADIg9p2hwDI7EJ7xo9/+DAf6ASdRhxIUW0cF0=; fh=OuVFioq957D+R9N2OC9WXEEGdIplHg0U8QytwS1HxuU=; b=hnxCJ0CgOxcK0ZW2ejjPKD2YwX3zE9xeXw5WbSNV4x+Y32Hk34SCrCr6zQvW9mtpXr Nk4oNbz4CCCwhVGbyXzy5T35RL5qXO3Z70lH03WvZ9kZnvfdb5Yy2vibjMWA2aOVINJd csQz8mQW1YeR1U90AMP/T+TfrFeiGHcKBPfi+H8Zp37qOdWtv/I6gqpdjbmTi9//jOIh xzu84Wnanf57d8sgk41pvCyA1qobfczGwtCZ4kRenriUYCdZSB8Qe2QymA39k8GTzmL/ q0cQN9lyyiRSzXbwkPRJqa3bBxTo/w11pXlvtzL2Ujkok5mU2fRReTbsW/TPr4Wg4WNd hvuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (bad version) header.i=@208.org header.s=dkim header.b=Z8qGrsD3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k11-20020a170902d58b00b001a6f0eab385si8667300plh.55.2023.07.10.00.25.16; Mon, 10 Jul 2023 00:25:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=neutral (bad version) header.i=@208.org header.s=dkim header.b=Z8qGrsD3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229843AbjGJHG6 (ORCPT + 99 others); Mon, 10 Jul 2023 03:06:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjGJHG5 (ORCPT ); Mon, 10 Jul 2023 03:06:57 -0400 Received: from mail.208.org (unknown [183.242.55.162]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1A84EB for ; Mon, 10 Jul 2023 00:06:52 -0700 (PDT) Received: from mail.208.org (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTP id 4Qzw6J2PSlzBHXhD for ; Mon, 10 Jul 2023 15:06:48 +0800 (CST) Authentication-Results: mail.208.org (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=208.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=208.org; h= content-transfer-encoding:content-type:message-id:user-agent :references:in-reply-to:subject:to:from:date:mime-version; s= dkim; t=1688972808; x=1691564809; bh=BVbkB5h19AUC2qXDaTRj4Iv4202 uUhLlZMpa8f2uMTA=; b=Z8qGrsD36Ynz7iCv+V2O2wk50AhLMYQzwSzzdPxZvUp 2hNn8EZ+RygiqTusv96oNn7B7BjRG0t6x6HEgevU3kP0X1MSn+o1I4Af3aCISYKg rFnWQVjUuP6A8DDqeC4IWS0FQXer3af/O618s8vO2YNj6iMmEKtSMgnodVUOhydd LomQebCBBc8UCEB4co9CfyrGBKogD01ubhgtEP7I5gCLLJbP+r/Gg9r7T/wd4ZGm SZcI5g4YUd1dldpuHgo/6YZlD7S6vLWtd3r5TQtTs2pnfxQ1BLI94+QvFIO8VB6N Sk+blS6miJ/2nzp5KBYvHXOFCn760NLyE0wOxXb1Pcg== X-Virus-Scanned: amavisd-new at mail.208.org Received: from mail.208.org ([127.0.0.1]) by mail.208.org (mail.208.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id WYkTQyo7XoXY for ; Mon, 10 Jul 2023 15:06:48 +0800 (CST) Received: from localhost (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTPSA id 4Qzw6J0NQhzBHXh3; Mon, 10 Jul 2023 15:06:48 +0800 (CST) MIME-Version: 1.0 Date: Mon, 10 Jul 2023 15:06:47 +0800 From: sunran001@208suo.com To: airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/nouveau/iccsense: In-Reply-To: <20230710070505.53916-1-xujianghui@cdjrlc.com> References: <20230710070505.53916-1-xujianghui@cdjrlc.com> User-Agent: Roundcube Webmail Message-ID: <1ddf673283e93e83d912066f2241b976@208suo.com> X-Sender: sunran001@208suo.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE,SPF_HELO_FAIL,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixed error: 'do not use assignment in if condition' This patch fixes error: 'do not use assignment in if condition' in drm/nouveau/iccsense Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c index 8f0ccd3664eb..2428f3d6e477 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c @@ -322,7 +322,8 @@ int nvkm_iccsense_new_(struct nvkm_device *device, enum nvkm_subdev_type type, int inst, struct nvkm_iccsense **iccsense) { - if (!(*iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL))) + *iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL); + if (!*iccsense) return -ENOMEM; INIT_LIST_HEAD(&(*iccsense)->sensors); INIT_LIST_HEAD(&(*iccsense)->rails);