Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <da543602-f88e-45ee-d7fd-8fddd0b0ac56@vivo.com>
Date:   Mon, 10 Jul 2023 15:25:22 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH] fbdev: imxfb: Convert to devm_platform_ioremap_resource()
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Helge Deller <deller@gmx.de>, Shawn Guo <shawnguo@kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-fbdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>
References: <20230704093652.18191-1-frank.li@vivo.com>
 <CAMuHMdWrBY1+JDuwODyqLrwJJivt=ewCOKfK41xq+0Hpaf8akQ@mail.gmail.com>
From:   Yangtao Li <frank.li@vivo.com>
In-Reply-To: <CAMuHMdWrBY1+JDuwODyqLrwJJivt=ewCOKfK41xq+0Hpaf8akQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0NxbzlENWhPWEpwMmlwYS9Mak1IakpjVGxUa1ZPMU4xN0JTbTRXT0w5K0s5?=
 =?utf-8?B?allaYWFBVVE4Qk4vdUk0U2djWjlmdWQxanZiOWMvZDJYME0weThoRmEzQjFT?=
 =?utf-8?B?cGUzS2xhdmVIbjY4UlN4OUg2ZXNpOTJuUXBESm5nU0g5b1QyL1h0c3d5U2Fl?=
 =?utf-8?B?RGRscjhZcjA1QVp2NXpZdUdwVHNBSUx5d1hLRmVJQTJ4cURYZVg4T0NTZzVI?=
 =?utf-8?B?OHlSRjBkVkwzcHlPRXNvZVpQRkl5MEh1ZnhhZE9sS0JEQkducWZQL1FiVWMr?=
 =?utf-8?B?Ujc5NHJwbnpNaGl2bE1MM0dLWDhyN3Y0M1UwbmpUVjUvc2lxM21CSTk0emxy?=
 =?utf-8?B?RzRIMkVxOWs2MU9CaStJMU9wWG1jQlRXQmsrQmNxTm5rUWlmOXFGZ2YzRHhM?=
 =?utf-8?B?c3FlY0VkNDVLZVF2YkdTU2RNdTBvMmFhZGR0Umk5UU5oVXRqVFUwZEVUVitO?=
 =?utf-8?B?YXRjRVpBUWNhVS83bE1mWFVPRjFYNDBQUEF3bFgwMFlKayt0dFYwa0ZFY1lG?=
 =?utf-8?B?RjZCZHBjbjdOd1FabTJ0QXRtQVFVRXlia2dBWGduYkFHRDB3bFBZdy90dzZZ?=
 =?utf-8?B?ZzFZUVp1SVl6UWowTDdiZ0VUTklka01WaitBMDZuNFV5NEN3TUlMem52NTdT?=
 =?utf-8?B?K2M5SVhaK2hRZVcrYm80WUNWOTZsdnJHdlpqMTNVbERqQmRMdnovUDdyTjZn?=
 =?utf-8?B?TkFiWHg3VGQrYU9MVzFyYkFlN3Y1ZDNkS0J3WGN4LzRFSDIrMlhiTWhCRmdQ?=
 =?utf-8?B?UVZCYjZVZnJGb3RET283b1RIMk5sSVJZQ1BhNDFqWHluSlVuT1RHUSthYjhR?=
 =?utf-8?B?TDZvQXo0QkgwL1RCQis1enZYcTIzeXk3ZkwwemNNckd1V1BNU2FpMFZxWEZY?=
 =?utf-8?B?bHVEK2dmOTZnWENXK1Yrenp6d1NrUXYvOUFjN0NZem1YWUNURGNXQlhVdjBr?=
 =?utf-8?B?M25aY2FieEE1YTRpY2FuVGhBUCtTT1duLzA5SDJLdC9VR2JoQkVqdzk3WHAw?=
 =?utf-8?B?cmYwL3cxYWJwOGFWckFhQjNXZDVSWEVJd3J0Qm42QnJPYmlyQVRpM0hoVzFM?=
 =?utf-8?B?TmVKVFF6MlpNRnZLVkxoWWZ4NEU3bHBsR2orUVRHcjk5RGZaNFpwQ2ljbDVn?=
 =?utf-8?B?aFExNUVDNnV0NkJZS242WkI0WlgvWGkxQ3MvWnNUTFBGMktYVG9WMzFXZzZ6?=
 =?utf-8?B?eVZ0TlBjQkNqKys2QjB4S0g1WEpsMmQvQmJFM2lGSitzMmRCMXM4ZTBiR2la?=
 =?utf-8?B?ZjliWXBrSDN5cGV5b1pFbXZxWXF0K20vMmpETTBnbnk5VVFVYmluZDJrd3dC?=
 =?utf-8?B?Q0YyQmdHbFNJNkkwTGlhclFVMzdxQ2E3b2VkVHlidk9JNkVHSXE4M3F6QTYy?=
 =?utf-8?B?VkR1c2NTWENEVmpVdWIvM2s3ZjdMZkM4WVhXVnpiaHRCaGhoZWlkbUJTbzhX?=
 =?utf-8?B?RUpHZE80T0FGeTJublVKTkRxWkZRbEgzMUVxQ1VjZHVLWFNwZWRIODlPS2NL?=
 =?utf-8?B?Z2lTMzBPZHBCN1M3V0tjNUhrbEdCV1J4RklrL084YXAvbnAyZkJKK0JXWFFn?=
 =?utf-8?B?TUlYMjVHSkRaSDkwZUhMYkJsTkR2bzc1M1Z5ckErQXV3VDA5ZndSSnpKczRY?=
 =?utf-8?B?R2JpOVNnVWhEaGtjOTNTZEF0aVRzYlVlRTczNi8xSUwrRVozUThseGtXRUlk?=
 =?utf-8?B?ZXpOOEozZ3AwOFRUcWNUNWtoWWV5eS9hWW4xcjhqUlg3NnRrK0FCUWtSd1cz?=
 =?utf-8?B?RkJSZGw4RG14L0xLV2dmOFhKWkMvVEhoS2M0VXV4RFEzcTFVSmFwbWgxZ1Jx?=
 =?utf-8?B?VWJSZHQzVE9xR2Y4YzZKd3ZNK2dIeE1QNk1hbEdhb00xUVk1T0s5R0NjbUxK?=
 =?utf-8?B?YnRuQnJpVzRlekhBbDdqMXR2eTVRcnFpVFBrU1ZtV25pU3JtdFovY29rOEI0?=
 =?utf-8?B?TURNNGZ3NzVvb2NFQnRFaEhiY3Z4UVg3R1lQZGRXY3V4eDAxdVFMZmc2QlJm?=
 =?utf-8?B?czErdUVGNUJCQVdvU0hkOUd6L0ljcmcvRGxzd2dFVjVubVlXVTFNaUZDVURO?=
 =?utf-8?B?VW0wN2xFNW92OFhrb21nV2l2SElGTXlyRjNPb2NTbHc0bVZhUlVuSUtuVmNx?=
 =?utf-8?Q?NtIEUDNG9XnlrbFGBAEYaHpEI?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee5bf168-7e72-460c-9ae8-08db8116d585
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 07:25:27.7657
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eodtrQ8NOHpdC2qtniBC9U+tj9y2UCG3rbKg95IyPbqUw+NZl2WG2OcwWfz1xfw2SDcmaXZ1/DOvuWMufEWeug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5807
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Geert,

On 2023/7/10 15:10, Geert Uytterhoeven wrote:
> [你通常不会收到来自 geert@linux-m68k.org 的电子邮件。请访问 https://aka.ms/LearnAboutSenderIdentification，以了解这一点为什么很重要]
>
> Hi Yangtao,
>
> On Tue, Jul 4, 2023 at 11:38 AM Yangtao Li <frank.li@vivo.com> wrote:
>> Use devm_platform_ioremap_resource() to simplify code.
>>
>> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> Thanks for your patch, which is now commit c1cd7a7a231a26c6 ("fbdev:
> imxfb: Convert to devm_platform_ioremap_resource()") in fbdev/for-next
>
>> --- a/drivers/video/fbdev/imxfb.c
>> +++ b/drivers/video/fbdev/imxfb.c
>> @@ -868,7 +868,6 @@ static int imxfb_probe(struct platform_device *pdev)
>>          struct imxfb_info *fbi;
>>          struct lcd_device *lcd;
>>          struct fb_info *info;
>> -       struct resource *res;
>>          struct imx_fb_videomode *m;
>>          const struct of_device_id *of_id;
>>          struct device_node *display_np;
>> @@ -885,10 +884,6 @@ static int imxfb_probe(struct platform_device *pdev)
>>          if (of_id)
>>                  pdev->id_entry = of_id->data;
>>
>> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> -       if (!res)
>> -               return -ENODEV;
>> -
>>          info = framebuffer_alloc(sizeof(struct imxfb_info), &pdev->dev);
>>          if (!info)
>>                  return -ENOMEM;
>> @@ -970,7 +965,7 @@ static int imxfb_probe(struct platform_device *pdev)
>>                  goto failed_getclock;
>>          }
>>
>> -       fbi->regs = devm_ioremap_resource(&pdev->dev, res);
>> +       fbi->regs = devm_platform_ioremap_resource(pdev, 0);
>>          if (IS_ERR(fbi->regs)) {
>>                  ret = PTR_ERR(fbi->regs);
>>                  goto failed_ioremap;
>> @@ -1043,7 +1038,6 @@ static int imxfb_probe(struct platform_device *pdev)
>>   failed_map:
>>   failed_ioremap:
>>   failed_getclock:
>> -       release_mem_region(res->start, resource_size(res));
> This part is not directly related, but a bug fix for commit
> b083c22d51148f3d ("video: fbdev: imxfb: Convert request_mem_region +
> ioremap to devm_ioremap_resource") in v6.0.


IIUC, split this patch into two, remove release_mem_region in one and

mark it as Fixes: b083c22d51148f3d ("video: fbdev: imxfb: Convert 
request_mem_region +

ioremap to devm_ioremap_resource")?


MBR,

Yangtao


>
> Please do not mix bug fixes with other changes.
> The stable teams want to backport only bugfixes .
>
>>   failed_of_parse:
>>          kfree(info->pseudo_palette);
>>   failed_init:
>> --
>> 2.39.0
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds