Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Jul 2023 15:23:35 +0800
From:   Alina Yu <alina_yu@richtek.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>
CC:     <broonie@kernel.org>, <linux-kernel@vger.kernel.org>,
        <cy_huang@richtek.com>, <alina_yu@richtek.com>
Subject: Re: [PATCH v2 1/2] regulator: dt-bindings: rtq2208: Add Richtek
 RTQ2208 SubPMIC
Message-ID: <20230710072335.GA30810@linuxcarl2.richtek.com>
References: <cover.1688569987.git.alina_yu@richtek.com>
 <341af3996c430549243365bb8204d33a15a482be.1688569987.git.alina_yu@richtek.com>
 <d3308334-aa91-f265-2469-8a6fbc727798@kernel.org>
 <20230706103040.GA32138@linuxcarl2.richtek.com>
 <20230710030858.GA16636@linuxcarl2.richtek.com>
 <8b5bde1a-08e2-15ad-ebe1-08a16de00468@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <8b5bde1a-08e2-15ad-ebe1-08a16de00468@kernel.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Mon, Jul 10, 2023 at 08:02:39AM +0200, Krzysztof Kozlowski wrote:
> On 10/07/2023 05:08, Alina Yu wrote:
> >> Yes, "0" refers to DVS0 registers, and "1" refers to DVS1.
> >> and there is only DVS0 and DVS1, so I use boolean to check which one is used.
> >>
> >> Is it more understandable if I modify that to enum ? And description will be like this
> >>
> >> richtek,mtp-sel:
> >>   enum: [0, 1]
> >>     description: |
> >>       vout register selection besed on this value.
> >>       0 - Using DVS0 register setting to adjust vout
> >>       1 - Using DVS1 register setting to adjust vout
> >>
> > 
> > May I ask one more question ?
> > If I modify the name into "richtek,mtp-sel-high", is that more understandable ?
> > It will be like this,
> > 
> > richtek,mtp-sel-high:
> >   type: boolean
> >   description:
> >   vout register selection besed on this value.
> >   0 - Using DVS0 register setting to adjust vout
> >   1 - Using DVS1 register setting to adjust vout
> 
> You don't have 0 or 1 values in such case. The property can be bool, but
> description is not good.
> 

May I modify the description like this ?

richtek,mtp-sel-high:
  type: boolean
  description:
  vout register selection besed on this boolean value.
  false - Using DVS0 register setting to adjust vout
  true - Using DVS1 register setting to adjust vout


BR,
Alina.