Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7c4affcb-bcb4-5f4b-cc2f-bed2cad9de71@kontron.de>
Date:   Mon, 10 Jul 2023 09:46:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 1/1] drm/bridge: Fix handling of bridges with
 pre_enable_prev_first flag
To:     Vladimir Lypak <vladimir.lypak@gmail.com>,
        Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Jagan Teki <jagan@amarulasolutions.com>
References: <20230707190020.6280-2-vladimir.lypak@gmail.com>
Content-Language: en-US, de-DE
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20230707190020.6280-2-vladimir.lypak@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aStYQ0hFZUxETkZDc2Rza2VORjBzZFhhbmtUdUpHNThvK3ozblBWWnJPdE04?=
 =?utf-8?B?L3l4UVRIUmhyd0tBTFlFdGNRQ3hEMGRoZ1dvYVN4cGF5cEVYbGdYeFA4NGdv?=
 =?utf-8?B?L1FyczMrbDZxTHIzaTRkWTZWT1dGaGlYbFVJNlZVM040L205eUZaWVgvWHEy?=
 =?utf-8?B?QWg2R3h4dmkrMERxSGZYNUtJQ3J5b1ljRDBvTC9LdG5XV2gyNk94dURBd1ZW?=
 =?utf-8?B?OWJSUUVmQ3dGZUtCM0ZrTnh2TTQrTVZRdU81eGI1RXFUc2o4Mk9PNklqVXhP?=
 =?utf-8?B?MUR6M2FRcUdGckNNdlU3NkNoelBCRXRuT01lNmpQaHRaSHA5TWZsRmIwMGkw?=
 =?utf-8?B?WFhldlcxYm95RmtYemFKSXc5QXhhcE9rVFU3MUQvZmJVNjZUYzVZbHhsUnli?=
 =?utf-8?B?ZmdFVGp4S1RUTlFjcGhjcXNESlF3dmw1SEZBWnowcGl5ck9HSXVwamdKcUZU?=
 =?utf-8?B?NkE2YkZaczlSTFJBa085YlFuYk1ESndTeWlqei82YVJxbUZPMXNmVHdPbWZ6?=
 =?utf-8?B?QlZnenErUWpPam52Zi90dTVMankramxRYzlQVCsyOFhzUTFvK0VMTTlBUlVs?=
 =?utf-8?B?OWU5L2FkWmZVNnJlZDI0VGd3RldWb0Q1dTdsc3ZrR1FiZ2xvK28xWXZLZk5H?=
 =?utf-8?B?SWJtQlY4b3pYTGhpM2dRMXdHelBUL2lEOWI3OE14TDNMOU5wWkhqNkF1aWV1?=
 =?utf-8?B?MlMycEx5QUYxR1NVOWwrT2Jlb1U3T2UrNDdPeUxDVExnTlZLYW1yZnJIZG9R?=
 =?utf-8?B?eithcWo1a2xvaUpVY0ZLRlhnTUtHY3RicDNhOVMzNEN4Z3FEdUVqWSs1V3BW?=
 =?utf-8?B?RU5sRnlqOEwxNXd0elJnU3l4dGRaNlBKdlF3Mlh4L2NmNFVLUHlaTmEyT2Zt?=
 =?utf-8?B?Z2FnRjA2dHZaSlJSQnZhMThCbXdJaG5BSWVPZEJaV3l4SnBFU09KZjdpWllr?=
 =?utf-8?B?dmd6MHZBQjFRK09McHNqdzlucjV5WDRwM0k3OXJQV3cyeGFCZjFzeSsvSjhS?=
 =?utf-8?B?Y0dGckdIb1lQRUc3a2I5VGZhMGJkOUYxTDM3ZTJ1R3lXVEloRHNVRHpoNGFv?=
 =?utf-8?B?Z3FGRlhJUTBFbi9ZUDhsNnd3cDNWVk9Fa0NIZ2RzM2RmeXJOaXNCM0tVaFFH?=
 =?utf-8?B?R240ajI5WmJlUGJyc2R2eVJQeW5GL05mNUFwMjBGVXhHcEpqa0kzMGxKNEta?=
 =?utf-8?B?V1ZneHphNzlyKzhULzMrMEUyVUtRSThzR2NXRkMzNXJpQklONFZzMjdvMXZm?=
 =?utf-8?B?NnBGZmdLYXpFUStHYzlNYkxqbzE4M2syTkJ2TE81T3kxcmc5eUVWY003SWdy?=
 =?utf-8?B?Rm5mSTRMK2pjTzI2S3B4MVNhaU83OERmUzlsSE53UjdqdXBxSTJ1SGhyMDRz?=
 =?utf-8?B?bHE3WXI0SzhzcitjTDJITVQzUmNOczZEQXRUYVRyc2NZeHl0SlNWR0dGbWpG?=
 =?utf-8?B?cksxK2l1ZTlLNURRZzkvalpFNnNzd0FzUFQvZmRNMVQ1TlhVaWp4M3pIZklP?=
 =?utf-8?B?ams1a2VObERpNTlzc0ExRTg4MEs1K2FhdWFNVEtwZmlzTmRRZEVTckdRMk43?=
 =?utf-8?B?MUxrVEthZXROVEdOTFN5UGRXR2NYbFdmeGFOZGk3ODczWVFaUWp6WHBhVS9t?=
 =?utf-8?B?VG1zSGJ6MkU4bVRPam54V1paYVlFVk9wYXQ0ZTJsd2VYa2pxR0dFbDNadFdI?=
 =?utf-8?B?YkhOUUNHb3EzNVVHaU9XdFdKWXNqUzFVRzJYVFVnNy9IZXMxSzFyMEJueC80?=
 =?utf-8?B?dHowbzd4TWlEQjAyYnVuWTUvMUc2VmRua2ZTcmNIb25zNml2U1duTFo5Qmpv?=
 =?utf-8?B?UmtEL29sQzBxT2dQNHpQS0xBS1k5Z0k1amY1TXQ5MGlSYVNWOVo5cStRcWYv?=
 =?utf-8?B?REc0L0NoTDZXZ05wKzB2cUV4Wi8xRkY0TWNMYUUvdjUwUk1FK2tyV2U1L1Fy?=
 =?utf-8?B?SVNvdWZvdDF0OWY1YjRuUHJ3V003VWxiN0dwVVJwZ1BmTkxUYk9rREZlbzNM?=
 =?utf-8?B?RDE5UFh6QlNaTk1qVXZ2L1hHU0JVRzl5b010WlRlUnJJWkNLVzJhU0VJN2xX?=
 =?utf-8?B?ZjNKeVdueldDbDkwOWcwMlBaTDAyNlZWR3BHbEZYSDV2a1NEb0ZvN0JSVkp1?=
 =?utf-8?B?VVJKVllvRHNucTg4OHBHT0ZGcm1Oa3VYa0pYaGk2TlJrS2NOaVZYUFlaN0Uv?=
 =?utf-8?B?VWc9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b45982b-4f69-4d78-a733-08db8119c309
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 07:46:25.0893
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9hI0yO/nur2CGpv+tmkgME7XA2AOasHVcQ7TPO+0PmTAyUzgBmKpNojIfp99ji/F3QvmFe2UYaslyeGr7zhlmi4y/lUqeRWIhho2HHOWyss=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR10MB8169
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07.07.23 21:00, Vladimir Lypak wrote:
> [Sie erhalten nicht häufig E-Mails von vladimir.lypak@gmail.com. Weitere Informationen, warum dies wichtig ist, finden Sie unter https://aka.ms/LearnAboutSenderIdentification ]
> 
> In function drm_atomic_bridge_chain_post_disable handling of
> pre_enable_prev_first flag is broken because "next" variable will always
> end up set to value of "bridge". This breaks loop which should disable
> bridges in reverse:
> 
>  next = list_next_entry(bridge, chain_node);
> 
>  if (next->pre_enable_prev_first) {
>         /* next bridge had requested that prev
>          * was enabled first, so disabled last
>          */
>         limit = next;
> 
>         /* Find the next bridge that has NOT requested
>          * prev to be enabled first / disabled last
>          */
>         list_for_each_entry_from(next, &encoder->bridge_chain,
>                                  chain_node) {
> // Next condition is always true. It is likely meant to be inversed
> // according to comment above. But doing this uncovers another problem:
> // it won't work if there are few bridges with this flag set at the end.
>                 if (next->pre_enable_prev_first) {
>                         next = list_prev_entry(next, chain_node);
>                         limit = next;
> // Here we always set next = limit = branch at first iteration.
>                         break;
>                 }
>         }
> 
>         /* Call these bridges in reverse order */
>         list_for_each_entry_from_reverse(next, &encoder->bridge_chain,
>                                          chain_node) {
> // This loop never executes past this branch.
>                 if (next == bridge)
>                         break;
> 
>                 drm_atomic_bridge_call_post_disable(next, old_state);
> 
> In this patch logic for handling the flag is simplified. Temporary
> "iter" variable is introduced instead of "next" which is used only
> inside inner loops.
> 
> Fixes: 4fb912e5e190 ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init order")
> Signed-off-by: Vladimir Lypak <vladimir.lypak@gmail.com>

I haven't had a chance to look at this, but I still want to reference
another patch by Jagan that intends to fix some bug in this area:

https://patchwork.kernel.org/project/dri-devel/patch/20230328170752.1102347-1-jagan@amarulasolutions.com/

+Cc: Jagan

Dave, as you introduced this feature, did you have a chance to look at
Jagan's and Vladimir's patches?