Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp35025815rwd; Mon, 10 Jul 2023 01:12:13 -0700 (PDT) X-Google-Smtp-Source: APBJJlE3ECtZuBAYJyzpwqXLMlqSeoZ+uizbAS/F335jm6Ht9AMqnV2S0oK0YYtUSJs/OSc6V9Te X-Received: by 2002:a2e:a309:0:b0:2b6:bf9c:d025 with SMTP id l9-20020a2ea309000000b002b6bf9cd025mr8884716lje.8.1688976733009; Mon, 10 Jul 2023 01:12:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688976732; cv=none; d=google.com; s=arc-20160816; b=IYXpgBq6AX/jUtSFBn01kg/kcxIPPoA5a9fPA3d0JUy7u5DdqpeTpBq5TlTT0OZEQ3 4dqdAntc/BSIxih4mi0vhoWC9FwUFAp++QW57+BmjspDZ16L6iuwN5LWbHjboF1o97wl rjkCxjj7SwooPvOjLnjWsSNJXHnusnAClMCqsahY3MDSrjqZu9Cy8PMMUtzxmp79dbts j+MIVwJ4cC/PrZj+JRg/ssWG5eJW81PsMeelEZZVzLZZEOGXbHS2qBNt1NNVynBsBOUw pBnOigeEwulebd7MekdvpxIDJo3TofeB6RFXSPu1dI75+IbpUrEBr7qu1Ilji7HmCjed vxAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=vh+sVUb6EpExqidiOoU657ohaTJ+4PLiupOU3kMGhgo=; fh=E8MlcBC5QbYiVw3MLrzWaHvSDHIAwXZ/pWjBhR+9qm4=; b=py9BFcmlnVPbJdcd0/GWfpqdnO/6a75Jo8dGvlx9lj5PJfQdyQreC6EMvfbPofPfLm Q332aW121x0+V0lWyhNYX6RsisEyK/DbKL5epaoF06aWmPmDTY/BRRilgtaMVRBz1Cw2 TlTGATgBhCiDcDc+WBsUVnVd3nOoI18giPDehPRRvbS29nXCYsfTh2sTWWQASgiOrMNm G1h9d2oK3PqHLK281IAHfGE/08GWyT1bPXSMJBspEHzwgg2wZ9S6N6k0b5wf1q3q41Rn z3BTmUDdd+XoOYB3vguJHXrNYdCHqY1Zz3s331KB6jdnlhkcmxN1ICsP8UCuUYBCmSTd UOIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=XJHHkkQB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jx16-20020a170906ca5000b0098e044f3701si7716067ejb.201.2023.07.10.01.11.49; Mon, 10 Jul 2023 01:12:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=XJHHkkQB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232267AbjGJH4n (ORCPT + 99 others); Mon, 10 Jul 2023 03:56:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232276AbjGJH4j (ORCPT ); Mon, 10 Jul 2023 03:56:39 -0400 Received: from out-24.mta1.migadu.com (out-24.mta1.migadu.com [95.215.58.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95305102 for ; Mon, 10 Jul 2023 00:56:37 -0700 (PDT) Date: Mon, 10 Jul 2023 16:56:29 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1688975794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vh+sVUb6EpExqidiOoU657ohaTJ+4PLiupOU3kMGhgo=; b=XJHHkkQBwCS2yPSjgk53hE8LAHmHvPptVCTz777HzFEiL3tL8/FUiXdabD0kceMPi/hBl4 y2Rp3svjUriygtlKMbyDqFe7fejdcWaGJLuK8979Dkz9l4q05xkJNJFYoeYeCOmt2NDWQv 1D2RwCbUMYROmofHbnQYLnnNqXz+K0M= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Miaohe Lin Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] mm: memory-failure: ensure moving HWPoison flag to the raw error pages Message-ID: <20230710075629.GB1686200@ik1-406-35019.vs.sakura.ne.jp> References: <20230708085744.3599311-1-linmiaohe@huawei.com> <20230708085744.3599311-3-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230708085744.3599311-3-linmiaohe@huawei.com> X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 08, 2023 at 04:57:38PM +0800, Miaohe Lin wrote: > If hugetlb_vmemmap_optimized is enabled, folio_clear_hugetlb_hwpoison() > called from try_memory_failure_hugetlb() won't transfer HWPoison flag to > subpages while folio's HWPoison flag is cleared. So when trying to free > this hugetlb page into buddy, folio_clear_hugetlb_hwpoison() is not called > to move HWPoison flag from head page to the raw error pages even if now > hugetlb_vmemmap_optimized is cleared. This will results in HWPoisoned page > being used again and raw_hwp_page leak. > > Fixes: ac5fcde0a96a ("mm, hwpoison: make unpoison aware of raw error info in hwpoisoned hugepage") > Signed-off-by: Miaohe Lin Acked-by: Naoya Horiguchi