Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp35027018rwd; Mon, 10 Jul 2023 01:13:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlFbhrkGJbb9dxNM08rOcxhoP1ILF6mnXr2BOrGwxiba89S5lAFlCixzPIoeUwH7IeTph732 X-Received: by 2002:aa7:cd92:0:b0:51e:164c:b67e with SMTP id x18-20020aa7cd92000000b0051e164cb67emr11463646edv.0.1688976802972; Mon, 10 Jul 2023 01:13:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688976802; cv=none; d=google.com; s=arc-20160816; b=pA8ku7cL65OehWlfBExsH/6QQNpeKh4Bmr6KW4pY7dNarM27P2xQMcvbaKefXTor7B MrSzds2CcB+SmLzI2cBuTChe+2awQ73/WnLKcdswerycwy0X+Py8ckZMKQloyyCswoGX Yu/UF0DT/PiTJumtqT06vYjnvvmbP14v8sY75Y6TzEtHYN3qpleAmyTMjCYOvU1ErfnX s3EbThXlR9yWpcw7GaeAjxGw7HzUQSEyLNScEKms+S7s/5qMuci57mCLlo02vBXV9zW7 1vgzREHoJFmDeXMriX/OdVZOcpVK7e3fx7Sf87MpHk1O/CSKdXslrwtWidGsvX2yjdkU UDFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=N49N5zz7PJN8d+71h+5mF4vSm+C4rcP6xT4u+oKd/Og=; fh=E8MlcBC5QbYiVw3MLrzWaHvSDHIAwXZ/pWjBhR+9qm4=; b=MPfWflBCsGIjaTsPR6XgLTGgqFB8XwtuMBA9ELL48Z/ox47U+5rEPttEQQfmo2HvEC cywLR99S6a4zlqDmGsLrTfTxzVLf5RCQpZUoBUwZvKZDNCODp9pegwU5Vg0B8nv4+9pI rdQ49OSGgGynFxcmU/CWSvcC+yg/pKbGyfm55oK8laCGETjPtM/r1sHrKNJoSQXMjyT8 iepxLluPwERT4Gq3xv7CGVCgoAbvnaSNZIcaeRRDDnTcgjo15cVtVuRIE2MSYIlPafie vt3iPRStR87zmsQEK1UvRmsN0bXSo8HxAecjIhw2JtFlbJ5h70hg/zVhVDxtoegDqLH1 62zQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=kZwcshxc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i10-20020aa7dd0a000000b0051a5a6676dfsi5828384edv.23.2023.07.10.01.12.58; Mon, 10 Jul 2023 01:13:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=kZwcshxc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229696AbjGJH6P (ORCPT + 99 others); Mon, 10 Jul 2023 03:58:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232858AbjGJH6E (ORCPT ); Mon, 10 Jul 2023 03:58:04 -0400 Received: from out-53.mta0.migadu.com (out-53.mta0.migadu.com [IPv6:2001:41d0:1004:224b::35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F16D123 for ; Mon, 10 Jul 2023 00:58:02 -0700 (PDT) Date: Mon, 10 Jul 2023 16:57:54 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1688975879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N49N5zz7PJN8d+71h+5mF4vSm+C4rcP6xT4u+oKd/Og=; b=kZwcshxcfisGNakXAiOWcwE2dZ36F5epybU6sT2TAr2Gzq2MEK6aBJ/Sc1ef29Dkvo8Kxe rAJO6GBnHJwBlrgMayM3GlGy7SgVf79c5kaZyPhERgesYKEPDIPZiQ3FEJpvLw34nb815O Vji1UMCcnHw9liV+Ct9/cSntK+8/Hqs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Miaohe Lin Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/8] mm: memory-failure: fetch compound head after extra page refcnt is held Message-ID: <20230710075754.GG1686200@ik1-406-35019.vs.sakura.ne.jp> References: <20230708085744.3599311-1-linmiaohe@huawei.com> <20230708085744.3599311-8-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230708085744.3599311-8-linmiaohe@huawei.com> X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 08, 2023 at 04:57:43PM +0800, Miaohe Lin wrote: > Page might become thp, huge page or being splited after compound head > is fetched but before page refcnt is bumped. So hpage might be a tail > page leading to VM_BUG_ON_PAGE(PageTail(page)) in PageTransHuge(). > > Fixes: 415c64c1453a ("mm/memory-failure: split thp earlier in memory error handling") > Signed-off-by: Miaohe Lin Acked-by: Naoya Horiguchi