Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Jul 2023 10:05:19 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Dave Hansen <dave.hansen@linux.intel.com>
Cc:     Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>,
        x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Juergen Gross <jgross@suse.com>,
        Andi Shyti <andi.shyti@linux.intel.com>,
        Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= 
        <marmarek@invisiblethingslab.com>,
        "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page
 protection modify mask
Message-ID: <20230710080519.GAZKu7v2N/eK/jYXPL@fat_crate.local>
References: <20230710073613.8006-2-janusz.krzysztofik@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230710073613.8006-2-janusz.krzysztofik@linux.intel.com>
Precedence: bulk

On Mon, Jul 10, 2023 at 09:36:14AM +0200, Janusz Krzysztofik wrote:
> Assume that adding _PAGE_PAT to _PAGE_CHG_MASK doesn't break pte_modify()
> and its users, and go for it.  Also, add _PAGE_PAT_LARGE to

That's my only worry.

I'd suggest we queue this but not send it to Linus now. Instead, let it
cook in linux-next for the whole 6.5 release cycle so that it can get at
least *some* testing.

Because if we send it now and something else obscure breaks in a weird
way in his tree, then we'll have to scramble to fix that too and it'll
be one helluva mess.

Dave?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette