Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Jul 2023 16:05:30 +0800
From:   Xu Yilun <yilun.xu@intel.com>
To:     Randy Dunlap <rdunlap@infradead.org>, marpagan@redhat.com
Cc:     Marco Pagani <marpagan@redhat.com>,
        Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
        Tom Rix <trix@redhat.com>, linux-kernel@vger.kernel.org,
        linux-fpga@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] fpga: region: fix kernel-doc
Message-ID: <ZKu7yj1+QumQ9DlM@yilunxu-OptiPlex-7050>
References: <20230706142755.124879-1-marpagan@redhat.com>
 <20230706142755.124879-2-marpagan@redhat.com>
 <e5dae9f1-8492-3046-f694-80d13c9927e9@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e5dae9f1-8492-3046-f694-80d13c9927e9@infradead.org>
Precedence: bulk

On 2023-07-06 at 14:30:34 -0700, Randy Dunlap wrote:
> Hi--
> 
> On 7/6/23 07:27, Marco Pagani wrote:
> > - Fix the following warnings issued by the kernel-doc script:
> > 
> > drivers/fpga/fpga-region.c:46: warning: No description found for return value of 'fpga_region_get'
> > drivers/fpga/fpga-region.c:97: warning: No description found for return value of 'fpga_region_program_fpga'
> > drivers/fpga/fpga-region.c:295: warning: No description found for return value of 'fpga_region_init'
> > 
> > - Remove the "and registers a reconfig notifier" part from the description
> >   of fpga_region_init() since it does not register an of_overlay notifier
> >   anymore.
> > 
> > - Remove the outdated "if @np is not an FPGA Region" case from the return
> >   description of fpga_region_get() and replace it with the case when
> >   try_module_get() fails.
> > 
> > Signed-off-by: Marco Pagani <marpagan@redhat.com>
> 
> Looks good. Thanks.
> 
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Acked-by: Xu Yilun <yilun.xu@intel.com>

Applied.

BTW: No need to have RFC if you think it is ready for full review.