Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Jul 2023 16:42:22 +0800
From:   Xu Yilun <yilun.xu@intel.com>
To:     Michal Simek <michal.simek@amd.com>
Cc:     Yangtao Li <frank.li@vivo.com>, Moritz Fischer <mdf@kernel.org>,
        Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
        linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/8] fpga: xilinx-pr-decoupler: Convert to
 devm_platform_ioremap_resource()
Message-ID: <ZKvEbrMOXqmDkXfg@yilunxu-OptiPlex-7050>
References: <20230705094655.44753-1-frank.li@vivo.com>
 <20230705094655.44753-5-frank.li@vivo.com>
 <8aa1704a-f34e-1bf2-76cc-1324b0a0404a@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8aa1704a-f34e-1bf2-76cc-1324b0a0404a@amd.com>
Precedence: bulk

On 2023-07-07 at 06:55:33 +0200, Michal Simek wrote:
> 
> 
> On 7/5/23 11:46, Yangtao Li wrote:
> > Use devm_platform_ioremap_resource() to simplify code.
> > 
> > Signed-off-by: Yangtao Li <frank.li@vivo.com>
> > ---
> >   drivers/fpga/xilinx-pr-decoupler.c | 4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> > index b76d85449b8f..208d9560f56d 100644
> > --- a/drivers/fpga/xilinx-pr-decoupler.c
> > +++ b/drivers/fpga/xilinx-pr-decoupler.c
> > @@ -108,7 +108,6 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
> >   	struct xlnx_pr_decoupler_data *priv;
> >   	struct fpga_bridge *br;
> >   	int err;
> > -	struct resource *res;
> >   	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> >   	if (!priv)
> > @@ -122,8 +121,7 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev)
> >   			priv->ipconfig = match->data;
> >   	}
> > -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	priv->io_base = devm_ioremap_resource(&pdev->dev, res);
> > +	priv->io_base = devm_platform_ioremap_resource(pdev, 0);
> >   	if (IS_ERR(priv->io_base))
> >   		return PTR_ERR(priv->io_base);
> 
> Acked-by: Michal Simek <michal.simek@amd.com>

Acked-by: Xu Yilun <yilun.xu@intel.com>

Applied.

> 
> M