Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Jul 2023 16:09:52 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     sunran001@208suo.com, airlied@gmail.com, daniel@ffwll.ch
Cc:     dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/nouveau/iccsense:
Message-ID: <ZKvK4NXzkKZTE35E@debian.me>
References: <20230710070505.53916-1-xujianghui@cdjrlc.com>
 <1ddf673283e93e83d912066f2241b976@208suo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="sesJufGAkiPhMEHr"
Content-Disposition: inline
In-Reply-To: <1ddf673283e93e83d912066f2241b976@208suo.com>
Precedence: bulk


--sesJufGAkiPhMEHr
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran001@208suo.com wrote:
> Fixed error: 'do not use assignment in if condition'
>=20
> This patch fixes error: 'do not use assignment in if condition'
> in drm/nouveau/iccsense

I guess this is checkpatch fix, right?

>=20
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> index 8f0ccd3664eb..2428f3d6e477 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> @@ -322,7 +322,8 @@ int
>  nvkm_iccsense_new_(struct nvkm_device *device, enum nvkm_subdev_type typ=
e,
> int inst,
>             struct nvkm_iccsense **iccsense)
>  {
> -    if (!(*iccsense =3D kzalloc(sizeof(**iccsense), GFP_KERNEL)))
> +    *iccsense =3D kzalloc(sizeof(**iccsense), GFP_KERNEL);
> +    if (!*iccsense)
>          return -ENOMEM;
>      INIT_LIST_HEAD(&(*iccsense)->sensors);
>      INIT_LIST_HEAD(&(*iccsense)->rails);

Your patch is corrupted (tabs converted to spaces) because you're using
Roundcube. Please use git-send-mail(1) instead.

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--sesJufGAkiPhMEHr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZKvK2QAKCRD2uYlJVVFO
o30SAQCBQ0XJUZtYK5k23vpkl8YQStJLMGNiuEo8Wulk+Ne03QEAkGbjMCU8DRCz
Ohcbe1uBj+CW/b2kAyogZavYb8WBBAE=
=5wr9
-----END PGP SIGNATURE-----

--sesJufGAkiPhMEHr--