Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [linus:master] [scsi/sg] fcaa174a9c: blktests.scsi/002.fail
To:     kernel test robot <oliver.sang@intel.com>
Cc:     oe-lkp@lists.linux.dev, lkp@intel.com,
        linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
        Chaitanya Kulkarni <chaitanyak@nvidia.com>,
        Christoph Hellwig <hch@lst.de>, linux-scsi@vger.kernel.org,
        "yukuai (C)" <yukuai3@huawei.com>
References: <202307101556.ea548e4f-oliver.sang@intel.com>
From:   Yu Kuai <yukuai1@huaweicloud.com>
Message-ID: <0d557e70-5dd1-da9b-8e8d-6155c671a93d@huaweicloud.com>
Date:   Mon, 10 Jul 2023 17:13:37 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <202307101556.ea548e4f-oliver.sang@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

在 2023/07/10 15:32, kernel test robot 写道:
> 
> hi, Yu Kuai,
> 
> we noticed this commit is to fix "modprobe: FATAL: Module scsi_debug is in use."
> issue, and we found it really does this work (below (1)).
> we also found after this fix, the failed case on parent (004/005/007) could
> pass now.
> however, the blktests.scsi/002 start to fail after this change.

I thnik this should be fixed by following patch:

https://lore.kernel.org/lkml/20230706125253.GA12842@lst.de/T/#m8f46592ad2b6f3f56a242eaf9f335e0e46c8f86f

Sorry for the trouble
Kuai

> 
> a42fb5a75ccc37df fcaa174a9c995cf0af3967e5564
> ---------------- ---------------------------
>         fail:runs  %reproduction    fail:runs
>             |             |             |
>            6:6         -100%            :6     stderr.modprobe:FATAL:Module_scsi_debug_is_in_use <-- (1)
>             :6          100%           6:6     blktests.scsi/002.fail
>             :6          100%           6:6     blktests.scsi/004.pass
>             :6          100%           6:6     blktests.scsi/005.pass
>             :6          100%           6:6     blktests.scsi/007.pass
> 
> below is the detail report FYI.
> 
> 
> Hello,
> 
> kernel test robot noticed "blktests.scsi/002.fail" on:
> 
> commit: fcaa174a9c995cf0af3967e55644a1543ea07e36 ("scsi/sg: don't grab scsi host module reference")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> 
> [test failed on linus/master 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5]
> [test failed on linux-next/master 123212f53f3e394c1ae69a58c05dfdda56fec8c6]
> 
> in testcase: blktests
> version: blktests-x86_64-154e652-1_20230620
> with following parameters:
> 
> 	disk: 1HDD
> 	test: scsi-group-00
> 
> 
> 
> compiler: gcc-12
> test machine: 4 threads Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz (Skylake) with 32G memory
> 
> (please refer to attached dmesg/kmsg for entire log/backtrace)
> 
> 
> 
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <oliver.sang@intel.com>
> | Closes: https://lore.kernel.org/oe-lkp/202307101556.ea548e4f-oliver.sang@intel.com
> 
> 2023-07-09 23:41:29 sed "s:^:scsi/:" /lkp/benchmarks/blktests/tests/scsi-group-00
> 2023-07-09 23:41:30 ./check scsi/001 scsi/002 scsi/004 scsi/005 scsi/006 scsi/007
> scsi/001 => sdb1 (try triggering a kernel GPF with 0 byte SG reads)
> scsi/001 => sdb1 (try triggering a kernel GPF with 0 byte SG reads) [passed]
>      runtime    ...  10.158s
> scsi/002 => sdb1 (perfom a SG_DXFER_FROM_DEV from the /dev/sg read-write interface)
> scsi/002 => sdb1 (perfom a SG_DXFER_FROM_DEV from the /dev/sg read-write interface) [failed]
>      runtime    ...  0.087s
>      --- tests/scsi/002.out	2023-06-20 16:51:09.000000000 +0000
>      +++ /lkp/benchmarks/blktests/results/sdb1/scsi/002.out.bad	2023-07-09 23:41:42.308862573 +0000
>      @@ -1,3 +1,3 @@
>       Running scsi/002
>      -PASS
>      +open: Is a directory
>       Test complete
> scsi/004 (ensure repeated TASK SET FULL results in EIO on timing out command)
> scsi/004 (ensure repeated TASK SET FULL results in EIO on timing out command) [passed]
>      runtime    ...  2.826s
> scsi/005 (test SCSI device blacklisting)
> scsi/005 (test SCSI device blacklisting)                     [passed]
>      runtime    ...  9.988s
> scsi/006 => sdb1 (toggle SCSI cache type)
> scsi/006 => sdb1 (toggle SCSI cache type)                    [passed]
>      runtime    ...  0.144s
> scsi/007 (Trigger the SCSI error handler)
> scsi/007 (Trigger the SCSI error handler)                    [passed]
>      runtime    ...  15.426s
> 
> 
> 
> To reproduce:
> 
>          git clone https://github.com/intel/lkp-tests.git
>          cd lkp-tests
>          sudo bin/lkp install job.yaml           # job file is attached in this email
>          bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
>          sudo bin/lkp run generated-yaml-file
> 
>          # if come across any failure that blocks the test,
>          # please remove ~/.lkp and /lkp dir to run from a clean state.
> 
> 
>