Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp35108297rwd; Mon, 10 Jul 2023 02:40:58 -0700 (PDT) X-Google-Smtp-Source: APBJJlFpZleTliikpo3LPgtcJogcnbhfqPIFZw5FxXvrRdfF+2Gug/B3zel8iPJvOrpwkLQQMaTV X-Received: by 2002:a05:6358:52c3:b0:131:ce9c:9971 with SMTP id z3-20020a05635852c300b00131ce9c9971mr11754136rwz.29.1688982058484; Mon, 10 Jul 2023 02:40:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688982058; cv=none; d=google.com; s=arc-20160816; b=mfQstY4n+rOWLR4zZJpXTxFfrewkevN0qouehSVKp6nZMWZpVa2457sJ5gWndjjeHh +R83G7YugWUfIpmVZh/oSTaNlNvW8u8PDx+irh9reW6MpYTjIedQGsdnTYTUkM8hc44P A+837kbSkL77RTA5XsNlnIO/b4m8/xHri+YbtpXRmzjTaBbGYyTildTvPlz52oe46QEp vlitY4zx/1A3Z3w1dDbZv0Kq8GCnquvfBfyDBrf4pyU5DjN4xNlLpRfO3CXI6c/41TuQ hktmJcZkmSgO/v6Aa5jRyzREXNlaUH0se+QX+v4e/yL3H4LNckWbzmq4Zmj6zdttWTPu EPcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ii09KwfW3lRpdYpHvr6Prko3xiz41Lgu8fucaZRBMPo=; fh=66UQWqy/EoZmScpLwKDt4zNAg9nklseX41iImPq+Sp8=; b=mXBXvYqZ0SNwEMKDbc0zzXc6l+/J9OAUTv51iVLu5krgxa1Iu6TSnEd+vVn6cjqFoh ruX23dm8wUCWvIgy06fbLeoc7vD5q0hxWN3xa/8xSaY0ptjatyPzRlY/l8NcJ6MY/i12 EtwZ5mOtiRF/ksdepX5m7yZ11WV0/cY5SKkPn6ZfGyqqbZ87T9hwl5bum+zSxye4IdNy +rxtP6uncOZh8x9jXpNuwDXP9jyftqkkxsgiU18xVYBWlPGGE2MTUwB0cmFbVpcAbe3a R9K18srfL/ouqc5SznKnk2f+tnwzEyKWzrUp9U8NRoVaBS+Bd4ijoO7Xo+JYOWSx3SVw ZAgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="swa/UZ4G"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q22-20020a632a16000000b0053f4a814953si8921704pgq.870.2023.07.10.02.40.45; Mon, 10 Jul 2023 02:40:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="swa/UZ4G"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232798AbjGJJee (ORCPT + 99 others); Mon, 10 Jul 2023 05:34:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232210AbjGJJd7 (ORCPT ); Mon, 10 Jul 2023 05:33:59 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A80AF10CB; Mon, 10 Jul 2023 02:32:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ii09KwfW3lRpdYpHvr6Prko3xiz41Lgu8fucaZRBMPo=; b=swa/UZ4GulajGqc19yN6js2z7R nX8q01dVRORP1UMEH7t2wRRIAwm7TcLnk41BaEi1nNfqSJVHt+mtNrw25uPzb6Y/4i8E2X6xbpZwy 3xJJovjOXfjO5++sclzVpTCx/oPg/IvEqm8XQgAR7ERRVEU1BvHp4ihS5LWc9gHhfoqCjHvLd2Khv ePElebdIFIE6FboQ6zdx5+i4VvDI6Lm0qC3skIyeTjyJgWD1/2A5oUo3srVes9RnY4HlGTPXydtUz oW/UyhAqVWyJJO0NGQp5YA96SVKD9Nz8yu/bpQSe7BU8rDne/jdvo0emvDAYM+CIkn0s83/ioWplp hqFFq5GQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qInG8-00B1Go-35; Mon, 10 Jul 2023 09:32:44 +0000 Date: Mon, 10 Jul 2023 02:32:44 -0700 From: Christoph Hellwig To: Ming Lei Cc: Christoph Hellwig , Damien Le Moal , Andreas Hindborg , open list , "open list:BLOCK LAYER" , Andreas Hindborg , Minwoo Im , Matias Bjorling , gost.dev@samsung.com, Jens Axboe , Aravind Ramesh , Johannes Thumshirn , Hans Holmberg Subject: Re: [PATCH v6 1/3] ublk: add opcode offsets for DRV_IN/DRV_OUT Message-ID: References: <20230706130930.64283-1-nmi@metaspace.dk> <20230706130930.64283-2-nmi@metaspace.dk> <51b660f3-8145-d35e-87b4-d9ac0623606d@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 10, 2023 at 05:27:23PM +0800, Ming Lei wrote: > Yes, that is exactly what we are doing. > > The added macros of UBLK_IO_OP_DRV_IN_START[END] are just for supporting > more ublk passthrough commands, and the motivation is for running > check(such as buffer direction) in two sides easily. > > However, I think it is just fine to delay to add it until introducing > the 2nd ublk pt command. The concept of a passthrough command just doesn't make sense for an on the wire protocol. It is a linux concept that distinguished between the Linux synthetic command like REQ_OP_READ/WRITE/DISCARD etc that are well defined and can be used by file systems and other consumers, and ways to pass through arbitrary blobs only known by the driver. Anything in a wire protocol needs to be very well defined in that protocol completely indpendent of what Linux concept it maps to. Especially as the Linux concepts can change, and fairly frequently do.