Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp35116494rwd; Mon, 10 Jul 2023 02:50:39 -0700 (PDT) X-Google-Smtp-Source: APBJJlFFZ4opsc0J8NYeVY/ioBX85YurM9SnGYKrxFYoIQX6I7zxwTiGOMkL8xgzjJ2IWbvSKGBa X-Received: by 2002:aca:1305:0:b0:3a3:7b77:bb1c with SMTP id e5-20020aca1305000000b003a37b77bb1cmr10224329oii.19.1688982638897; Mon, 10 Jul 2023 02:50:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688982638; cv=none; d=google.com; s=arc-20160816; b=BG4U7Pjqjj7oNNpjzqu+LgrSUHmh20lgivNKxPQO8dSiQQEVqAB5wkWU5ySwI3ucdd D0rEXFoeadEs7qZ70zmxf0wQpqq7s767jt7xfUTEPmtNtcWpzUDlMH7B+RRxJK2LZQZ6 z383KZ+Cgk3tNCz0iwaZQZEoOGoldPxEUQl3SHHf8bNxb0o48lYtvrpaFqtZDd+0E+M/ b3m7O84s6+JRS3GbRtAJX+zzaQKPO7GPl3QoA828HOlNvrDTmGRqeEdmsiibeUicwWov vJ/KUhVQLcM3dzZiYaFSCoh3dylm0PNLj4njMsEjvWuU1Nn1eglMTgyBZXU9p/BId8CD Nhsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+UCckrYUcg1dWWbPy7D9t7DaadNYoo5aQoz9ySh8HkA=; fh=fwCuxA5jDE6AnmfNagZ15BJZEVSqOHo2nOQbzYNHh9s=; b=P0PtL0qLLYgi2bjvWsdu/36AuidI/+sx/gOXaAcYS5j9/5XC5Lb/z+rj0Jf8IR1Lm4 QhvcrLf3zVu5D0M93fAWNdz20Qf9b4b+bsDhlxeDEd00g8Y3vg7xWui8QPrtjSCe28OR 3RQiTAJomiPHwIMnIhP9RGXiZwArtXEZRPcTRSmUBKFeW2Vu8j/se9qv4Hni1x3qxneL WE9lkH2W5m8yia7i2LTl46chbN+ibhEdykLZ6vpB6kALIzOMkOH2nh3BLf/EZIoGO8HV CqoJQlxC7C4yHe6osqfX+XXHd+Sx+U4S/BYbeLwShPvQk5qFU3Jka841L5ZgjyT58G/8 j2YQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=He4q2bK6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 12-20020a63194c000000b0055bc2612ed4si8748883pgz.39.2023.07.10.02.50.26; Mon, 10 Jul 2023 02:50:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=He4q2bK6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232873AbjGJJfG (ORCPT + 99 others); Mon, 10 Jul 2023 05:35:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232060AbjGJJeV (ORCPT ); Mon, 10 Jul 2023 05:34:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFE1319BD; Mon, 10 Jul 2023 02:33:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 46E5D60F08; Mon, 10 Jul 2023 09:33:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53CDDC433C9; Mon, 10 Jul 2023 09:33:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688981608; bh=FW512bUwkwbM2sy7ptkYcIAJbw1Ta8o+HZebnXCuO88=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=He4q2bK6D80vP+DQ/jaf1J+NOI/0R6OPlkwZ3y5E95rFHLYWZ9awDrai2qkjExRyd gJfQGaMaju4ILkuRuF/q6RFu81lAy9sg6tqbvE9yZBdf6lAezqwscANAkLYKT5wAhL Q0XjEBW70dHodiRkJCViA/Nfa64qOv3R/WopbvRh/85wr3Y4OP2wa+TKq/l6JlFAng yhCReC2ixa98lw64Aph+DrCtVigLbNavv95aXKklejb6LJ1PsRrqiMcwCX/XFnV1LX KXW6+OqOVpDcgqnR4ruXx3AfmoUvYw/2Gqrtx9oy9impncy7iK+AGFa0C4lfwpHtcO Tv32nRhmEXfuw== Date: Mon, 10 Jul 2023 10:33:23 +0100 From: Will Deacon To: Huacai Chen Cc: Bjorn Helgaas , loongson-kernel@lists.loongnix.cn, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, Huacai Chen Subject: Re: [PATCH v5] PCI: Align pci memory space base address with page size Message-ID: <20230710093323.GB32673@willie-the-truck> References: <20230619014715.3792883-1-maobibo@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 09, 2023 at 05:19:57PM +0800, Huacai Chen wrote: > On Fri, Jul 7, 2023 at 10:47 AM bibo mao wrote: > > > > Bjourn, Hucai, > > > > ping again. > > > > The is such issue on only LoongArch system since 16K page size is used. > > > > Should we add code in general framework or in LoongArch specified code > > in v1? > Though I still don't know why others have no problems. But it is > surely a bug on LoongArch. So if Bjorn has no objections, please use > the old method (just like v1 but you can simply align to page size > unconditionally). The initial assertion is that this is a problem for any architecture with a page-size > 4K, so there's nothing LoongArch-specific about that on paper. More likely, we've only just come out of the merge window so I suggest a little patience is probably all that is needed. Will