Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b598c796-7bec-5ac7-9e7e-9a8b5d9ecba2@intel.com>
Date:   Mon, 10 Jul 2023 17:43:56 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [RFC PATCH 0/3] support large folio for mlock
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>,
        Matthew Wilcox <willy@infradead.org>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <yuzhao@google.com>, <ryan.roberts@arm.com>, <shy828301@gmail.com>,
        <akpm@linux-foundation.org>
References: <20230707165221.4076590-1-fengwei.yin@intel.com>
 <ZKhK1Ic1KCdOLRYm@casper.infradead.org>
 <4bb39d6e-a324-0d85-7d44-8e8a37a1cfec@redhat.com>
 <ZKhiGLpIWi5Z2WnY@casper.infradead.org>
 <436cd29f-44a6-7636-5015-377051942137@intel.com>
 <ZKjfwYWh/n/LbTZv@casper.infradead.org>
 <676ce1b3-6c72-011e-3a4f-723945db3d31@intel.com>
 <04efd5eb-06c2-d449-8427-d7c30df962d1@redhat.com>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <04efd5eb-06c2-d449-8427-d7c30df962d1@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHZ6TWtzTUpWdldpUWV3V3ZFaU1OK21YL2pQc2x4ZDV2cW91Q2VKejlXeGx1?=
 =?utf-8?B?dWs0dlcwcCtuS3NURzZhUWxVcXVPK0o3eG9tejNWQlowWDIrRDRIR3ZyR3k0?=
 =?utf-8?B?RTlwNVVyWGQ2OUNRdFZ0ZGhYdlZaV0pNZndTV1hHcEJtTHNGNU5JbXFXcmRh?=
 =?utf-8?B?ai83RlZVSXduM3JxWmR1Tk4xNlB3ZUdGYzl5eWJmMTVBSnZ6dEJ4QWkrZ2N1?=
 =?utf-8?B?bngraU1BRlh5YXNDbGtaQkhtdDlDZmNjclUyTnZ0cEQ1R2M4NmFOcFdOSzR5?=
 =?utf-8?B?bjlDWGh2RHVoZE1Wdlg5cHhBZUJ6T2dmbW8vTDNzZTlEQVl6NG15T3RVaHht?=
 =?utf-8?B?d05NaWVkd3lsS3Zqei8rZ2pKT3A4b3NCaDdCRDI4ZzZ1RmNZRFBnUzZRc0Rt?=
 =?utf-8?B?SSs2bDVvY1hWRm5DMXA5TmljL0diYWNaaU1XYlIxNVpZWUQ1bTVGVG50QVFU?=
 =?utf-8?B?ZzFjdTN3bEhtWTV0UHVaVHVhRzVSOVRCNElRdGdLVm9OZ1htK21LMVBUUHR0?=
 =?utf-8?B?eGFsMmkvRlphUktTcHB5c29PUUM5RXF3dWVpbU5PYVdpMEQwMFJUSmQ3bkxu?=
 =?utf-8?B?MkFZckNrQlFrK3ZoWFBxYkZld1dPSUJ4MUlaQjd2d2hSWTNUNzkyTVd3NGxZ?=
 =?utf-8?B?REdnU2w4L0hhY2hxeFU0VUJjVFdldllEOGtzam5OVGJYN0k3U1dGSStxRzZX?=
 =?utf-8?B?bXhaNkpEcERtTlFKZzJkMWIyQ00zRkdCbld5ZkhLNnN4MG9kbG1PVmpvMDc5?=
 =?utf-8?B?NE85M1N3aDhoQlhZclBxZ2x5V08rVjBRcjlJNXJZSC95SndJNysxM1M2WGJ6?=
 =?utf-8?B?RlJCUXA3cjgrSWhGTmlDa0s5K1A2NktUeGxCQU5DV0RYQk5vdHZFTlltdS9V?=
 =?utf-8?B?azJUeTVURlMzU2pmSGtVN1lwOFg3L09nVElvSjlUdkNtTVIzV0RHN3N0Qmd2?=
 =?utf-8?B?S1hxaXBjZzk3Z1pKekN3bEkvcG9EZHplT1ZJN0NYVnRnNDhPbUdXSysrKzVM?=
 =?utf-8?B?L2Q3MmxjakxqOUg1RkR4L3dkd2JlalhYK0lQdjk3dG9kVGE1Nkp3NW9OUTBD?=
 =?utf-8?B?K2pMdG9Wbzk2anJ5YmJ5OFVIc3lXRVl4MFRQSCtoT2RwMThGTDh2TUpVbklu?=
 =?utf-8?B?bGxPTVRJeURrbkRka3FTejZTUm9sd3Vud0J0MHRXQ2RlNUlxeGhSYTg0cUMv?=
 =?utf-8?B?SUc1ZElqeXBHbE1PS0hvWjFONlZlMHRiaW0vZVFMbGgzWHkyZitGb0M4VlpH?=
 =?utf-8?B?ZnlEZjB4QThyeGpGS051ZUI1MUs4RXBSSnFyTzdMSXZsakpNV1FiRU1tOGh2?=
 =?utf-8?B?bHRlNlRaMGVkRUppdEMvNU1tZ2M4Rk9ZZHBZVzVJQjNOT3RvUmxmUmZFYjA1?=
 =?utf-8?B?UHpKVDNxeXdZSHk1Q0F1T0hIVEg0ZFZadWxVR2pXRnlZSTVBdFlPVGtDNHh2?=
 =?utf-8?B?d2tJb3NEREo1TkRkZEVKZG44cVRlVVFNOEpFZ2QwRzZBVmpJR21kbzhFRDZU?=
 =?utf-8?B?SnJPSkhmeDZUM1d5M0g0dmt5MSswVTlkNTczZU1IbTdUUjVJS01INGpLcGw3?=
 =?utf-8?B?akZjemdyT1F0M3BWdGp6TnV1TXRkUjd2SmtUd28xbmRPTmYxVVJBZFVSMDBI?=
 =?utf-8?B?UHArd3I4ZTM4dGwrdjMvSjY3SnhDQjE5My95TUo4NCtETnNuZ0tZQnhnTFNF?=
 =?utf-8?B?Q2RoTFRYRUh2c0taL25oR002eE5QdGxTMGZNcDd5dmlBazdQMjRFZnpGVlhi?=
 =?utf-8?B?dFVZM0xuSXcySGg1K2xSMHVHa3UrbkpwL2hFeFF1TzhpdkdOa2djSXZBUmFF?=
 =?utf-8?B?NmovL2tpdk1DeXppSTRrMW1KUE1GalRYcGZjcmtKemJ5TGgrRTcxS0x6QWlv?=
 =?utf-8?B?Z3RUZXZ6dXBmZ3BicnZDbEljbEY2SzN4UkxyWTZtdDBOalh0RmUxekdjNjJK?=
 =?utf-8?B?VWtPbDJnQVMzRkt6bzJ1VkpNRHczdDlkV21pczBqbUFFVXZSRnhHNWtXenVM?=
 =?utf-8?B?Ym1GT3NlTGRETnNIWkhJY25BMVlpRGsrU0tUVHdnVkp2MVJvc2ZEZFFUeStP?=
 =?utf-8?B?UE94UTNlSXNqeGovREJXSUFCQXhBZWlTZWxkQzRXWUtLOUQ1OUxBQXIra0xK?=
 =?utf-8?Q?MxRjNbvPoFsnu9woR4KiwiI8z?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d6aa7774-e8b5-4250-d40b-08db812a33a5
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 09:44:06.0944
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: czZaxcTYXcKP3aZxNBBNQY+2ZFG2B2Rac7+ezSw2Gwp2+kgdVSaNXyyHLeukvwN6xzPFnGWI96TnKubSwofrCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8155
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi David,

On 7/10/2023 5:32 PM, David Hildenbrand wrote:
> On 09.07.23 15:25, Yin, Fengwei wrote:
>>
>>
>> On 7/8/2023 12:02 PM, Matthew Wilcox wrote:
>>> I would be tempted to allocate memory & copy to the new mlocked VMA.
>>> The old folio will go on the deferred_list and be split later, or its
>>> valid parts will be written to swap and then it can be freed.
>> If the large folio splitting failure is because of GUP pages, can we
>> do copy here?
>>
>> Let's say, if the GUP page is target of DMA operation and DMA operation
>> is ongoing. We allocated a new page and copy GUP page content to the
>> new page, the data in the new page can be corrupted.
> 
> No, we may only replace anon pages that are flagged as maybe shared (!PageAnonExclusive). We must not replace pages that are exclusive (PageAnonExclusive) unless we first try marking them maybe shared. Clearing will fail if the page maybe pinned.
Thanks a lot for clarification.

So my understanding is that if large folio splitting fails, it's not always
true that we can allocate new folios, copy original large folio content to
new folios, remove original large folio from VMA and map the new folios to
VMA (like it's only true if original large folio is marked as maybe shared).


Regards
Yin, Fengwei

> 
> page_try_share_anon_rmap() implements the clearing logic, taking care of synchronizing against concurrent GUP-fast.
> 
> There are some additional nasty details regarding O_DIRECT. But once it completely switched from using FOLL_GET to properly using FOLL_PIN (a lot of that conversion already happened IIRC), we're fine in that regard.
>