Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>
To:     Jiri Pirko <jiri@resnulli.us>
CC:     "kuba@kernel.org" <kuba@kernel.org>,
        "vadfed@meta.com" <vadfed@meta.com>,
        "jonathan.lemon@gmail.com" <jonathan.lemon@gmail.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "vadfed@fb.com" <vadfed@fb.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "M, Saeed" <saeedm@nvidia.com>,
        "leon@kernel.org" <leon@kernel.org>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "sj@kernel.org" <sj@kernel.org>,
        "javierm@redhat.com" <javierm@redhat.com>,
        "ricardo.canuelo@collabora.com" <ricardo.canuelo@collabora.com>,
        "mst@redhat.com" <mst@redhat.com>,
        "tzimmermann@suse.de" <tzimmermann@suse.de>,
        "Michalik, Michal" <michal.michalik@intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "jacek.lawrynowicz@linux.intel.com" 
        <jacek.lawrynowicz@linux.intel.com>,
        "airlied@redhat.com" <airlied@redhat.com>,
        "ogabbay@kernel.org" <ogabbay@kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "nipun.gupta@amd.com" <nipun.gupta@amd.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "linux@zary.sk" <linux@zary.sk>,
        "masahiroy@kernel.org" <masahiroy@kernel.org>,
        "benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>,
        "geert+renesas@glider.be" <geert+renesas@glider.be>,
        "Olech, Milena" <milena.olech@intel.com>,
        "kuniyu@amazon.com" <kuniyu@amazon.com>,
        "liuhangbin@gmail.com" <liuhangbin@gmail.com>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "andy.ren@getcruise.com" <andy.ren@getcruise.com>,
        "razor@blackwall.org" <razor@blackwall.org>,
        "idosch@nvidia.com" <idosch@nvidia.com>,
        "lucien.xin@gmail.com" <lucien.xin@gmail.com>,
        "nicolas.dichtel@6wind.com" <nicolas.dichtel@6wind.com>,
        "phil@nwl.cc" <phil@nwl.cc>,
        "claudiajkang@gmail.com" <claudiajkang@gmail.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>, poros <poros@redhat.com>,
        mschmidt <mschmidt@redhat.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "vadim.fedorenko@linux.dev" <vadim.fedorenko@linux.dev>
Subject: RE: [RFC PATCH v9 03/10] dpll: core: Add DPLL framework base
 functions
Thread-Topic: [RFC PATCH v9 03/10] dpll: core: Add DPLL framework base
 functions
Thread-Index: AQHZpc/+2+ilbDjNIkao6LxAthBNeq+hd5yAgBFjgzA=
Date:   Mon, 10 Jul 2023 09:50:48 +0000
Message-ID: <DM6PR11MB465793F80239C1C87F1C095A9B30A@DM6PR11MB4657.namprd11.prod.outlook.com>
References: <20230623123820.42850-1-arkadiusz.kubalewski@intel.com>
 <20230623123820.42850-4-arkadiusz.kubalewski@intel.com>
 <ZJ09N2TI4wHrA4rB@nanopsycho>
In-Reply-To: <ZJ09N2TI4wHrA4rB@nanopsycho>
Accept-Language: pl-PL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uV90vHJJqg7yEP4wn2MQD1viUa+a6TEFMAi3sWQFCGKBscG+Ru6I13Lv7bpf?=
 =?us-ascii?Q?QKfJPpGWNJcTsqgTAMKG3KBwBkprDCHBGzeWJkqY4EZ9OJziRPrZ1EDJPkAZ?=
 =?us-ascii?Q?ek52iJzaehs7kAaqvKayT51IlnB1JyilVFvX3nV+qSF7duPqd6A7zjUDO62k?=
 =?us-ascii?Q?EwyCBbwLuOzW+SQsz6OKlmm9wS3I8tTJq5BtsOFyR84mDcG0/1Iwr/Tdwz3f?=
 =?us-ascii?Q?rR+ZPJZ4G4WNLT2vPyz2nHHjX03uwcFk21Rs5QuKtN4MQhSS0WMwb3wmafQy?=
 =?us-ascii?Q?nHZvS7z56GxhQU/8Kp2hqP6y0yq1K4W9wKq0NPOM0cVOVnWHXJEFMzc1oUP/?=
 =?us-ascii?Q?1r5ap3fG7u1xKveACpW13JS3bucGjpPv1BsCx1oJVq9oPmsExVkYlP0WOAmR?=
 =?us-ascii?Q?NSoeg7uQbO76gLWnduV3r+UgYmcqDDd3raQyC4sJd/OcR00wHq4QQxu66p4g?=
 =?us-ascii?Q?ftfm7gdk9Zj6LF+Dqa/RXL+pC9AYQXqkM4QbW1Nf3fBWxwDZbZTYmYextKGU?=
 =?us-ascii?Q?5PC/i1o2pP6kllWCZkKtGg90zYIzv80EJ1llRPYmQa1UGxNsDqNuE7k7zVCb?=
 =?us-ascii?Q?XD/TdM59I6rXSqsRaQWt3o0Rc3ruU21uZ7M08zS3DSc1Re+NRRjfTAijbwzz?=
 =?us-ascii?Q?y/YWPru1wytv/dEVmq+ZHS8qis3qIQdIob6s5aWFEHfgw8u5ve2nUvuo/aet?=
 =?us-ascii?Q?VHGbVh7J7I2Dam8ra7AifHqQx6KOnwLIoTZH35dWNeOJ8FUizcfX6bc9cyzq?=
 =?us-ascii?Q?XNk6ZYGPOiw31jQyqdmOZGNIbvsC9A6t0t02rYrPvr6CfIFws7Lws6KcUO+v?=
 =?us-ascii?Q?L2snShiW18L2di/T71AlNNPMedOrbaJkK4PqtbKg0YWPETP3bRR56GS5UWUs?=
 =?us-ascii?Q?bJv1bZd89BymITfa8C+lhV/4jY3vsG5b8vvmIXqTwJDLfDScXWv72Tg0fhju?=
 =?us-ascii?Q?Ay4A+eprJIepSigFJ+eayMXHQFHcF9Z9pC5Uy/4gruthsz/Z/llMvN69Y7Lc?=
 =?us-ascii?Q?VSw1L9QYTirZ4OLhXPHNA1xmbWrrBaL9ezFvXY+vg7pML+z0GRoEAnlNsn7r?=
 =?us-ascii?Q?9Fk6c1h9+NWEARvuC7FRA6dZdB3vQbflfL1yzmilqP3eU8R7VRk+j/pH2KMQ?=
 =?us-ascii?Q?dpFGD/kdbkiSMhcJSUzfW2wxrCYSuQLg9AfXomhOppkmOlXnwSR9iNUCJBqz?=
 =?us-ascii?Q?kyX2/2tHjYniMLsCxiP/IFDXTMYH6H/3ssQv12PTZq6D58VOeB3P6S7MMaqp?=
 =?us-ascii?Q?Et53Qr0iglWOJqIwLN2oNvyFl//BlLSesg0gIdlWqpQfD9jbya37f97OBfnQ?=
 =?us-ascii?Q?e37AtPJVl5RtYw9gqMQlICLmirGAvqRsjjAIPJiKhs+3N35WEcpTGZKjtk9i?=
 =?us-ascii?Q?raFspzt3V5t+I3aMUnY82OX5nuk7FLWNp4AqFr7lxqGgHZ5o90LEy07Lv345?=
 =?us-ascii?Q?qV1dHzwl1zkYo6yIwAQ7j6ObtdVoP5ikic4FLMbuCyRQz9NUAKwiwL56nOkW?=
 =?us-ascii?Q?Kqse50lcxNMQM4xP9scU0QumBvXhm/mQ5YicoJHHkqGsfzrvKI+InrYaqflu?=
 =?us-ascii?Q?lTXJfAmgjmz+PbthLTn5CLATX9wbmsWVJ6XUeziop/wfJeL3SqOGBndbwcKX?=
 =?us-ascii?Q?Gg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4657.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae91bff2-2a2c-445e-757e-08db812b239e
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2023 09:50:48.3776
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vdkURKb0JAZZh+vIrn+KcGUNvnZERKJIeaXIS9o+71UDNmnI0p4QBvpgZGrsCGaW3NuoxHC4f6llyrAsVEgl9bqkMrV96ycYdApZ/7vqpRo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5325
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>From: Jiri Pirko <jiri@resnulli.us>
>Sent: Thursday, June 29, 2023 10:14 AM
>
>Fri, Jun 23, 2023 at 02:38:13PM CEST, arkadiusz.kubalewski@intel.com wrote=
:
>>From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
>>
>
>One thing I forgot to point out the last time:
>
>[...]
>
>>+int
>>+dpll_pin_register(struct dpll_device *dpll, struct dpll_pin *pin,
>>+		  const struct dpll_pin_ops *ops, void *priv)
>>+{
>>+	int ret;
>>+
>>+	if (WARN_ON(!ops) ||
>>+	    WARN_ON(!ops->state_on_dpll_get) ||
>>+	    WARN_ON(!ops->direction_get))
>
>Please add check that you don't register to dpll instance which is
>unregistered. Similar check needs to be added to pin_on_pin register.
>
>Also, make sure you don't unregister dpll device/pin which has child
>pins registered under it.
>

Fixed for v10.

Thank you!
Arkadiusz

>
>>+		return -EINVAL;
>>+
>>+	mutex_lock(&dpll_lock);
>>+	if (WARN_ON(!(dpll->module =3D=3D pin->module &&
>>+		      dpll->clock_id =3D=3D pin->clock_id)))
>>+		ret =3D -EINVAL;
>>+	else
>>+		ret =3D __dpll_pin_register(dpll, pin, ops, priv);
>>+	mutex_unlock(&dpll_lock);
>>+
>>+	return ret;
>>+}
>
>[...]