Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5f5a3d4c-34fb-9d9b-444f-da8f7389ab76@shopee.com>
Date:   Mon, 10 Jul 2023 18:11:39 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.13.0
Subject: Re: [PATCH] signal: remove duplicate include header in signal.c
To:     ye.xingchen@zte.com.cn, rafael.j.wysocki@intel.com
Cc:     peterz@infradead.org, ebiederm@xmission.com, elver@google.com,
        tglx@linutronix.de, michael.christie@oracle.com,
        viro@zeniv.linux.org.uk, mcgrof@kernel.org, dvyukov@google.com,
        vincent.whitchurch@axis.com, linux-kernel@vger.kernel.org
References: <202307101523409041269@zte.com.cn>
From:   Haifeng Xu <haifeng.xu@shopee.com>
In-Reply-To: <202307101523409041269@zte.com.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2023/7/10 15:23, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> linux/file.h is included more than once.

Can you point out which files have contained file.h?
Though file.h is included more than once, but it has used the macro "#ifndef / #define" to avoid redefinition.
So what’s your concern about this?

Thanks, Haifeng.

> 
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
>  kernel/signal.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 9a3ff8157ceb..b1da4e81bde6 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -25,7 +25,6 @@
>  #include <linux/mm.h>
>  #include <linux/proc_fs.h>
>  #include <linux/tty.h>
> -#include <linux/file.h>
>  #include <linux/binfmts.h>
>  #include <linux/coredump.h>
>  #include <linux/security.h>