Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Suman Ghosh <sumang@marvell.com>
To:     Michal Kubiak <michal.kubiak@intel.com>
CC:     Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [net PATCH V4] octeontx2-pf: Add additional check for
 MCAM rules
Thread-Topic: [EXT] Re: [net PATCH V4] octeontx2-pf: Add additional check for
 MCAM rules
Thread-Index: AQHZsIaYZhp+Lo6+LkG+xdSrU5TZPK+uqeCAgAQnReA=
Date:   Mon, 10 Jul 2023 10:28:17 +0000
Message-ID: <SJ0PR18MB52167D52889AA5885844F554DB30A@SJ0PR18MB5216.namprd18.prod.outlook.com>
References: <20230707035321.2227742-1-sumang@marvell.com>
 <ZKhhFeKmxlN3hFYD@localhost.localdomain>
In-Reply-To: <ZKhhFeKmxlN3hFYD@localhost.localdomain>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BisD2gxWFWpZWzgtl+O2N+dq9lvcs7GZI/u7JdsC8+pgx4OqzIvnhEid6HqR?=
 =?us-ascii?Q?sDOOb7Xq+19d8OJWizDwekTHbG1KIXBL0HZqcDGTtt/spnKsmObZJQ6oTz7u?=
 =?us-ascii?Q?suY22lj7P1c5c3eusjGQuQwxm5kOo9gBH0FEMhZcrbxuEXFhkEOtVaIYIlOa?=
 =?us-ascii?Q?aWwm91AvfUCYNm8A85wzYCJNRfQ9lMyT5RcYyqsFfreTCE5RaQMm4HwhbqbD?=
 =?us-ascii?Q?2nzYuoYCKVY1Sg7PFmQ1Ut29lUHKcDzdvVz5W65RBxlP4vPYo03i/bMVT66n?=
 =?us-ascii?Q?K7bGwqYO/vxykuo1weUJqBQjh6g2ju4+OOm1ke3MVduQJIflSa4+/wwRHl3S?=
 =?us-ascii?Q?8uDvDgvhIMo8oqiA72AVKi1uMJjQ+zhUS8EWfAqMTZ1YNLxF4nKXlmRsl3N1?=
 =?us-ascii?Q?ZphCkvyjmmWAoa1a23fVpy/Hqs/7HuHNqYbqL42iQEPmLmN+iUt3748uLJ3L?=
 =?us-ascii?Q?zfA10R9N6qVFXZq4dFYSs/K8Gd2siBK2DoEPtYGn6VZb4RD4LHOv2bePDyab?=
 =?us-ascii?Q?dCBIEHigfgg857jh2dKDHyWOrLiUWZZBhMLy132HPMczFqvi98MqKzubHTLh?=
 =?us-ascii?Q?oKMcj6BwrFZIDu0NdRYBQpfD43hJ9DzzosrCN3q2C6XpvNWYEriqHn8SavX6?=
 =?us-ascii?Q?AgPxJG+KVYxEkegTECRL25cG7AdZbnjDj0JrDnCZPglMYTJJuD+80hMdF6no?=
 =?us-ascii?Q?dinKzVntofBJkso8b/XFmXpX6n0QgYps7xg90qUtKlUNX4p75ivqxZmiIcgO?=
 =?us-ascii?Q?7tgGW3d6SJ22I6HSs71qDK1jyzZv1QJC0fVmcTbcuMWxZuZSFfZrBC6P82mS?=
 =?us-ascii?Q?D4okta3Ffel5tFDzAP+XJOc9dedg8p9iUz2Y2R5RJkZL30KFJV+BtFVfNvvy?=
 =?us-ascii?Q?7aRxt/CPoGusWChYdiU4zNw7VU/gL3021fVwt0qS4YZRmcuWnTgIf9+W0vjY?=
 =?us-ascii?Q?PewWSeaWhDieZd/l5yLd2Vu8QpNhIrFFbdlD3ykOZaXHcZUc5ZrWTWt54R29?=
 =?us-ascii?Q?retMKWarC1NYScvEyGMlfVExuQxIZiel/dunEXHQYfSJ6tbHE3LmMBASh6J7?=
 =?us-ascii?Q?FKa1HSupDEO2SZZlwbDm/j5ySygNxRG+mq/cjZ56MX+Bx6kmPjmeNWCaM+/C?=
 =?us-ascii?Q?itPCnK3Z8QO4DJ5DsGnVaj6vhJl82/1yiYnteL8b8emtP2nkp5ljhaQ2BdK3?=
 =?us-ascii?Q?8ymS9t3N5O1sphlViPutEfobqDAM0cvwQs4buCA2ynRmTo+qM9Jjxf9bq+EC?=
 =?us-ascii?Q?c04XGcuBlvdeXqfIKIbULgHSIdyp2647In4GkS4dthdasISRjYSk847HbR2s?=
 =?us-ascii?Q?VOMw0jkWSF49IKHmGyZhMoQLsNTyPPF2UTIBgEv/F0I8dSjCM+8jQUll5tns?=
 =?us-ascii?Q?Kh9BNn68pgjfCaRpehfQ3gLm72YgVWY1PE47R2KjhyWZjYDQE/ZbJSHfn9f4?=
 =?us-ascii?Q?WcqQ8uHScRfHHHyUnCLpO6uK79TsuZgNfQztirNvpfXoEaF4Xzn2bKgnxgfd?=
 =?us-ascii?Q?hbOdk3Oz7Qohn/MLarzRWAEVn9ZLg1Sz0EpyLin0Jwb5Fhmw6uz9axhyM7PE?=
 =?us-ascii?Q?5qpTpzxamwOO+N9gIpo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5216.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 376cf302-e8ab-4dd1-f7a6-08db8130600f
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2023 10:28:17.3060
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bbHsBdqVD8Kd65uYn6vJALKgTgEwyXwW+b6kLcai0F7efg1YQ8v0k5ypq6qhtKtcbNM+BBqHFOgf2JXRJWngtQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR18MB3647
X-Proofpoint-GUID: z8w7y6_qe4HBl1SFXgyVvoz0-KtUBWdn
X-Proofpoint-ORIG-GUID: z8w7y6_qe4HBl1SFXgyVvoz0-KtUBWdn
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-10_08,2023-07-06_02,2023-05-22_02
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>----------------------------------------------------------------------
>On Fri, Jul 07, 2023 at 09:23:21AM +0530, Suman Ghosh wrote:
>> Due to hardware limitation, MCAM drop rule with ether_type =3D=3D 802.1Q
>> and vlan_id =3D=3D 0 is not supported. Hence rejecting such rules.
>>
>> Fixes: dce677da57c0 ("octeontx2-pf: Add vlan-etype to ntuple filters")
>> Signed-off-by: Suman Ghosh <sumang@marvell.com>
>
>(...)
>
>> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
>> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
>> @@ -604,6 +604,19 @@ static int otx2_tc_prepare_flow(struct otx2_nic
>*nic, struct otx2_tc_flow *node,
>>  			return -EOPNOTSUPP;
>>  		}
>>
>> +		if (!match.mask->vlan_id) {
>> +			struct flow_action_entry *act;
>> +			int i;
>> +
>> +			flow_action_for_each(i, act, &rule->action) {
>> +				if (act->id =3D=3D FLOW_ACTION_DROP) {
>> +					netdev_err(nic->netdev, "vlan tpid 0x%x with
>vlan_id %d is not supported for DROP rule.\n",
>> +						   ntohs(match.key->vlan_tpid), match.key-
>>vlan_id);
>> +					return -EOPNOTSUPP;
>
>The code got very nested here.
>Please consider moving the above check to a separate helper function, or
>at least reformatting the error log to fix the checkpatch warning about
>80 chars, for example:
[Suman] Will do the suggested reformatting in next version.
>
>			flow_action_for_each(i, act, &rule->action) {
>				if (act->id =3D=3D FLOW_ACTION_DROP) {
>					netdev_err(nic->netdev,
>						   "vlan tpid 0x%x with vlan_id %d is not
>supported for DROP rule.\n",
>						   ntohs(match.key->vlan_tpid),
>						   match.key->vlan_id);
>					return -EOPNOTSUPP;
>				}
>
>Thanks,
>Michal