Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6eff3085-ce81-06ae-f251-f9afc66e59e1@amd.com>
Date:   Mon, 10 Jul 2023 12:53:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Content-Language: en-US
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     linux-kernel@vger.kernel.org, monstr@monstr.eu,
        michal.simek@xilinx.com, git@xilinx.com,
        Conor Dooley <conor+dt@kernel.org>,
        Harini Katakam <harini.katakam@amd.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Grzeschik <m.grzeschik@pengutronix.de>,
        Parth Gajjar <parth.gajjar@amd.com>,
        Piyush Mehta <piyush.mehta@xilinx.com>,
        Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
        Rob Herring <robh+dt@kernel.org>,
        Robert Hancock <robert.hancock@calian.com>,
        Tanmay Shah <tanmay.shah@amd.com>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
References: <6544d13afd9f3d8f5413e32684aa16e4d155e331.1687160244.git.michal.simek@amd.com>
 <20230621141307.GC18703@pendragon.ideasonboard.com>
From:   Michal Simek <michal.simek@amd.com>
Subject: Re: [PATCH] arm64: zynqmp: Fix dwc3 usb interrupt description
In-Reply-To: <20230621141307.GC18703@pendragon.ideasonboard.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmtaQTU3YkgrUFJIWG5vcWd5Q0lwWHBFd2VTYnZYQXBQWGtLWnhBdXY0VlB2?=
 =?utf-8?B?UVRDZjFtbEkrbFdtYjBVaFBaZEJjRFA1amxQMit1Y3h6bUU3b0ZGQUNHK2tI?=
 =?utf-8?B?QlhIUC8wTE9ZNXFwT3VLTTgwWHZMTy8wNldySjRRTjh4dndKWUtvRVBuMXc5?=
 =?utf-8?B?a2wxTE4rTVlDaWtJcUtKRjdCT0crVXprZ2wvVW1LRDhFbGU5WHg2VFFZWk9K?=
 =?utf-8?B?L2V6dHN1eW1kVmNmUVVoZ2VUT1lBMlBmUWNvWWJnUnMvNktOeXl4Ky9PUE9n?=
 =?utf-8?B?VkpILzdXeWlyNjBreHp5bWFtaTFGdTF3WXNBSjc3b0x4M1lKdUs3ZkphTEdF?=
 =?utf-8?B?VTJZOVc1YTA4ckdya3M4aHFvdzNhWWVYVCttRjJkSUtmalErTGRoTXYvY1Fy?=
 =?utf-8?B?WEpHYlArYnhzVGFnRVMva3g0dEMrc2hYbm80T3UzMlZDNDdLaWp3TzdHK0dt?=
 =?utf-8?B?NUNMZWdJL0Rqb05YQmtvQ2ZyNHRrTGUrSld1VEJ0WDk0aHY2OXdHTTFFN1lF?=
 =?utf-8?B?T0swTTB4Rm5Oc0FNZWpUSVlEZDFwZkhRdlF0K0w0QkNnMHlYcmhyQkwrVUNB?=
 =?utf-8?B?bnNDTERsWExOMHVkT2ZqR0Ryc0dIb3NpSEZSTDZBVXpwbGpYMkJIZkNzUnYv?=
 =?utf-8?B?TllLUmRzTDdHUkprSGhmd1BpN212Wm1Oa3R0bmVSbVVaS0pzTGYzYjF0VVlI?=
 =?utf-8?B?cE4rV3RRc0gxTWdub3pCaG9wRXFmaU5kWHhuYzhibkcyS091T25tc1RmWjYv?=
 =?utf-8?B?aitySUxjWUNKWG52VnFodVYyREhqd0QzaE1TeURabVlINE4raTJsaEx1b0o1?=
 =?utf-8?B?czBpNWk4a0xJQTRBQW1IQjlhMWRMUzl2ZEVCSGFhTitrQVI5VmI2RktzVG8z?=
 =?utf-8?B?RitUWUIyaVhDa2Nrd0hyNStKWUZqR3BsUHRkWURSWC9OclhsdGtBVXFnSFZS?=
 =?utf-8?B?KzFVNkhmdWJNdmhTNlR0UnE2OStlaE9yUkgwdmhkUCtIKzFNVnZlSFpxM2xy?=
 =?utf-8?B?akxFZ1NFL2trUFRRWHJkRitIM25XMmFDZTlOQWcyVmRzR0xKWC9KQ2E0cXhD?=
 =?utf-8?B?WjZ5M0xjLy96bnZxTzVOUVExWHJoaTJhYTRsZC9wSWhlN2UrK3pxSmpCa3Z5?=
 =?utf-8?B?N1NHSzJMNzlsajF0SktrRUdzNTNMdWFmQWxyMjJKOW8ybndXMGZkaHdkSDRH?=
 =?utf-8?B?dmJoV3c0SE9pRGg0S3lFRFFSNXI3WU1zTFJKc0FkZXR4NFJqbTJZaXd5UnNU?=
 =?utf-8?B?dk9ncW5IdWxXRlRReGJVYm0raTlyZTJQbStpU3B4VGJFdUh4VjI3V3lpOUQy?=
 =?utf-8?B?TVZrc25jSXlZSmFiL2pKbE1QTE5jZ1lJY2xEakFUVkFrb0pkOGxaenlOTnhy?=
 =?utf-8?B?MzREOHJOMWppcWlETlgyWVhXVHB3SStRbTJ3ZzBXZmZraGx2V2hSK0Erendq?=
 =?utf-8?B?TDJmVFN0WFM1cTV6ZnZxM2FSZjlpQ1h0eVFzeVlQNlpTaDl2QzBuakVyVEVv?=
 =?utf-8?B?a3JsZWp1enVCZVVyMHZ3YnFaa2xNRlptTUlaL1o5ZEpNOVVlQ1l5SWJDL09a?=
 =?utf-8?B?MnBYbUlyME5zU09XUDluMEJYbWdvTzZIZHFJZUJOTVg5R21pUzVoL1RsNDFR?=
 =?utf-8?B?aTN6VDZyUlV6OW1GRmh6RHMrdytXVFFoR3VLUVVSbk5sRlIveUNRRi85Vkt4?=
 =?utf-8?B?T0JkdUVtUUdYMVFrWTFxOTRRc3M5Z2ZwZ2NMQlQzd1AzdWRXM0lkSUUvWmZ5?=
 =?utf-8?B?UndBK2szSkxkVGM5R2ZXTUdpQ2JQYXVZbHVlSnAwSUxocGEza2dXNWYxS01t?=
 =?utf-8?B?VEtqRnl5a2M2dDFLTHRvYzZEQ0NYVUpBT0poaG1DaWdCQ1ZmZHJqenF5dnhM?=
 =?utf-8?B?SldHdVNnWEZ5SnFzSWZ4N3htaXFTY3g2VEdTS2VIWjlYUjNXL0lSSTlSUnVX?=
 =?utf-8?B?NnpvbEpDM1ViMUd5a1RNYW9RRVU4U0VXeTVjSCtrR1MxeDB5MnYydGpXaEtZ?=
 =?utf-8?B?MWVNMTRBdEFaNENkeExRa0h4VUFUVFJjMG8xYTViYS8zQzZSOWszYU5oenQw?=
 =?utf-8?B?VkRlNDlKWCtsTFRHUUpUWHVlZkVUdGZRZXprWDZPYjVwTlZuaHVzcnZFWUtR?=
 =?utf-8?Q?y4L8pu8FY2gTvG/UQaYvMys3m?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abec5731-c27f-4fba-0e59-08db8133f1bf
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 10:53:50.6171
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FdhFk1ru9eOqlUUEy5W03Vdtnl40ZnTO/h91S1JyzVB36r/XlSHQdhS+LRd9A42v
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6345
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/21/23 16:13, Laurent Pinchart wrote:
> Hi Michal,
> 
> Thank you for the patch.
> 
> On Mon, Jun 19, 2023 at 09:37:54AM +0200, Michal Simek wrote:
>> Based on DT binding dwc_usb3 is single entry without anything else. That's
>> why combination dwc3_usb3, otg is not allowed. That's why split it to host
>> and peripheral pair which both points to the same IRQ.
>> DWC3 code is reading these two properties first before generic dwc_usb3.
>>
>> Signed-off-by: Michal Simek <michal.simek@amd.com>
>> ---
>>
>>   arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> index 02cfcc716936..e8104ffc6663 100644
>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
>> @@ -888,8 +888,8 @@ dwc3_0: usb@fe200000 {
>>   				compatible = "snps,dwc3";
>>   				reg = <0x0 0xfe200000 0x0 0x40000>;
>>   				interrupt-parent = <&gic>;
>> -				interrupt-names = "dwc_usb3", "otg";
>> -				interrupts = <0 65 4>, <0 69 4>;
>> +				interrupt-names = "host", "peripheral", "otg";
>> +				interrupts = <0 65 4>, <0 65 4>, <0 69 4>;
> 
> This should read
> 
> 				interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>,
> 					     <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>,
> 					     <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
> 
> The issue isn't introduced by this patch, so it should probably be fixed
> by a separate patch on top, to convert the whole zynqmp.dtsi file. Do
> you have any plan to do so, or should I ?

I have sent it here.
https://lore.kernel.org/r/9d5bd17f37772be186cab17b06cc21351d36ff62.1688986332.git.michal.simek@amd.com

Feel free to review it.

Thanks,
Michal