Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp35285866rwd; Mon, 10 Jul 2023 05:28:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlHymRoXXC/g+ph+6f+baOcl0ZwAAr1eqzmoF+fi0AtW6S3O+qQy+7sHTzCTiej7KMTQfFo6 X-Received: by 2002:aa7:d55a:0:b0:51d:95ac:22ed with SMTP id u26-20020aa7d55a000000b0051d95ac22edmr16654291edr.1.1688992123480; Mon, 10 Jul 2023 05:28:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688992123; cv=none; d=google.com; s=arc-20160816; b=M6c623Y2sBJqg84FL/j0jHxWGermpxYOsg7TiIC3CVWhYfxuDf+9b5jFXcAhIKNFrZ 2FJJOtTZaEOtmpK2kCpJWhcHxhmLujdHbBh2Go7VhIm3KBupZDSzihpjbFQ6K+RM42C5 4psyTR26aGWxy9mYbXONFUM2WAJXawFB6yV2EE6OSDmiJiw1+Qgz+fz5idceseFTKAXT yZ/b3YG97MqfRukM4f1rUp3uspXKr8xy+1Unk58xMD0DwvqVlFxn/IOYGP2QkUm8LGx8 GE4UPekxsbmxELB1U9H7l4jwAiKTY/pJiix7m70Xte83HoUUt8EhzVvq8IHHE5ISwo3+ WN4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=FckopyafbVYZ80IiDg9oVr+HK3fYSjx37360aFUpNQY=; fh=M6ZwGxYxC5YAH5/g0I269wW/7WZTWeqsVwvy4ZKforw=; b=Bg7KMk6kvuXXJ5yeVzqf1elG7n+4v3TbjQeUiCj9OL1e7Id+U1khpk4RjSIpkYWcCr VCHOX7EU3c5Pa7NnUfJxxvTLr+ye9VAu8Y23EXLAhiceWnpiQdeL9p9OPt+6Ys/pHSrR 0Ob2yC8HGwhVRIgdeAWzaX+K2aIt1Xv2spYmTSvbRnprXsMl5vVCPy/tw5ngJnH+vmRM SMd0ZqSbGNqqHfIwkLV+9NMHwUp4dv2Hr3J/Aj9UrVJm8CIBBghZfCH6/VCZgGafJGC8 IyqlqNDY/WDYZNwfqoNvmDtXUV1XJ9SlA3zZsMQqgC82UGqyNr5Ebnvt+ivEmfqv7i97 qYHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r3-20020a056402034300b0051de510755dsi6260645edw.243.2023.07.10.05.28.19; Mon, 10 Jul 2023 05:28:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230236AbjGJMLm (ORCPT + 99 others); Mon, 10 Jul 2023 08:11:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231195AbjGJMLl (ORCPT ); Mon, 10 Jul 2023 08:11:41 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26E8D123; Mon, 10 Jul 2023 05:11:40 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 3FA226732D; Mon, 10 Jul 2023 14:11:36 +0200 (CEST) Date: Mon, 10 Jul 2023 14:11:36 +0200 From: Christoph Hellwig To: chengming.zhou@linux.dev Cc: axboe@kernel.dk, hch@lst.de, tj@kernel.org, ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com Subject: Re: [PATCH v5] blk-mq: fix start_time_ns and alloc_time_ns for pre-allocated rq Message-ID: <20230710121136.GA17422@lst.de> References: <20230710105516.2053478-1-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710105516.2053478-1-chengming.zhou@linux.dev> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As a personal preference I kinda hate the empty ?:, but otherwise this looks good; Reviewed-by: Christoph Hellwig