Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <972a06e0-6841-043e-fc00-db7596f664c4@nvidia.com>
Date:   Mon, 10 Jul 2023 15:31:23 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH blktests v1 2/3] nvme/rc: Avoid triggering host nvme-cli
 autoconnect
Content-Language: en-US
To:     Daniel Wagner <dwagner@suse.de>
Cc:     linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-block@vger.kernel.org, Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
        Sagi Grimberg <sagi@grimberg.me>,
        Hannes Reinecke <hare@suse.de>,
        James Smart <jsmart2021@gmail.com>,
        Martin Belanger <Martin.Belanger@dell.com>
References: <20230620132703.20648-1-dwagner@suse.de>
 <20230620132703.20648-3-dwagner@suse.de>
 <9c07e4f6-2cf5-b53b-6b48-bd4df8798ee9@nvidia.com>
 <bz2s6nyjwl6l7yfrd4wtjdtousv23ypcdleckibps5lyjpwi4x@wqq6qqesevpk>
 <39f9977e-b34c-f2dd-d356-8c78414a60d1@nvidia.com>
 <jdsoqllqmrqu5j5bt3fudkksmjskgs4ooodynm6yh3b4oc5scn@t3hydrmbb22f>
From:   Max Gurtovoy <mgurtovoy@nvidia.com>
In-Reply-To: <jdsoqllqmrqu5j5bt3fudkksmjskgs4ooodynm6yh3b4oc5scn@t3hydrmbb22f>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEpqVEpleSt2VnZkSzlpeFdpNVUzMERZR3NuY000aGMzeGhXdXJXTW5GcWdB?=
 =?utf-8?B?WmxZekdWdlJuZGhkNmdYUThsTDg0RmpEVGJhNlBIamtKSkZuRzgwczV1M3dn?=
 =?utf-8?B?OFUyQ0tFc1gzWmY3bHBCY0FwdG51cHRKTldocU9CeWJmalBkWmQzaHY5dDZK?=
 =?utf-8?B?Rng4Tm5EejVMNzVOMWlOV0RDYWN0d2ZHV2lwR3RvcUtScVJhNVlUTVdvL3pU?=
 =?utf-8?B?Z2FTYWxTNzRPeFF2cTlveDBRT1hZNlRwT3BmZGtHbkVUWU9hUlBXWWF5Kzlx?=
 =?utf-8?B?NVV3QnBocWMxbVRZR2t5VWJUSzQyNFh0MnU4dHRzeU1kVjN2TnUvT1pkbVZS?=
 =?utf-8?B?dklzYkFiTUpSNzNsTmlPMmZML21lYWRXT3A1c2x1d0I2U0dRaEJLRW0xREE5?=
 =?utf-8?B?RU9qbXNIejQrb1FtZ0Zhb0JTWG9UUEpjVU0wcFV3TklDc0RkOWlPRWVKNUFJ?=
 =?utf-8?B?WEZleE5ZREpubjlTaWFIUHhEblRrc3VqNTl2RkpCUEV3VVozZmFhQzdTQ2o0?=
 =?utf-8?B?TXhibzZtSjQxZEdpN3h5OS8zMHRGS1lHYkZ6d3lwQ0IyRWViTkpyQUxEQTFI?=
 =?utf-8?B?Q3pTa3p3ZXJNWlg4dkg1NHIxNVNlZjkrWlZnSUpqaE1KYys5MzAwRURKcjRS?=
 =?utf-8?B?bGZjaGpHQUR1aHNiM0R3UzZucDZxSlVXSiszOHVRQ01MdkpySHRmNExvVTdZ?=
 =?utf-8?B?OXdRRWEzSmFET3pLSWlvbWtRUTRSZ2ZxOXIrZXhBUFR4VHJkeUYyYjZnTkwr?=
 =?utf-8?B?VE50a3A0cldzaFo5OGFuL3VBTUdZcmpwajBDREkxZzlGRzkyY0hTZE54THBE?=
 =?utf-8?B?UU5wbG9JUy9XM21SNS9TOEYwYmtmdzNOVjJDNGtOUGtyTnFlMklhV2VDRVJi?=
 =?utf-8?B?V0NtV0ZpRGU1ZVZWSWx0bDZWSi8yRTZyVzFEZjZOS2IxRG1xMFFyZTVWSUVF?=
 =?utf-8?B?UmUzUXhkVHlZMUdoQ1Jod1M3OUxsL09WUFpObkRBU2FPV1krVE9jNWxUSG5q?=
 =?utf-8?B?L25GZmZibTVKZ09HQVRUNUJWU0o4ZksrYXhRNWg0cUlLNEFqUjRiejlzNHFi?=
 =?utf-8?B?Z0hmVmZpakRtT3oydllCV3czUFF6bWFUSjhMN255Rjl0dE1tektmT25Ca1hR?=
 =?utf-8?B?K1dIbXZXVGhsR3RTMlc4cWMraUlhUG5EODZHRXJJcm9mYkJlWXpvNnozZ3RV?=
 =?utf-8?B?ZjF5cUxXT1hiRmtGeitoRVBCZzlua0RZT2EzTmF6bTJGODdyc1J6VlhNSHh3?=
 =?utf-8?B?ZE11Wmc1aXQ1Mzk2a1dXZFZBTmIvbkVhck12c0lBR28rY3U0SElxU0k0M29I?=
 =?utf-8?B?ajNpenVpZHNseDIxUmNRZTZ3ZE5OcG81U1gvT2NCeXZ2ZWp1TGovWm9MZjVV?=
 =?utf-8?B?aWFUTjBWUU9tZnlCZUdxWGkwdEFQR3lLdlFDZmh2V1hpVmdGbXh6SXRENjg2?=
 =?utf-8?B?MFQ1QlJLVHYxM0k1V05uNTZ6TzBoSzNmemxMQ1dyMmlLUHVQbnNzUXZOcHRR?=
 =?utf-8?B?N3FsN0FibFVEK2MvUTB3dU9tdFh5azJXTG4ybkRlUWZYUDFCMmdLVGpVWk93?=
 =?utf-8?B?YndpczJweW8vb3l3bXdNS2hXOVBEVVJnRE9NMVFxUW50b1dWUlVlREpPdzdv?=
 =?utf-8?B?VXhaUG9wMjFyRU9VZS9aQW95NXI4L3VRMmRuS1gweDR2MnRNUFRXaURmVFE3?=
 =?utf-8?B?V3l0YzRRWEdKL2orUHhXZ2drNktBQjFEQ05Ucy96cUp1Uk56TWI4R0p5eVVu?=
 =?utf-8?B?clJ1RjlaTWtma2VJUkdySDJ6RGhnenRORVlOUmwzdVd6NWpwdDk2R1dLa1R5?=
 =?utf-8?B?ODNPMlhrcENXWGw4NUN5eWVhbS80TWxhRVBiOEUyTENVNkl3ZmN4SWVpd0Zr?=
 =?utf-8?B?ckwyZlR4bGhXRlV4ZkJBMmU0anZHTmp3LzRxdElWT2xtYUtlUmxMTUd0WVBZ?=
 =?utf-8?B?cXQrdXZKY1c3UU42ZWJJUkFlTUh2dzV3SnA3Q2lJQVEza0VzMmU5NkRJajZt?=
 =?utf-8?B?cWVXZW9HbXFFdWpIeDY4S09Ebmc1Vk1YYlhlSUt4LzVqRWxlczYwcnBvYXlt?=
 =?utf-8?B?alEyalFjZlYwendWcWszRmVmODNMYzdzT00vZ1FtQk9IMFZadTBGc0lhSG8r?=
 =?utf-8?B?Q0NJc2tneTNvNXVrd1p4enJIOFFZYm1KQmtRN2U0U0VyVERqY2I0YjRqcE8y?=
 =?utf-8?B?UE5ISytYK2t6aHdCbnpnQjBuczN4N2prVUJKc0szMlNSMHFHZHhkaUt3L3RL?=
 =?utf-8?B?QlhhbG82amRzSUdTQllodWg5R3d3PT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd402104-1bc4-4aea-e43a-08db814196af
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5040.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 12:31:30.6908
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wNUNhUZCWRITcd4OcSIZ3PP2Z6EsUqnPdQNtiSNSNl7Osz6YrQmcx3WLrVscaNkHMD5GgJ86FSb9QO9XH+xcsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7673
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/07/2023 13:19, Daniel Wagner wrote:
> On Mon, Jul 10, 2023 at 12:53:17PM +0300, Max Gurtovoy wrote:
>   > > Agree on setting the hard coded values for hostnqn and hostid instead of
>>>> reading the /etc/nvme/* files. This should do the work IMO, isn't it ?
>>>
>>> Do you mean that nvme-cli will ignore the udev trigger when a different hostnqn
>>> is invovled? At least for the well-known discover controller the hostqnq
>>> doesn't work. Though not sure if I understood you correctly here.
>>
>> All I was saying is that your issue would have been fixed easily by 2-3 LOC
>> by removing the usage of /etc/nvme/* files that are usually configured by
>> system administrator and use a default values for blktests hostnqn and
>> hostid.
> 
> Okay.
> 
>> The usage of --context in blktests is redundant IMO.
> 
> Right, I made a bit of a mess with the commit message. Sorry about that.

I think it is more than just commit message.
A lot of code that we can avoid was added regarding the --context 
cmdline argument.
Maybe it's worth cleaning it..