Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp35326227rwd; Mon, 10 Jul 2023 06:03:41 -0700 (PDT) X-Google-Smtp-Source: APBJJlEHClhHgqIkNgbx8jFnj4cD0tg+KDFDDqjnoIzja1WGlu7Qm9bnag11K2jBFPGkUxaQg8Hc X-Received: by 2002:a17:906:5357:b0:993:f2c2:750b with SMTP id j23-20020a170906535700b00993f2c2750bmr6925006ejo.17.1688994220624; Mon, 10 Jul 2023 06:03:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688994220; cv=none; d=google.com; s=arc-20160816; b=jvAyhDGWiPy0BOqe0GiedlCwzEZs/42os2Ss6STqnefl0wJijtaNoEDzWhaGm5GHGZ MHbvv7X+gtNimMxQ9bWBLpIBjtsI690KNqCr0g3tKEBPFfLWWw4ovdWaRQ/ZSFuW8rV+ vk5TTeHIDWv13hWNg7WE+YvNbIZstbaj9Tr/ssuRrszXQZjqVRbx6agyVVOUl1AqIJ8X aaZDujX4FE2ok4bKIqpEyjnU1ex1IGgfCtMJv6e2LYM3/lDezIukt743g31GqIqaPePP vQxBXM89zTt1te0pOGLUyF/OBFaC5Kv4ra/IvVGtbxk6CNCDtTfFLXlewZQi7wI32slS NQZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=b1tkA5cnck2kONpDRu9sJYqljQtMp+En04yNEuSjgo0=; fh=Zosi3nI4PFjHDg2X+dAxicl/kZnAxdVPaT5nQHMxHy4=; b=gUqEkk+t8PIw82yJfZI2AySRKa+UB4iReLXP7CykoKXArCWQsrQ1DpBn4TZDbLsJNN iQd/58na+H1M9ZAxKz0cFfs9QcQOEXCxWiwrlhBixkV5F+6DVSsn36Ysl2+N2lTxZpYQ jfWIyIpKJRaiP+WYElfZXjcaXg4ehiZoE+MaqlRQUbDeuUYtwHoC+LbgKZ4YlENSq52t bxo/DnijeWOcSeW/t747SWm3OJFu/z+6+3vud4Kk0Rtw3xKsZOi9O95kjvwlK3scUkNi tCGWdy7I1OKRpvs/BA3zaxjJ3Bu/+ZOY8PjLpqynqZTkHDPotdg3zZQ5JFwhJp4GtWRX E7Qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=hQitnlAy; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o17-20020a170906861100b0098862880ec0si8649656ejx.418.2023.07.10.06.03.15; Mon, 10 Jul 2023 06:03:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=hQitnlAy; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232299AbjGJNBa (ORCPT + 99 others); Mon, 10 Jul 2023 09:01:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231290AbjGJNBW (ORCPT ); Mon, 10 Jul 2023 09:01:22 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA72A124; Mon, 10 Jul 2023 06:01:18 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 950C11FF76; Mon, 10 Jul 2023 13:01:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1688994077; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b1tkA5cnck2kONpDRu9sJYqljQtMp+En04yNEuSjgo0=; b=hQitnlAyor97xWUTv/FfFUMy+X0ufS4H7ZHxHC92zJKFirTAuUpgVAy5FZCxCkjF3ke/l9 kQ7u2ftsiop2Mojm5GlYdSNB6yXBK7y0P16RDRMk3n1kyDNsGMLDAiyRutHyyRcwk0ae7u 8zq0Gnin+yyr2cjk1k3nep7tGQhMl2c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1688994077; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b1tkA5cnck2kONpDRu9sJYqljQtMp+En04yNEuSjgo0=; b=IEsSif4UxQa4eqyTk/9aYHvQZe4fZ/toezAptuKz1Zd1mXBqhM/WhuTHkv+rEgOJ1RSDKD EnqCY9uvS4PehGDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 42B1213A6B; Mon, 10 Jul 2023 13:01:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MKhZDx0BrGTTFAAAMHmgww (envelope-from ); Mon, 10 Jul 2023 13:01:17 +0000 From: Thomas Zimmermann To: deller@gmx.de, javierm@redhat.com Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-nvidia@lists.surfsouth.com, linux-hyperv@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Thomas Zimmermann , Timur Tabi Subject: [PATCH 06/17] fbdev/fsl-diu-fb: Remove flag FBINFO_DEFAULT Date: Mon, 10 Jul 2023 14:50:10 +0200 Message-ID: <20230710130113.14563-7-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710130113.14563-1-tzimmermann@suse.de> References: <20230710130113.14563-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by dmam_alloc_coherent(__GFP_ZERO). So do not set it. Flags should signal differences from the default values. After cleaning up all occurences of FBINFO_DEFAULT, the token can be removed. Signed-off-by: Thomas Zimmermann Cc: Timur Tabi Cc: Helge Deller --- drivers/video/fbdev/fsl-diu-fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c index 785eb8a06943..c62b48f27ba9 100644 --- a/drivers/video/fbdev/fsl-diu-fb.c +++ b/drivers/video/fbdev/fsl-diu-fb.c @@ -1476,7 +1476,7 @@ static int install_fb(struct fb_info *info) info->var.activate = FB_ACTIVATE_NOW; info->fbops = &fsl_diu_ops; - info->flags = FBINFO_DEFAULT | FBINFO_VIRTFB | FBINFO_PARTIAL_PAN_OK | + info->flags = FBINFO_VIRTFB | FBINFO_PARTIAL_PAN_OK | FBINFO_READS_FAST; info->pseudo_palette = mfbi->pseudo_palette; -- 2.41.0