Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp35340411rwd; Mon, 10 Jul 2023 06:12:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlF1sNytmXFp3djtcOpgBoynb9ox5s8dq73xRor05IEFGCqFpc5WOLnKTq2Ko5ANiSRsX9eE X-Received: by 2002:aa7:dad8:0:b0:518:7a8b:5d4 with SMTP id x24-20020aa7dad8000000b005187a8b05d4mr12837098eds.16.1688994769630; Mon, 10 Jul 2023 06:12:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688994769; cv=none; d=google.com; s=arc-20160816; b=wVxDi895A4ftkwDOeX8eZyCI2yddD5fAkyMGLVaOd9wHUSPTcAppM4Lx0iW/zABGpA SnxG5WsXqXb/5IrOb1W1oSuBi59jk7ELqBVDFwC1SKxN86llZR8mg+7jn39chiiOvAD3 4T+tq19zZ7vUVOoMoEnPHJJwEJGUaDugN8N0iX4wAZjnlqWYqz4AMn/MitiDmo7a2YUr Dp5V0tIy3P/DbkV76Qj9spKSIvnPKwIKy5eJrIR3BroNRc0ZyFbTeWqEOmaKkjGqbiN6 H2FK0MtMHOtGrCCTA3rbP6Tb9VbTNi6iqKWjwzT2GcQNhMmcEzRYCISGwoGgrZIGlPzm ezFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=MBN05KgHaY0sMx1l1iBUjP749OE7Z5F7kgfPD8riQ2g=; fh=17YvZgVzGG5ZS7L4kfN74vr1MJLFQn7Kam4U1irxq8g=; b=pUucDOEcALeLVjZLbIJJATdjiAkKp2RpUZxg3AIlOkuj/bveLIWI/fTXD2vP2pD3ix CZda6RdQ6upNvVgvsSALkILAcLWlnFFcKP5Wl839q5hAMSl/gG52Bh9S7vWvoxUS5fmi l2VTGB/qiTvrhGUyrKlEAklvy07vA2oMK+RthkqK4hQsuInNBQ/y/RgACRyq2w2qx40w 2UTNkFTUsLmPi4PJOTfTkbtxsUFW6CJ7U2ir2gtEkWLcim+R7VJYSE2/X3VZTxrCjHLQ enkgi77fU9JmYjR04uuo3LuqqOAkrcdnQCxdkyO7tUJS79qnCpLzatyBnRgFBLucoCZE JqEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=SuQ5e90a; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m5-20020a50ef05000000b0051e03cd3ad6si9291301eds.302.2023.07.10.06.12.25; Mon, 10 Jul 2023 06:12:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=SuQ5e90a; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230264AbjGJNCf (ORCPT + 99 others); Mon, 10 Jul 2023 09:02:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232376AbjGJNBd (ORCPT ); Mon, 10 Jul 2023 09:01:33 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A056711F; Mon, 10 Jul 2023 06:01:25 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AA9DB1FF87; Mon, 10 Jul 2023 13:01:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1688994081; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MBN05KgHaY0sMx1l1iBUjP749OE7Z5F7kgfPD8riQ2g=; b=SuQ5e90aJch45HVzdyRHmRbbrzuHmO1SiTYMooQuvASBPdLqlTlVilzOBrVfV3XDxhivqO BljjcN4Jyhf8bKj4o6lQrdesOVKLRNCvIG62NlYjtHiRrPJQ+Oi7z7go3R/fHNCwVTBrbS EnLnpzZX5+qqT+i1TQVfz5Vbh+G68vQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1688994081; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MBN05KgHaY0sMx1l1iBUjP749OE7Z5F7kgfPD8riQ2g=; b=HMr8eJJ2iAGo8mdPxjB2hyPQv7w8MHRS1RtWaIIBe31IMfopJy4lG5GeGEKarxz7bk1cY8 17E3SBnQgzcfSCDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5E68F13A05; Mon, 10 Jul 2023 13:01:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id mIUrFiEBrGTTFAAAMHmgww (envelope-from ); Mon, 10 Jul 2023 13:01:21 +0000 From: Thomas Zimmermann To: deller@gmx.de, javierm@redhat.com Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-nvidia@lists.surfsouth.com, linux-hyperv@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Thomas Zimmermann Subject: [PATCH 16/17] fbdev/pxafb: Remove flag FBINFO_FLAG_DEFAULT Date: Mon, 10 Jul 2023 14:50:20 +0200 Message-ID: <20230710130113.14563-17-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230710130113.14563-1-tzimmermann@suse.de> References: <20230710130113.14563-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by devm_kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed. Signed-off-by: Thomas Zimmermann Cc: Helge Deller --- drivers/video/fbdev/pxafb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index c8c4677d06b4..beffb0602a2c 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -888,7 +888,6 @@ static void init_pxafb_overlay(struct pxafb_info *fbi, struct pxafb_layer *ofb, ofb->fb.var.vmode = FB_VMODE_NONINTERLACED; ofb->fb.fbops = &overlay_fb_ops; - ofb->fb.flags = FBINFO_FLAG_DEFAULT; ofb->fb.node = -1; ofb->fb.pseudo_palette = NULL; -- 2.41.0