Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Helge Deller <deller@gmx.de>, Shawn Guo <shawnguo@kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>
Cc:     Yangtao Li <frank.li@vivo.com>, linux-fbdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/4] fbdev: imxfb: Removed unneeded release_mem_region
Date:   Mon, 10 Jul 2023 21:19:58 +0800
Message-Id: <20230710132001.50764-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?islLeWcQBhH4+AToX3FcMqMKCqus2bQKwqb3NNOwZNfiw49ggPzoGugAodV2?=
 =?us-ascii?Q?hFoDXReUlCfOYq7Ff6xEpwU0MidH4CgIDEkehPi10RyPkhBNaN6nvzX6An2t?=
 =?us-ascii?Q?J1Mh6m68WagWwD4wfAzuNoifrHr1DAwwoiY7tccTCDVLkzk9rH+5VFX50rHR?=
 =?us-ascii?Q?eI+/Qk+nbqn2WC2s1i9AqNpnJgbFmKLviIdeV7Any5B0QPjP2MDeFlpcx8L/?=
 =?us-ascii?Q?KbfzKqLcZMuMhAyFb1YYfIzPeXlOIqbzazT7Ero47mXa7cYLh2R16u1vxQ3J?=
 =?us-ascii?Q?oJ8XyJulrzY13Zpxbqwrtcv7O9NOgh0/NHZqrDmaro/k0S7yImI9mqa71Lxs?=
 =?us-ascii?Q?AthxsiEHFpPUIA+65C+9hIADWBUibnXkG4lX4cx67CVsMyBkJ67k+7Q2us2r?=
 =?us-ascii?Q?XxLfu2TW8Kakyusd0zLElCyZjBR3bRzkGqjG9lcSbucdlYVi8r/4DMTxq+gW?=
 =?us-ascii?Q?8bgoZQM9XBaI5XkIYWQX9Kh2RIub0u8ZYmCRnN9x7zP5kBXl8SHUnlNORjzF?=
 =?us-ascii?Q?MfZfNO4P0vHk98/vqTOZzOhfxyhlSgO/w+jxnqmG579inQia/5xC0ZsuUhj8?=
 =?us-ascii?Q?hHTHCqUM2JEv5Qk4tgEQ+T8Rqb2wWda2bADR2zEk4+L5G2kGaCJThaOL6XYV?=
 =?us-ascii?Q?EEz17xqEAlbxZfLtVnYn/QETOhCiOQOCnqb09MwImlx8gMhpSX5HPbcfuHXG?=
 =?us-ascii?Q?CxXBp97Tfa+uFf6q8bNFsByPXJJkXvpa6ruH7qhizQIrMMo3jqIXG3vAKV4Z?=
 =?us-ascii?Q?zSQpNYg4RpFbjntXccgjqliZXmwCd+q6oFQd1lypFOGPTLiUzRpC+h+hBiAI?=
 =?us-ascii?Q?vQE1ApU0WWbB/qAzsjYN+5rkeCWYt+41YcmIs3ZLMSmf8HnzmGZfiBd0EmpT?=
 =?us-ascii?Q?klt9b/dzNRVlGJ/k28cD2V8r/UACNdY39jwXv3eEsM/pK1fuVdxYV2BKwcAg?=
 =?us-ascii?Q?eShWmqaU0vyghhlMAT+wqcQ6AOiZMkZ4azt36dHuykEtuZOG9bsy9g8RjYIj?=
 =?us-ascii?Q?I34Xwir4n2IG+HKDkgs7Y82CyPeiKnY8Qd4gME7Lx7mUzbLHvLMa/cgvTGZk?=
 =?us-ascii?Q?ZG1LXzrwtNzKbjmTmVvdbz4qlLCYtBu2EVN9wtzq7+D0jpglsxvgQKrM3MkI?=
 =?us-ascii?Q?L+bk/x5Uhq3CtF2lx02b542CFqu6ZEuUYWEOQwWmfDfCS23o1sC6paVqTAnE?=
 =?us-ascii?Q?X9+Db6O08X/wnBbxPkxcmsHQNcwxL0zcHUq/saSyYvw8IKnUZKL31tm4o5un?=
 =?us-ascii?Q?EL+tpBTT4MeagrcV79LcM/WJm+yt8KTtfFfOJGS5Kkg5l4HYAPkUCHpqLNgC?=
 =?us-ascii?Q?aaeJYU9tgxBUpSl2zlhlV/fY0MPSja2yzVfT5zwTdoFndrxigvdL/5DQIYWD?=
 =?us-ascii?Q?OfW0XOWannwmtpYMCC0gYvNWhpiulCbcxXHK8c+0Y5wfHnryzqCcEH/8I9bo?=
 =?us-ascii?Q?VSZITavRw+o5Y4PfAANT3uEoWWsrOQk1JduToZDtHPxi2EbYA5Nu7WT3JVVs?=
 =?us-ascii?Q?GAHYQHf/chnB1DtUtj14cFmV9/R/YPcLUiMdDHVilNbXDsS5aSeg4r03WUvG?=
 =?us-ascii?Q?TFmr/IOPUhrqi86GucpcwshxFPAkWJWgsMUf0GTy?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c236b37b-e1fd-46d8-a131-08db8148639b
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 13:20:11.4121
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: laGEcHXNLlipK8dw2WLzhy0Mjii6dOQGBunFhp2pgwCp8MhQbxqMXqpjxHb1nCAMM15aXWOiXaGsIiHGS0BvBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB5131
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Remove unnecessary release_mem_region from the error path to prevent
mem region from being released twice, which could avoid resource leak
or other unexpected issues.

Fixes: b083c22d5114 ("video: fbdev: imxfb: Convert request_mem_region + ioremap to devm_ioremap_resource")
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/video/fbdev/imxfb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index 04f3bf30a529..385c4715c7b7 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -1043,7 +1043,6 @@ static int imxfb_probe(struct platform_device *pdev)
 failed_map:
 failed_ioremap:
 failed_getclock:
-	release_mem_region(res->start, resource_size(res));
 failed_of_parse:
 	kfree(info->pseudo_palette);
 failed_init:
-- 
2.39.0