Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
        Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
        Alan Tull <atull@opensource.altera.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Yangtao Li <frank.li@vivo.com>,
        Moritz Fischer <moritz.fischer@ettus.com>,
        linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/3] fpga: socfpga-a10: Fix incorrect return value of devm_regmap_init_mmio
Date:   Mon, 10 Jul 2023 21:38:30 +0800
Message-Id: <20230710133830.65631-3-frank.li@vivo.com>
In-Reply-To: <20230710133830.65631-1-frank.li@vivo.com>
References: <20230710133830.65631-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RYK89IMncJL0x7pOI/YhHpKXf90UqYI5YYRK0fga0cwilwJZVftCKS27GevN?=
 =?us-ascii?Q?faXJvVwLr3Vot6xBOVCAyNmL+OHakaZtBx5QsxMIV9sPJw1IjKzvpijjrTK7?=
 =?us-ascii?Q?FgVu7uywtZ8gFL0xerIdV3Y4ImVxieXjW1E83JacD6XJCkFY5Y5gP/iSdl6q?=
 =?us-ascii?Q?GXEJtdnmgj/zYhtUczElSuTGSoZoQAIHd3wVVvZuhHY08o4flW5q/ZjeRlJ2?=
 =?us-ascii?Q?Gej7+WZCpROoVlMvQe/e32Kl0as41QOXAEzrNT6wQ5Dc8vFD4T8JhV5zLRhL?=
 =?us-ascii?Q?D0H3cZSgLosZMK/q4dXB28jHraoIPxNS0nRaeY5bD9UWjAAz4Mu85Ee4PwOD?=
 =?us-ascii?Q?B9bhXj053VJNcki5TlmJDhFmF5GXcjIF2qvy+EeFmaN9GrFUrKedmROEquPR?=
 =?us-ascii?Q?Njb1uGIWh0JH/w8xuoRQX8P5FOuTIXiD3ITT2bPwoefYnkhoMBheuV5N+Z43?=
 =?us-ascii?Q?XgnOKLAlju6mou99bDTR1H/+8pU2Jrd8JLYklOEWpPXHKMNYZ9GFAsBAf8aB?=
 =?us-ascii?Q?gEbM8CtSLJoZw0NiRHc4+zWNFTpGHTl7ssGHviObIhNXndUAH5JlRCaVKDX7?=
 =?us-ascii?Q?aRJ3edFLDm+qyNW8kUATTRGPBtmAyFipdxWTbJaOCQkDsZtRSwJa+7f6ZE9H?=
 =?us-ascii?Q?ZqeqF+YVXiiOuInbUc0S9wGSxnGcPf2vZ8xZa3dAuljNA1f8cyswTcbRPpZj?=
 =?us-ascii?Q?qdWTGr4k6cvnwMEn70dfF9jVGqVd+yqmv37P9GqZLWFCQMJjMAD8HGjtGB8S?=
 =?us-ascii?Q?NPBizATztmpUafqHDC204FS20cJWdvnlUkT7ECSt6RXwDEsNxU4zbOvoeFET?=
 =?us-ascii?Q?pq8dTisOLa1IEblIrrHLPA3vtJwJsiDcWb/EUbQZFMCB1XYXUykYwS1dhBXB?=
 =?us-ascii?Q?9OW6YttvKcIv6hyX1EIP2lq1rgJo4chSzQ0TdyaNggYntnkSSB4+rk61UKbh?=
 =?us-ascii?Q?spoMp1KDGlhZZ8vKu9Sr4vq+aQ4H5AhqFdXtnu+yeswJslYWvnpZGBuSzQrV?=
 =?us-ascii?Q?v0QlFWHJ8GD8maRgXJx2qMf0H7zkdEDb5iJDsKoUp8l9Ysia781Ah1LpI5G5?=
 =?us-ascii?Q?4iHp8QxcXv65q2SVI9H44WvUM/se2XBzyqxAk2jp2etmRPHtE0Pjor9OWSA7?=
 =?us-ascii?Q?+sAJzLONoqNG7O5T7bWz1v6l9NftQ/vhMc9Yu/012Uut597h4xVIPsVjAMJG?=
 =?us-ascii?Q?LeUkRYU8xR5pz7XBbo3l+H6cactHAazV2VxHUyCfc2TmqjppGvLfazgNmUet?=
 =?us-ascii?Q?zqEbRn9u+wKNpbv+6Wdc2H7MjDbRk1Kpa9hOfy6m7x9ymWLeqWXsl+uUgDmD?=
 =?us-ascii?Q?Ld8PcYtXohhsV+QDq0fsEX9rDjfHZSuUdG+Oic8a7COdEsLHgQth/ZLZ24i8?=
 =?us-ascii?Q?xPSbQJIJBhaF2gqO2Nptrc/NyioPB0jRZqSowypIPRGCzBMXeb6DqesP3n3f?=
 =?us-ascii?Q?8Iu7Ng4PAUj+OmiEI1+hA7impx+XgGXGYmXGD0YF6v88FNO4uHmdA9jFoEVa?=
 =?us-ascii?Q?FSu9X0Lle4q3Rtzfyyb4ybW9TQSKp4OUzPDz1hAQyJjAdcdoT0/EV8Bd8AEL?=
 =?us-ascii?Q?QmgHwCqjkz5oqAPtmAnfC/kBNw5aNmnoOFw1Tn2h?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2ea1440-c5b4-400f-aa1c-08db814afc23
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 13:38:46.2885
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zN13aynZKfvenEymh0X8wn0vt6GnKQo+igqRuNp7tm1uK2lVVqTQLNie2+fDbzNMLWu1Qbi+mjdQ+yPWuEZq6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5691
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When devm_regmap_init_mmio fails, we should return PTR_ERR(priv->regmap)
instead of -ENODEV.

Fixes: acbb910ae04b ("fpga-manager: Add Socfpga Arria10 support")
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/fpga/socfpga-a10.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/socfpga-a10.c b/drivers/fpga/socfpga-a10.c
index cc4861e345c9..b7b6e0bdb3d9 100644
--- a/drivers/fpga/socfpga-a10.c
+++ b/drivers/fpga/socfpga-a10.c
@@ -491,7 +491,7 @@ static int socfpga_a10_fpga_probe(struct platform_device *pdev)
 	priv->regmap = devm_regmap_init_mmio(dev, reg_base,
 					     &socfpga_a10_fpga_regmap_config);
 	if (IS_ERR(priv->regmap))
-		return -ENODEV;
+		return PTR_ERR(priv->regmap);
 
 	priv->clk = devm_clk_get(dev, NULL);
 	if (IS_ERR(priv->clk)) {
-- 
2.39.0