Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Mon, 10 Jul 2023 06:45:14 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Henning Schild <henning.schild@siemens.com>,
        Mark Gross <markgross@kernel.org>,
        linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Jean Delvare <jdelvare@suse.com>,
        linux-watchdog@vger.kernel.org, linux-hwmon@vger.kernel.org,
        Tobias Schaffner <tobias.schaffner@siemens.com>,
        Gerd Haeussler <gerd.haeussler.ext@siemens.com>
Subject: Re: [PATCH 1/2] watchdog: simatic-ipc-wdt: make IO region access of
 one model muxed
Message-ID: <087368d7-15d6-45e2-bd1e-5955bf81d206@roeck-us.net>
References: <20230706154831.19100-1-henning.schild@siemens.com>
 <20230706154831.19100-2-henning.schild@siemens.com>
 <876f6a08-1850-21cd-83d1-b309e7e1e912@roeck-us.net>
 <4a11393d-69bb-8e9d-3bfe-21aa7a7fb1e3@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4a11393d-69bb-8e9d-3bfe-21aa7a7fb1e3@redhat.com>
Precedence: bulk

On Mon, Jul 10, 2023 at 03:33:45PM +0200, Hans de Goede wrote:
> Hi Guenter,
> 
> On 7/6/23 18:03, Guenter Roeck wrote:
> > On 7/6/23 08:48, Henning Schild wrote:
> >> The IO region used for the watchdog also hold CMOS battery monitoring
> >> information. Make the access muxed so that a hwmon driver can use the
> >> region as well.
> >>
> >> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > 
> > Acked-by: Guenter Roeck <linux@roeck-us.net>
> 
> Thank you. Is it ok if I pick up his patch and merge it together with 2/2
> through the pdx86 tree ?
> 

Yes. That was my assumption.

Guenter

> Regards,
> 
> Hans
> 
> 
> > 
> >> ---
> >> ? drivers/watchdog/simatic-ipc-wdt.c | 9 ++++++---
> >> ? 1 file changed, 6 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/watchdog/simatic-ipc-wdt.c b/drivers/watchdog/simatic-ipc-wdt.c
> >> index 6599695dc672..cdc1a2e15180 100644
> >> --- a/drivers/watchdog/simatic-ipc-wdt.c
> >> +++ b/drivers/watchdog/simatic-ipc-wdt.c
> >> @@ -155,9 +155,8 @@ static int simatic_ipc_wdt_probe(struct platform_device *pdev)
> >> ? ????? switch (plat->devmode) {
> >> ????? case SIMATIC_IPC_DEVICE_227E:
> >> -??????? if (!devm_request_region(dev, gp_status_reg_227e_res.start,
> >> -???????????????????? resource_size(&gp_status_reg_227e_res),
> >> -???????????????????? KBUILD_MODNAME)) {
> >> +??????? res = &gp_status_reg_227e_res;
> >> +??????? if (!request_muxed_region(res->start, resource_size(res), res->name)) {
> >> ????????????? dev_err(dev,
> >> ????????????????? "Unable to register IO resource at %pR\n",
> >> ????????????????? &gp_status_reg_227e_res);
> >> @@ -210,6 +209,10 @@ static int simatic_ipc_wdt_probe(struct platform_device *pdev)
> >> ????? if (wdd_data.bootstatus)
> >> ????????? dev_warn(dev, "last reboot caused by watchdog reset\n");
> >> ? +??? if (plat->devmode == SIMATIC_IPC_DEVICE_227E)
> >> +??????? release_region(gp_status_reg_227e_res.start,
> >> +?????????????????? resource_size(&gp_status_reg_227e_res));
> >> +
> >> ????? watchdog_set_nowayout(&wdd_data, nowayout);
> >> ????? watchdog_stop_on_reboot(&wdd_data);
> >> ????? return devm_watchdog_register_device(dev, &wdd_data);
> > 
>