Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp35430859rwd; Mon, 10 Jul 2023 07:21:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlGxv4ziY6I6rKA//MeDVTt0MwkW4DJU6mnLszNk0wPnjjJ+RikKyr7N7vZc2SANe1p7lbbO X-Received: by 2002:a17:902:b691:b0:1b8:987f:3f34 with SMTP id c17-20020a170902b69100b001b8987f3f34mr12865900pls.25.1688998913680; Mon, 10 Jul 2023 07:21:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688998913; cv=none; d=google.com; s=arc-20160816; b=FZINx6DpTZ0FgTlfEW56yd4Wkq58C3BGuVzn0uOXfp7HpnVaOXsNzgfuAkFS9HGmPK 15VI6Ys8eUTeWLntsg0UvYGBRZ8AvN1g6UrjwDaQkLgoAFnp+miEYs10Gjpttu717EdA uVX8XIuuawRDbGcLPAFKbcvdCOncE0mUQUkScLmB+ZbyJDWVcx/xQgToXMt8spPxv3H7 WlfNV0gE9Xa3nxetPDq60NUE8ZkTIfQq1uKNjbFnvoBvvH7sy+EzZUM4nvluHpVEPnk1 vbngzekC6f9kFkmWYU/tZ0FCDDDOdBEbYl/AhlWMx1MqAnFB7FFhc0JRhPPZkqzTOwvE T8dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ljM8XYG7R7FccFzWPA18+Qp6QFp4d2q4VDHsKhcCB+g=; fh=0G5Z9W8FQscCX5n8m7SewfoORwgs97+j7bJmEBBcb34=; b=YuosWnHy/QGFIDob0NLrdCX81/C9vnir7uzzuSjQtDAcmDYW91UzoxvhuUeyMCMEbp RIfboB2JKkxe08japetihh0h3CV47jFj7x1T2e3PKMCgYpV+KefkreYhJVVJIS0jzXyg Tq/cS3mhhU+IZuYP6rjiq1eupJ9tw/kqBQzOHU+giIinZOpuroKEO7/zmpG5BGXXVTw2 GpNlenTcDY6Jy8v0iHUQs8PKjqbO8/N7qoETM2fmkDEl6YlIHfSUvve5y2DYdd4uJM0Z Wi3PobZsK86o0v+pPOO57uTU+XNE5YLYOt/OjFWdCH4qdRp3RipIErtf5okI0bD7CJtK oMlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=U27uaBqC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kp3-20020a170903280300b001b86dd825e5si8522948plb.243.2023.07.10.07.21.41; Mon, 10 Jul 2023 07:21:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=U27uaBqC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232060AbjGJOLk (ORCPT + 99 others); Mon, 10 Jul 2023 10:11:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230263AbjGJOLj (ORCPT ); Mon, 10 Jul 2023 10:11:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55E26AD; Mon, 10 Jul 2023 07:11:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E793760FE9; Mon, 10 Jul 2023 14:11:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC73BC433C7; Mon, 10 Jul 2023 14:11:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1688998298; bh=KnoFgz/WVRm69Acdmguxy6Kmdym5tT/bK7QYbgZ1Gyg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U27uaBqCHZ2xR2e09pZT/ldaLlsz1VKCWbQeri+Brc6VgkGU1ojfGSwxbN5L66nJn /nrCGLzgjt2ZVpHRqprD2Hxu1uy7rFCVXR2QKbkuakLstLY6dBlfBLyVVcsu5lKjXK rIlXiL/VR0wteIZwYx3anEMrMdUZsor38UBZtiXQ= Date: Mon, 10 Jul 2023 16:11:35 +0200 From: Greg Kroah-Hartman To: Yangtao Li Cc: Moritz Fischer , Wu Hao , Xu Yilun , Tom Rix , Alan Tull , Moritz Fischer , linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] fpga: socfpga-a10: Fix incorrect return value of devm_regmap_init_mmio Message-ID: <2023071010-anatomy-paying-3e3e@gregkh> References: <20230710133830.65631-1-frank.li@vivo.com> <20230710133830.65631-3-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710133830.65631-3-frank.li@vivo.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 10, 2023 at 09:38:30PM +0800, Yangtao Li wrote: > When devm_regmap_init_mmio fails, we should return PTR_ERR(priv->regmap) > instead of -ENODEV. > > Fixes: acbb910ae04b ("fpga-manager: Add Socfpga Arria10 support") Why are you not also including a cc: stable@ tag here? thanks, greg k-h