Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <33712296-5887-d810-096b-c95cd718626d@samsung.com>
Date:   Mon, 10 Jul 2023 16:41:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0)
        Gecko/20100101 Thunderbird/102.13.0
Subject: Re: [PATCH 4/6] iommu/exynos: Convert to
 devm_platform_ioremap_resource()
Content-Language: en-US
To:     Yangtao Li <frank.li@vivo.com>, Joerg Roedel <joro@8bytes.org>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Alim Akhtar <alim.akhtar@samsung.com>
Cc:     iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Marek Szyprowski <m.szyprowski@samsung.com>
In-Reply-To: <20230705130416.46710-4-frank.li@vivo.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20230705130416.46710-1-frank.li@vivo.com>
        <CGME20230705130438eucas1p231e5c29315bc0c2e15e947079ed4e39a@eucas1p2.samsung.com>
        <20230705130416.46710-4-frank.li@vivo.com>
Precedence: bulk

On 05.07.2023 15:04, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>


> ---
>   drivers/iommu/exynos-iommu.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> index c275fe71c4db..ab6208015997 100644
> --- a/drivers/iommu/exynos-iommu.c
> +++ b/drivers/iommu/exynos-iommu.c
> @@ -725,19 +725,17 @@ static int exynos_sysmmu_probe(struct platform_device *pdev)
>   	int irq, ret;
>   	struct device *dev = &pdev->dev;
>   	struct sysmmu_drvdata *data;
> -	struct resource *res;
>   
>   	data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
>   	if (!data)
>   		return -ENOMEM;
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	data->sfrbase = devm_ioremap_resource(dev, res);
> +	data->sfrbase = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(data->sfrbase))
>   		return PTR_ERR(data->sfrbase);
>   
>   	irq = platform_get_irq(pdev, 0);
> -	if (irq <= 0)
> +	if (irq < 0)
>   		return irq;
>   
>   	ret = devm_request_irq(dev, irq, exynos_sysmmu_irq, 0,

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland