Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Jul 2023 11:05:32 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peng Zhang <zhangpeng.00@bytedance.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        maple-tree@lists.infradead.org
Subject: Re: [RESEND PATCH 1/8] maple_tree: set the node limit when creating
 a new root node
Message-ID: <20230710150532.hvj7jzc5ep73yq4i@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peng Zhang <zhangpeng.00@bytedance.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        maple-tree@lists.infradead.org
References: <20230707101057.29326-1-zhangpeng.00@bytedance.com>
 <20230707101057.29326-2-zhangpeng.00@bytedance.com>
 <20230707151819.d5rvxalhewdv62nb@revolver>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230707151819.d5rvxalhewdv62nb@revolver>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qu2z4Zk/y5ASg5ZcVNoDH0kHPjNygRGLATK1XyRKEmisXhbbubqVzQkX5DaP?=
 =?us-ascii?Q?b3iKQT4xpMXQqE34k5h/wXh9HK+8MmKam+21qBOagjcTJcpbrXrR/Qi0eZef?=
 =?us-ascii?Q?OO7hpK4IXldWt7LhVlHh1oPNaUtPOgqVO3d2hakIv6Kab3Wzu/0Z6lqDkVGw?=
 =?us-ascii?Q?mBY3Ta5pPv8NUGjVR/NY44d03xFT3LF7Va7Rk0AGEXKqxRIJqP47L4Ay/P4E?=
 =?us-ascii?Q?1Zfkoqq4/uouas+jq2moGZ98l2SU+K/FUPFqdpU/kV6d5TVZ9wUn2XGHf9BB?=
 =?us-ascii?Q?AXoWynLmGkxU9xVX8+3YSxysT1UF+h0xOQHe3ux11eyXRWTbYyzIhqyot2PC?=
 =?us-ascii?Q?xnCPPbK+Y0KZbnNxGBYOLrAhc3SNy5buivLRbv0E08ijJndoZZSkQgAfb1XA?=
 =?us-ascii?Q?mjZZsHKc98l4u2MvtrVSmqL5rqbg2lnvL3MHE9opc5olzb6v6Ad0VypoWUal?=
 =?us-ascii?Q?kphHIAADkI/wAH1M8xOT9s2Pbj+NKsbWKjTaAQS9yayeM3icY9fxm9oDpxQF?=
 =?us-ascii?Q?/UkeMwC266VSGrNV/hcGMk5JAznAMfqvAvGym1Hons66NdpQdqnu5x4/mBDG?=
 =?us-ascii?Q?4xqpWPhe8X8jftrfl7nEzeJFxZ5aAf9kxUOyiXUs30iIcEXXc4fp4/FJFp3+?=
 =?us-ascii?Q?Fz5Gzc4NI/FED6R5gZjcO5JGaj0zDhOmFWtEEEVeo+1qN7jDi7+T2zEFOyIG?=
 =?us-ascii?Q?zEMRF4jGM/83mINeAvoATBxquFIxoEMKkA00t7Y3y9UX5P2ktVDQfDopPyOu?=
 =?us-ascii?Q?E0MViEWMfcPjW44TT03LPcPF2BTutkOGvKFnwG4QJC4iWBBkDpyPM49weflT?=
 =?us-ascii?Q?ROu3jlHeTATUiUw50PqZh1/lQINYFPlm0WfBkdupEwXUyiUBgnVmQ0MN7DcM?=
 =?us-ascii?Q?+2u3+mWYOr82Qxm+gbyqHmiOo6hGmVy7erQbaoi0JFoeb7JlNv3mfe8XE2P4?=
 =?us-ascii?Q?N71CfHSC2YkdyBxuMHkSCJqeeUTSTa9wjJZAmMNYX0+3ksTd75VwubxWTww5?=
 =?us-ascii?Q?w8A2yozHtEUyoc1FYm7Dnr+9XIDlcyy9iG5EUtP89E0Ka/MHG4bC1EE5ZFHV?=
 =?us-ascii?Q?byIk9vtbmvf/V2RrbNhEInsAYU+ItKfqysvO/4n/xhtcttdn+wRL8PZCjcqt?=
 =?us-ascii?Q?TzxRw+HE5BunfKM4gdJmMywvVWZ7Q894smWkE7NWoBmNMF1kbzAM4SV5bmOZ?=
 =?us-ascii?Q?PJfV5tuwNzpVhafCtGBBu3Ro9S6BJpkX79OeYdd/DYCGXmBwSxgDHgWqeHg/?=
 =?us-ascii?Q?d/mjJ9QusuJ6hiGCXjd7bH4FaCIL5a5dnlz3wHe6goi709gWEX9f/raAu+05?=
 =?us-ascii?Q?8Ok/N1lO3XD9JS6dzfFQ5ghDZTyywYLFuc7fqSUjXJSTSbfhldgU9u8AohU8?=
 =?us-ascii?Q?260xAhjJLcwt4tRrFAXsJNjbXxeTIOHgdZmPEtOPy3y4FzmO97wVuxbCR486?=
 =?us-ascii?Q?PkbGU7v37zd9YNt53fexpOMdReHIlidMcmm112vH6+tD8KdxhXLqS5pewifR?=
 =?us-ascii?Q?CIM2S8OMvNB88flf0+7BeyoZ8uGfPog1hCSrUr3YQl/JzUPTzFGxOi1uhrS8?=
 =?us-ascii?Q?NaXB+To3cDOUfubpdiTQRD90yyoD7Tn/A8wM6ZnFQX4aI2KXADTfHQX0guL8?=
 =?us-ascii?Q?hw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?5YyooUZxbOs057QnLjn0A0pv2RmbfzEXTtgpiRuxpderf4+yLnkDs2orIQz6?=
 =?us-ascii?Q?36ufkpG1jacwOfNySFD48sqvxOQtsVRjKnbjw78DjbsX5HfK7sR/teChR24T?=
 =?us-ascii?Q?GBxr1MoUOX3WbIey+eOcFhzuUABI1nsBadEIY0rtyRkRRu8D6Cb5GQQVS+JN?=
 =?us-ascii?Q?OMEZ/GS36wr5S1TsFxyBW5pMEOWPzz5TBrgH0xh7+wn4MHwSdFR/Pk8dx4sH?=
 =?us-ascii?Q?ZpU72QbGz2vKVANHxCFmSvOHorQtmbTgpW1PtJZzaiWGF4Zwm2lXBQR21dLl?=
 =?us-ascii?Q?TnjRYLmTk6McjQrbArSvT9z/PRntXsBTUICJgM1oRkOWHisOQK+MHXbzcRfn?=
 =?us-ascii?Q?iToZVKUvygavYCUfGLUdHYxG8+EOnHUju5cN9VCsuP9HP60oCx4ErsObLfP0?=
 =?us-ascii?Q?M7kXFGYd6lcjwTSTxv8HNsyepF+iCxr6r9aHle6TY7VzMnbXVGcpIhn6MCDZ?=
 =?us-ascii?Q?SaKzKrckS/jySVG/9lbhYw3tWWwf+XU8U3pukSZJ2OH3mvkye0/NeoNfu7nr?=
 =?us-ascii?Q?HWY5+TGxdYawW8CbxUVPMytGchQ7yTh57hWkUdLlKLcTMls1ZUk5r/RkW/MH?=
 =?us-ascii?Q?d314cR8fpSc7JAwIFsLtEg5HP0Xh90UA1OyG2ed8SSVN7oNyQgvsooSOHBVt?=
 =?us-ascii?Q?QhT0tMDhSCOeHFachDMP9a8fpaNrGgKBa5exJo87lIgyRrzR2fz66uh1L8Db?=
 =?us-ascii?Q?dbVQ7VWd+vXFDbgpUpqX2nS/Y4cT3nCQ/0eYojcZYw63lNt/nwyQD1wDwoCp?=
 =?us-ascii?Q?nPX5gFA8+piIezDItADb9jqM42mCz1CYJvWGlCCoQ4NqPE7d2GChSUpOZ6g/?=
 =?us-ascii?Q?bLPY4ZSIqLnoBE/O5CCAAwj3KFLbaOYdEnYp5A3GF48UIxgMO8cwDeU9/bw0?=
 =?us-ascii?Q?nRkDZZooNsU3oTgg9vQF77/QFS1OOw07INaX6mBasZFc1c5Gp7quJlVpKJ5s?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5baba60-f69c-43e3-2883-08db81571d00
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 15:05:35.3404
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HXMOza36T3XiOug2zy4CvW/rx4IIMOv7PEorfSc4OYOBo0ELu3QgXcCpDUOozYBLJquHtsvOCdANHfPQY0FsXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4127
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-10_11,2023-07-06_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 bulkscore=0
 suspectscore=0 spamscore=0 phishscore=0 mlxlogscore=999 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2307100136
X-Proofpoint-ORIG-GUID: MHBkljdTlfcbVaWwWy5mgZWflba3dF14
X-Proofpoint-GUID: MHBkljdTlfcbVaWwWy5mgZWflba3dF14
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Liam R. Howlett <Liam.Howlett@Oracle.com> [230707 11:18]:
> * Peng Zhang <zhangpeng.00@bytedance.com> [230707 06:11]:
> > Set the node limit of the root node so that the last pivot of all nodes
> > is the node limit (if the node is not full).

This patch also fixes a bug in mas_rev_awalk().  Effectively, always
setting a maximum makes mas_logical_pivot() behave as mas_safe_pivot().
Without this fix, it is possible that very small tasks would fail to
find the correct gap.  Although this has not been observed with real
tasks, it has been reported to happen in m68k nommu running the maple
tree tests.

Link: https://lore.kernel.org/linux-mm/CAMuHMdV4T53fOw7VPoBgPR7fP6RYqf=CBhD_y_vOg53zZX_DnA@mail.gmail.com/
Cc: <stable@vger.kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>

> > 
> > Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
> 
> This has been on my list of things to do for a while, thanks.
> 
> Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> 
> > ---
> >  lib/maple_tree.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> > index d3072858c280..f55e59bd9122 100644
> > --- a/lib/maple_tree.c
> > +++ b/lib/maple_tree.c
> > @@ -3692,7 +3692,8 @@ static inline int mas_root_expand(struct ma_state *mas, void *entry)
> >  	mas->offset = slot;
> >  	pivots[slot] = mas->last;
> >  	if (mas->last != ULONG_MAX)
> > -		slot++;
> > +		pivots[++slot] = ULONG_MAX;
> > +
> >  	mas->depth = 1;
> >  	mas_set_height(mas);
> >  	ma_set_meta(node, maple_leaf_64, 0, slot);
> > -- 
> > 2.20.1
> > 
> >