Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e201644d-c9bd-52d9-9d26-a18bc4def21f@intel.com>
Date:   Mon, 10 Jul 2023 16:39:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v5 RFC 2/6] page_pool: unify frag_count handling in
 page_pool_is_last_frag()
To:     Yunsheng Lin <linyunsheng@huawei.com>
CC:     <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Alexander Duyck <alexander.duyck@gmail.com>,
        Liang Chen <liangchen.linux@gmail.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        "Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
        Eric Dumazet <edumazet@google.com>
References: <20230629120226.14854-1-linyunsheng@huawei.com>
 <20230629120226.14854-3-linyunsheng@huawei.com>
Content-Language: en-US
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230629120226.14854-3-linyunsheng@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VU9wYlpBK1lJMWp5V1Uxa3UzT09vYTV1dVRKdEQraWdXUkRWVHdTYkViWmdy?=
 =?utf-8?B?L2hqWitJNm1qMEZVRG1EQ3hCS2NUY05wWnFCb2dKY3hXUnBMVEREYlZtelBy?=
 =?utf-8?B?VHFmVURhdzlCNWtPdEZQdk1lTUVKOGNDWTM4MHFyWk9VK1A2TlB5djBLbzlk?=
 =?utf-8?B?YjZqWVZyZjlPQm82LzlKR09XYTVKQkVibkRKNkpKWi9QbFZvQkgxalVNdmMv?=
 =?utf-8?B?SUI4c3dVckVHekpwdGF0V3dtNGZldE81TDE0VG9LMVJESDFEYkxWTjBMMUE3?=
 =?utf-8?B?QVduVHJBbzRtNDdYOWhPZmlac1RvK2hPU0lDcDhKWHVvS3I1T1JMZ0o4SWI0?=
 =?utf-8?B?RzZENEVoSXlxT1U0a2NyUUx1eGM0TlR0eVdtTzN3Vy9LY28wNG5nalpjaUkv?=
 =?utf-8?B?RlB1U0ZocFA2UE9oS1RnQjJFczFuc1gwWUFlUHkxNTgxU0VReEZNNW52UzN6?=
 =?utf-8?B?NUhydHlCQ0RTWVNkTW5DcmhJUjE3dlgzckZBVDZyMkdtV3B6SitONWtSL1dM?=
 =?utf-8?B?a3VGYU4raTZtYzd6cUJGcGs4RU5kY285bmUwZ1Nrb2VMdHRSZHY5YTd6WEta?=
 =?utf-8?B?cHNXaC9ZSktPY1Z2Zmo4Vm1qYU5oVDdmLzU0VjJ4VG5qRFRPTk42MTg0QVdH?=
 =?utf-8?B?alFxN29abmlDOGtqZTRWcnFuZXJlYy9uSzU5QmtXRVZqMDVlVTlpTC9OZWNv?=
 =?utf-8?B?c0JxMks0OVhoVzFtQjdtV0hwUTBhZjdhUWtKWFBLWExTbmRkQ1gyM05icERC?=
 =?utf-8?B?L2phRktEKzhzOUxBcEFPanBSdFBTdUhQOWRpcVAzWFl6M2sva2hwN1kxaS9w?=
 =?utf-8?B?MHBSS2d3NzFHUXM4cFdKaERMNHdxVDhDRTR3cThEekFCVVpVb2tLZE1MSHVO?=
 =?utf-8?B?WmpCM3ZYWFJvL2hGWjVRV0lRMndvMHp3T09kWURyeDI3ZzZXUEJRbUVHVWg4?=
 =?utf-8?B?Q1hhemNLUEc2RFNCSUlQNzVyeHlPSVpmY2ZrOVpGaXE1a0M0YXdXeGhWMzk5?=
 =?utf-8?B?ZEpweUlXcis1MnlaT2RxRzhaVmFVaExPWHBSZ28vZG8rYjNFUyt4RHVtd0t3?=
 =?utf-8?B?dXBVcEtrVWxyS2FQYnY2Q0tKVitLLzVRLzluUkxKeTNnbVJZNU5IS0EvME5I?=
 =?utf-8?B?UGtqa015L2NFNXhzZHgyaXFzRno1NjU4eEo4K0ozMkwyZXVkdEdpVjJ4TzJi?=
 =?utf-8?B?emJ1OEIxMVpJTTNzWEE4bkhwQnc4ai83Rm50V0lwcDBLUStrQmo2b2FyYkFV?=
 =?utf-8?B?RlozcC9GM1p6ajNpSlkzeDZWOFdTdnh3ZDdsOUpaTmhmK0VUR3NDOTFna3Y4?=
 =?utf-8?B?UTF3TVgvTURrQWpKY0tTdXJ6dkppQWE0YmN3SzJGTHRLVStWcmN4VDNwbktO?=
 =?utf-8?B?a2ovMEdocVA5dkFUem56YVk4Tlc1M2hDZVFQRlFTN3RZenI0ajE4TS90cXlz?=
 =?utf-8?B?SVJDUjdlZWlGbzNDRGUzNVNQU2tOS1k1RVJQQ2dZRUx5M1lNTW9odHpqYUlX?=
 =?utf-8?B?ZW1OUzFlWHUwK2JOSzJrTGpzZi8xMS9hRHdWM3JDa1dNejNWWEUyRFhkYTNj?=
 =?utf-8?B?QzdEcUJ1YkErZTFvenVhbzdJeU0zL3FVV2Q2NWZhcFBBVE1uWmtWODFwTXZh?=
 =?utf-8?B?UlRHazVmaEdTRmVJVnhpSmJUUTZXZDdJcVNXRHhUQWV2SlUySzZ4UTRZQ25w?=
 =?utf-8?B?YXlBcS9WMG9kMkYwZmExQzhVdFlzSjBXc0pkRk9KdS8rV092cGRjZHMySEZJ?=
 =?utf-8?B?ZFMzaTVVcVJ2N0toZlZUaWVpZkkzb3h2blpSbVFSSFZwSEZId1prNDJGTzhk?=
 =?utf-8?B?eWp3b0ppZk96TDNzRVI0UXRKb0F2TSsxUU4wVDZJc3laVm90RmNSQXp6UmR5?=
 =?utf-8?B?V3lTdGlBbmRaMXFJTDhVMGpIdjdaQjFZTVh0K0lJbkovOFUwSmJlREkvZ0po?=
 =?utf-8?B?SmlveGpERHpid0RzWmpta2VYS1o0ZllQU3I4VzNTd2RNS05Rb1RTd1dkYk5j?=
 =?utf-8?B?eGdIL1JKZjROczJHU0VrcENJcTA2eVlHVmJmYjlMMnVRekpLa3lSRGw3ZzN6?=
 =?utf-8?B?aUhmTG9ib1IyVU1yNW14M0lDZWxIMVViSis4clh1dnBtTWNGKzU4WHovR2xz?=
 =?utf-8?B?Sk5RL2tqb2hMYjdJaFJBaTU2MmQ3Zm41ajNlUHd1TWY1QUpxMEZYdG91QjZx?=
 =?utf-8?B?ZVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e98d4b14-fcec-4583-ed81-08db81538dcf
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 14:40:06.7071
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4hm/jNeGh/2Pjzq983q8Zr3Uv1uB3iBE0UDkXjwHMkV/EyP9Ei7R7SkZFSfd+/37mO5E+sZPEr5neeD5ZQeP6Y4Nn9B9hcaU3GeGld7/+w4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5268
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Yunsheng Lin <linyunsheng@huawei.com>
Date: Thu, 29 Jun 2023 20:02:22 +0800

> Currently when page_pool_create() is called with
> PP_FLAG_PAGE_FRAG flag, page_pool_alloc_pages() is only
> allowed to be called under the below constraints:
> 1. page_pool_fragment_page() need to be called to setup
>    page->pp_frag_count immediately.
> 2. page_pool_defrag_page() often need to be called to drain
>    the page->pp_frag_count when there is no more user will
>    be holding on to that page.

[...]

> @@ -352,12 +377,10 @@ static inline bool page_pool_is_last_frag(struct page_pool *pool,
>  {
>  	/* We assume we are the last frag user that is still holding
>  	 * on to the page if:
> -	 * 1. Fragments aren't enabled.
> -	 * 2. We are running in 32-bit arch with 64-bit DMA.
> -	 * 3. page_pool_defrag_page() indicate we are the last user.
> +	 * 1. We are running in 32-bit arch with 64-bit DMA.
> +	 * 2. page_pool_defrag_page() indicate we are the last user.
>  	 */
> -	return !(pool->p.flags & PP_FLAG_PAGE_FRAG) ||
> -	       PAGE_POOL_DMA_USE_PP_FRAG_COUNT ||
> +	return PAGE_POOL_DMA_USE_PP_FRAG_COUNT ||
>  	       (page_pool_defrag_page(page, 1) == 0);

Just noticed while developing: after this change, the first function
argument, i.e. @pool, is not needed anymore and can be removed.

[...]

Thanks,
Olek