Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d117e562-424f-d128-fa81-41ec9022409f@ixit.cz>
Date:   Mon, 10 Jul 2023 17:36:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: dts: rockchip: Drop invalid
 regulator-init-microvolt property
Content-Language: en-US
To:     Mark Kettenis <mark.kettenis@xs4all.nl>,
        Heiko Stuebner <heiko@sntech.de>
Cc:     d3adme4t@gmail.com, macromorgan@hotmail.com, jbx6244@gmail.com,
        f.kardame@manjaro.org, amadeus@jmu.edu.cn, robh+dt@kernel.org,
        linux.amoon@gmail.com, aurelien@aurel32.net, anarsoul@gmail.com,
        wiagn233@outlook.com, frattaroli.nicolas@gmail.com,
        strit@manjaro.org, luiz.von.dentz@intel.com, zonyitoo@gmail.com,
        wens@csie.org, jensenhuang@friendlyarm.com, lasstp5011@gmail.com,
        frank-w@public-files.de, pgwipeout@gmail.com, conor+dt@kernel.org,
        leo@nabam.net, andyshrk@163.com, krzysztof.kozlowski+dt@linaro.org,
        michael.riesch@wolfvision.net, jonas@kwiboo.se, festevam@denx.de,
        tobetter@gmail.com, jagan@amarulasolutions.com, cnsztl@gmail.com,
        cristian.ciocaltea@collabora.com, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, kernel@collabora.com
References: <20230707162217.675390-1-cristian.ciocaltea@collabora.com>
 <168899855919.1747213.9998138836668928892.b4-ty@sntech.de>
 <87wmz7q1fr.fsf@bloch.sibelius.xs4all.nl>
From:   David Heidelberg <david@ixit.cz>
In-Reply-To: <87wmz7q1fr.fsf@bloch.sibelius.xs4all.nl>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/07/2023 16:35, Mark Kettenis wrote:
>> From: Heiko Stuebner <heiko@sntech.de>
>> Date: Mon, 10 Jul 2023 16:16:16 +0200
>>
>> On Fri, 7 Jul 2023 19:22:17 +0300, Cristian Ciocaltea wrote:
>>> The 'regulator-init-microvolt' property is not currently supported by
>>> any driver, it was simply carried on from downstream kernels.
>>>
>>> The problem is also indicated by the following dtbs_check warning:
>>>
>>>    rk3588-rock-5b.dtb: pmic@0: regulators:dcdc-reg4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected)
>>>
>>> [...]
>> Applied, thanks!
>>
>> [1/1] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property
>>        commit: 4d08b19629495b29601991d09d07865694c25199
> This property *is used* by the drivers in U-Boot.  Dropping this from
> the Linux DTBs will likely result in broken boards the next time the
> U-Boot DTBs are synched again from Linux.  At least that is what
> happened before...
Well, if u-boot uses these properties, u-boot folks should document them 
in bindings ;-)
I found some u-boot mentions reviewing this patch, but only the DTS 
files copied from Linux poped-up.
>
> I think the right solution is to add this property to the DT binding
> instead.

Sure, it should be sent together with the revert.
DT binding property description could also note that the bootloader(s) 
use the value.

David

-- 
David Heidelberg
Consultant Software Engineer