Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Jul 2023 08:16:05 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, <ira.weiny@intel.com>,
        <dan.j.williams@intel.com>, <vishal.l.verma@intel.com>,
        <dave.jiang@intel.com>, <oohall@gmail.com>,
        <aneesh.kumar@linux.ibm.com>
CC:     <nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>
Subject: Re: [PATCH v3] libnvdimm/of_pmem: Replace kstrdup with devm_kstrdup
 and add check
Message-ID: <64ac20b56f0b3_ff2c929448@iweiny-mobl.notmuch>
References: <20230706085839.31145-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230706085839.31145-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?epWuPZXrSiyCDLNX9GQ/cO9A1YEOlqewIyClDBtIRKIo6H7eQgh3hMrlMT8T?=
 =?us-ascii?Q?QzK3AMadnwSl2N4MqIkXvKkf+FND8pv3ulB81pDWxo5B8CwDWsaQN4OXNKBD?=
 =?us-ascii?Q?p5H+9XawzULaC5fKglYTN8Chr0kcY6MOew+kqpIjJkEXj9CuEp09NZwC+XqB?=
 =?us-ascii?Q?Og1eUCL833t0ftXd2tEWyj6mFffGdWTMnxWyicE3PQMdQcodVfjx96KlJh7o?=
 =?us-ascii?Q?O7R946lQdo9XxTGI8hQ/1upHjKwOA7TU6vva1SjClXfrybfMQp+CMPqJXPPY?=
 =?us-ascii?Q?PPkiJExWdIuBvQtysrfyujUEe95/afe5idsr0pIO7Qd41Y2f6SiqmGD2pIs8?=
 =?us-ascii?Q?K1NaSrw4IBW/tPx4KMzwWyZkqwnYGjZkqOcyN/QFd6IArYHtSVfXLgxpRD4z?=
 =?us-ascii?Q?Y9Z7F7gSmwGzd5E7e6slk18eidbpyM2ZNYmob2e18L2SnSPx0RfMWi7+h0cE?=
 =?us-ascii?Q?8HA2R9FIIxuD6GUWEwHWI/yYVu9R2/5CJrFJNOq7JDR51zCgy+RQQpq7Dcyw?=
 =?us-ascii?Q?Zd45QrSAEC+VZftM8dN426xCo6uE1XAhXoycdNCKiFbK6VErLeE8XAVd6LiQ?=
 =?us-ascii?Q?VoQbHPNAkiwPY6kDc8fAWqN5vscfiH8/n3bbqGGfQE4emfkaw6RHeFqoyYeR?=
 =?us-ascii?Q?qpRtwDNu1U5A0HajYyF46P0XjEm1PChK/xM8GBKxQMpiCN072BvRPJBX5sj1?=
 =?us-ascii?Q?3SS6+McDexabyS0WrA+8di0CGYXIE5YpAND8SXQBp5WwvpjSdo726i8cOjbZ?=
 =?us-ascii?Q?keTHu9aUORVTTCweDU1yg9Iu2J23DkR8/4aoWCj4RSV+0JpTuJgOPOeF+xIy?=
 =?us-ascii?Q?SvjH9kV2SilXOO2JWOOXjHkIA44fY1kSM4allTnlwqsTUa6KnbhaD5/3wIMQ?=
 =?us-ascii?Q?oWltO+VBILrTqpPXPmPRbpoj/Q8BxRTds4hdfCyOjF1MTJqwoBdrtdZAs9aJ?=
 =?us-ascii?Q?oPg6GZmM2DOHEFEvblKmvEvUMqE7e8XdlB7n63+I0QFa2rrGYL5ENSTgo0gj?=
 =?us-ascii?Q?ruOLT6YapxS1Pp3uklK53cvJyW2afqB493Xen/YIPO6tLCE7jz/kOOxEZreF?=
 =?us-ascii?Q?ApdAgOiKV7Rx8khjIv7uAj0bKyWTSbAwzZqNWwJvjZL/BC6UL0TIe6pGvBP/?=
 =?us-ascii?Q?M3me42IgRdVj9bUqr5y9lwMj3dbesC8asLws/Clr+r9Y2pvh2P5JfUpUnJes?=
 =?us-ascii?Q?twnLi3o9aWvGqpXkdDBSJ2EZkHBkCJt7ka8069fY+kdcOg0JCFF/WTXl3bS5?=
 =?us-ascii?Q?VG4Lz8qh9BV00U7/agRh9E5B4hYo3xx+IR9NtPxmHlIvd3ERP/wWuoCK1/tD?=
 =?us-ascii?Q?jw3p1qNqYpUgQWXQNd6zXRnTTC5S1AAM49asZPfvM8ksM16HwCMN+wFtTpMy?=
 =?us-ascii?Q?vSILeyUvG3JwPk34MI37VXD/1aVXBrsUYBKCGuxn5/rDFCzji2YAWtCL4ilh?=
 =?us-ascii?Q?pTrkwI1w0xGu2O4exTUSCEBPj65BNEgJ9Ln8FkuCboA0XfvInMGpYjlvSguz?=
 =?us-ascii?Q?Mg9JGX1cJY9LggLLBe2uMeAdzFdTCvK3+YmjiUhq/QucoAHVjmbB3aE43DKS?=
 =?us-ascii?Q?cygHLxVTQBgEDIDtRJpFF7P8vBRYjPfFFgHYEquM?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e2b2aaa4-63ee-4380-2e07-08db81589759
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 15:16:10.1809
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MUbwRNdIYn5ZgQEFSLVtLVudT8sLVxnOAvPlDoTg8OJUJHkEzWRyhMHfP8xvWd5smesdXW+j4aXnTsajcaUSfQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5044
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Jiasheng Jiang wrote:
> Replace kstrdup() with devm_kstrdup() to avoid memory leak and
> add check for the return value of the devm_kstrdup() to avoid
> NULL pointer dereference
> 
> Fixes: 49bddc73d15c ("libnvdimm/of_pmem: Provide a unique name for bus provider")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

LTGM
Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ---
> Changelog:
> 
> v2 -> v3:
> 
> 1. Correct the usage of devm_kstrdup().
> 
> v1 -> v2:
> 
> 1. Replace kstrdup() with devm_kstrdup().
> ---
>  drivers/nvdimm/of_pmem.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
> index 10dbdcdfb9ce..1d2b1ab5b737 100644
> --- a/drivers/nvdimm/of_pmem.c
> +++ b/drivers/nvdimm/of_pmem.c
> @@ -30,7 +30,12 @@ static int of_pmem_region_probe(struct platform_device *pdev)
>  	if (!priv)
>  		return -ENOMEM;
>  
> -	priv->bus_desc.provider_name = kstrdup(pdev->name, GFP_KERNEL);
> +	priv->bus_desc.provider_name = devm_kstrdup(&pdev->dev, pdev->name, GFP_KERNEL);
> +	if (!priv->bus_desc.provider_name) {
> +		kfree(priv);
> +		return -ENOMEM;
> +	}
> +
>  	priv->bus_desc.module = THIS_MODULE;
>  	priv->bus_desc.of_node = np;
>  
> -- 
> 2.25.1
>