Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Jul 2023 17:41:10 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Piyush Mehta <piyush.mehta@amd.com>, nava.kishore.manne@amd.com,
        linux-kernel@vger.kernel.org, git@amd.com, wsa@kernel.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        broonie@kernel.org, conor+dt@kernel.org,
        devicetree@vger.kernel.org, dlemoal@kernel.org,
        michal.simek@amd.com, sebastian.reichel@collabora.com,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: firmware: add reset-controller property
Message-ID: <20230710-hatchery-pesky-6f837788e576@spud>
References: <20230709172542.1393828-1-piyush.mehta@amd.com>
 <168892849854.136160.7620779203584875736.robh@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="hXqBLkZYbGg49ffb"
Content-Disposition: inline
In-Reply-To: <168892849854.136160.7620779203584875736.robh@kernel.org>
Precedence: bulk


--hXqBLkZYbGg49ffb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jul 09, 2023 at 12:48:18PM -0600, Rob Herring wrote:
>=20
> On Sun, 09 Jul 2023 22:55:42 +0530, Piyush Mehta wrote:
> > The reset controller is responsible for managing both device-level rese=
ts
> > and individual PMC (Power Management Controller) block resets.
> >=20
> > To facilitate this functionality reset-controller property is added to =
the
> > firmware device tree binding.
> >=20
> > Signed-off-by: Piyush Mehta <piyush.mehta@amd.com>
> > ---
> >  .../firmware/xilinx/xlnx,zynqmp-firmware.yaml         | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >=20
>=20
> My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>=20
> yamllint warnings/errors:
>=20
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/f=
irmware/xilinx/xlnx,zynqmp-firmware.yaml:
> Error in referenced schema matching $id: http://devicetree.org/schemas/re=
set/xlnx,zynqmp-reset.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/f=
irmware/xilinx/xlnx,zynqmp-firmware.example.dtb: versal-firmware: reset-con=
troller: False schema does not allow {'compatible': ['xlnx,zynqmp-reset'], =
'#reset-cells': [[1]]}
> 	from schema $id: http://devicetree.org/schemas/firmware/xilinx/xlnx,zynq=
mp-firmware.yaml#
> Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.ex=
ample.dtb: /example-0/versal-firmware/reset-controller: failed to match any=
 schema with compatible: ['xlnx,zynqmp-reset']
>=20
> doc reference errors (make refcheckdocs):
>=20
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/202307=
09172542.1393828-1-piyush.mehta@amd.com
>=20
> The base for the series is generally the latest rc1. A different dependen=
cy
> should be noted in *this* patch.
>=20
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>=20
> pip3 install dtschema --upgrade
>=20
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your sch=
ema.
>=20

When you fix this error, please add an indication of the platform in
question to $subject, "dt-bindings: firmware: add reset-controller property"
sounds like it applies to all firmware bindings..

Cheers,
Conor.

--hXqBLkZYbGg49ffb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZKw0pgAKCRB4tDGHoIJi
0rnMAP4vUl3fJNAP7YMUJwwBkLCd2p+d2m74MMytBGPmwWImRQD8DfhzqqPCDxxX
PPaFDCUfBf0If2C2+cGKd2pO2kPGJAc=
=gMVg
-----END PGP SIGNATURE-----

--hXqBLkZYbGg49ffb--