Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Jul 2023 21:15:50 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     Guiting Shen <aarongt.shen@gmail.com>,
        claudiu.beznea@microchip.com, nicolas.ferre@microchip.com,
        alexandre.belloni@bootlin.com,
        linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: atmel: enable clk when pwm already enabled in
 bootloader
Message-ID: <20230710191550.7y6wukf7w44us4pd@pengutronix.de>
References: <20230710144214.63343-1-aarongt.shen@gmail.com>
 <ZKwdHUWzXujfVk0R@orome>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="sl2u4nnvvfnxkuqp"
Content-Disposition: inline
In-Reply-To: <ZKwdHUWzXujfVk0R@orome>
Precedence: bulk


--sl2u4nnvvfnxkuqp
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Mon, Jul 10, 2023 at 05:00:45PM +0200, Thierry Reding wrote:
> On Mon, Jul 10, 2023 at 10:42:14PM +0800, Guiting Shen wrote:
> > +		err =3D clk_enable(atmel_pwm->clk);
> > +		if (err) {
> > +			dev_err(atmel_pwm->chip.dev, "enable clock error\n");
>=20
> Might be worth to include the error code in the error message to make it
> easier to diagnose where the issue is. Something like:
>=20
> 	dev_err(atmel_pwm->chip.dev, "failed to enable clock: %d\n", err);

Or (IMHO) still better:

 	dev_err(atmel_pwm->chip.dev, "failed to enable clock: %pe\n", ERR_PTR(err=
));

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--sl2u4nnvvfnxkuqp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmSsWOUACgkQj4D7WH0S
/k6CrQf/ZPh7B0v/lMQB6XWIpLZAQoq8phbmh3ZJXFi4z0v5GilJwz3fkO6G5/qo
A4x4I1ZLOJcUDd+6n7MPPpKSI6n63GzOnHAJCeE7GcVMdGU/r/ZYyq7ygcZG5tJA
36EBJKhfLOuMEKcP2t3B9PsYfL1U1vX+id8ktFbx7KtqzOEAP2RcyO1gbxpMg0eW
MQ/L0vJaypD9BjS19iz9L29CVzEqeHelkEhm1CdahU+Gl3Uqc+DFzlwg1Cz/LyTT
gsHK5BB0OmmZcEaKYmpml/v6puUG8O2V+mq1dfff5mHTkWKtEW2IvbNS93hHclz3
E3cqFES0oP8mpOKfBEeFMhW+V2h6Iw==
=PsHM
-----END PGP SIGNATURE-----

--sl2u4nnvvfnxkuqp--