Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Jul 2023 12:33:08 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>
Cc:     Jason Baron <jbaron@akamai.com>, Jim Cromie <jim.cromie@gmail.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dyndbg: add source filename to prefix
Message-ID: <ZKxc9BiZIS5GHmV9@bombadil.infradead.org>
References: <20230709-dyndbg-filename-v2-0-fd83beef0925@weissschuh.net>
 <20230709-dyndbg-filename-v2-3-fd83beef0925@weissschuh.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230709-dyndbg-filename-v2-3-fd83beef0925@weissschuh.net>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Sun, Jul 09, 2023 at 11:18:00PM +0200, Thomas Wei?schuh wrote:
> Printing the line number without the file is of limited usefulness.
> 
> Knowing the filename also makes it also easier to relate the logged
> information to the controlfile.
> 
> Example:
> 
>     # modprobe test_dynamic_debug
>     # echo 'file test_dynamic_debug.c =pfsl' > /proc/dynamic_debug/control
>     # echo 1 > /sys/module/test_dynamic_debug/parameters/do_prints
>     # dmesg | tail -2
>     [   71.802212] do_cats:lib/test_dynamic_debug.c:103: test_dd: doing categories
>     [   71.802227] do_levels:lib/test_dynamic_debug.c:123: test_dd: doing levels
> 
> Signed-off-by: Thomas Wei?schuh <linux@weissschuh.net>
> Acked-by: Jim Cromie <jim.cromie@gmail.com>
> Acked-by: Jason Baron <jbaron@akamai.com>

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

  Luis