Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp35852481rwd; Mon, 10 Jul 2023 13:44:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlFMZtO5GbNqcmZpYW3/OhnUeCcaFegNK7WZ2hgMtqjMzLXa/YXf/n+RjiB7bYgi03u7PNlp X-Received: by 2002:a17:907:2905:b0:994:b53:77fc with SMTP id eq5-20020a170907290500b009940b5377fcmr3645146ejc.12.1689021863315; Mon, 10 Jul 2023 13:44:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689021863; cv=none; d=google.com; s=arc-20160816; b=YOypVVcZoDsSqGreXC+7cM2gZXDcq09ram2BKXUhUumHvO5ogLuy7fNHlt4MKar4B1 xpxwjQWlT9Ln5dwYzQGTgHA3T3mjAax/McMinNY7bAHbpovtQfBF6uaJhC6kBSNdFn0D o97PWdzOhvlmwS6Ezy3VhGPC3cy2nPoUOq923Y27MX+xdLO7B+M1zez8GU5MO1MrVaNY XgHAsS1vdX1Do62XCWRVPGvUoqXsR8Gg+aj6Ox/8k++ITKn5vAjvbfVsY4nfcRqEmc21 DldOGDA3vTapkGLS04dDOMq84OTRjyVmkPjSWNEPTWrdBAQ51f6aB71/1yBb5lCMzMav LNIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=nHU1dzE7xNXOPkHF0wA/9WZTTjO6ua7+Rl3gymY9uSU=; fh=SI2BVSJBiUhc60iYUwxBgVbV0GhTfrxj9bEbwbjdCns=; b=RLhc7Bo7fYuoG7yoKV+ikyMctAbVF0pXQbDh950XLFkUXr0VyZJPSOWYcWYO8dY9Sx 2/EynBUuTK62Nyzh+EaRl4ylhkla2zNDIJ3axp0pRtVkzcZTl8anZ2QYf2ZEZjda129H iWSw5RqeD+FnpRtgfYwMjOS5Ns/eJZH+DHY7cCL08RCo9H7sxJgOOETTWiAjVwKylbj2 uqfjwYpmiGa6Hn4XH+8Ehp0RdbBjVNm14fa0yoiufk+7LdgZSj+qxl4r9Z+u8KSaolhF AKjZW9RBVvnAnghS07YFOd2RJRn96VkKZEALpF/1BpmNWkhZaubluy/uhtVI6D8T7IHC gxEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NI6WSYFz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ay15-20020a170906d28f00b00982733d446csi353808ejb.410.2023.07.10.13.43.59; Mon, 10 Jul 2023 13:44:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NI6WSYFz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230023AbjGJUdG (ORCPT + 99 others); Mon, 10 Jul 2023 16:33:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230465AbjGJUdB (ORCPT ); Mon, 10 Jul 2023 16:33:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A813DAD; Mon, 10 Jul 2023 13:33:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 439CE611DC; Mon, 10 Jul 2023 20:33:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D16EC433C7; Mon, 10 Jul 2023 20:32:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689021179; bh=DUlvTGQbRlgHfvUIq64vgJvepRuPbwJU9Mj7tz1rw0s=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=NI6WSYFz2jmNWfkEvf0+/P78If/lMk7teaGNbkY14oPG5LxNRAlbj3Bw7XgvDAri5 aTMP2DQUhXpyDUvhmCsZHFCDg4mERmtcsk/aN5ClHpjAMGiEqGJUI5mLhbkJWuqDlc SbxjivQ/TM4XEcCIeRdi84/dubkMYys++Rwh3i7HMtTnHfeZwyoJfAKcAUvGbG/usx 3zNzr4VpWHKOtZAMn2II9nS/fZjIb3xQtPk3UU2kNWxZn65BPj3s97gyQ6SeGZcBjh eHO4HbQmZGmXLK+WvCvL5++3LjQdtoLrEr1iTKyi2C1uGxWZ8YdaVYymu1V+lHmk0T 6P2D1Ns9lM9jA== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 213B7CE008B; Mon, 10 Jul 2023 13:32:59 -0700 (PDT) Date: Mon, 10 Jul 2023 13:32:59 -0700 From: "Paul E. McKenney" To: Joel Fernandes Cc: Zhen Lei , Frederic Weisbecker , Neeraj Upadhyay , Josh Triplett , Boqun Feng , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , rcu@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] rcu: Don't dump the stalled CPU on where RCU GP kthread last ran twice Message-ID: <33ec8708-35be-446a-8cc5-58d366a6d75d@paulmck-laptop> Reply-To: paulmck@kernel.org References: <20230705073020.2030-1-thunder.leizhen@huawei.com> <20230705073020.2030-3-thunder.leizhen@huawei.com> <39430021-dc0d-4abd-8266-642e4e2dc7df@paulmck-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 10, 2023 at 03:55:16PM -0400, Joel Fernandes wrote: > On Mon, Jul 10, 2023 at 3:06 PM Paul E. McKenney wrote: > > > > On Wed, Jul 05, 2023 at 03:30:20PM +0800, Zhen Lei wrote: > > > The stacks of all stalled CPUs will be dumped. If the CPU on where RCU GP > > > kthread last ran is stalled, its stack does not need to be dumped again. > > > > > > Signed-off-by: Zhen Lei > > > > This one looks good. Please feel free to rebase it before 1/2 and repost. > > Just a small comment: > I wondered if this would make it harder to identify which stack among > the various CPU stacks corresponds to the one the GP kthread is > running on. However, this line does print the CPU number of the > thread, so it is perhaps not an issue: > > pr_err("%s kthread starved for %ld jiffies! g%ld f%#x > %s(%d) ->state=%#x ->cpu=%d\n", > > Reviewed-by: Joel Fernandes (Google) Thank you! Zhen Lei, please feel free to add Joel's Reviewed-by on your next posting. Thanx, Paul