Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230710055614.1030300-1-sanpeqf@gmail.com> <ZKw+6edWZJoSPGdn@google.com>
In-Reply-To: <ZKw+6edWZJoSPGdn@google.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Mon, 10 Jul 2023 14:12:50 -0700
Message-ID: <CAEf4Bzb-xSmpVFM_nCX7DgLuT=tR2GRCDHa0mw8FwO-rpy3xoA@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] libbpf: fix some typo of hashmap init
To:     Stanislav Fomichev <sdf@google.com>
Cc:     John Sanpe <sanpeqf@gmail.com>, daniel@iogearbox.net,
        ast@kernel.org, andrii@kernel.org, martin.lau@linux.dev,
        song@kernel.org, yhs@fb.com, john.fastabend@gmail.com,
        kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org,
        bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 10, 2023 at 10:25=E2=80=AFAM Stanislav Fomichev <sdf@google.com=
> wrote:
>
> On 07/10, John Sanpe wrote:
> > Remove the whole HASHMAP_INIT. It's not used anywhere in libbpf.
> >
> > Signed-off-by: John Sanpe <sanpeqf@gmail.com>
>
> Acked-by: Stanislav Fomichev <sdf@google.com>
>
> Doesn't look like it was ever used.

Ack for the change, but the subject doesn't correspond to the change
itself. You are not fixing typo, you are removing static
initialization helper.