Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Jul 2023 14:36:19 -0700
In-Reply-To: <20230626113540-mutt-send-email-mst@kernel.org>
Mime-Version: 1.0
References: <000000000000df3e3b05ff02fe20@google.com> <20230626031411-mutt-send-email-mst@kernel.org>
 <216718d1-1e32-9ebc-bd5e-96beab3fdc1b@oracle.com> <20230626113540-mutt-send-email-mst@kernel.org>
Message-ID: <ZKx509XelfwPIkhX@google.com>
Subject: Re: [syzbot] [net?] [virt?] [kvm?] KASAN: slab-use-after-free Read in __vhost_vq_attach_worker
From:   Sean Christopherson <seanjc@google.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     Mike Christie <michael.christie@oracle.com>,
        syzbot <syzbot+8540db210d403f1aa214@syzkaller.appspotmail.com>,
        jasowang@redhat.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        syzkaller-bugs@googlegroups.com,
        virtualization@lists.linux-foundation.org
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

On Mon, Jun 26, 2023, Michael S. Tsirkin wrote:
> On Mon, Jun 26, 2023 at 10:03:25AM -0500, Mike Christie wrote:
> > On 6/26/23 2:15 AM, Michael S. Tsirkin wrote:
> > > On Mon, Jun 26, 2023 at 12:06:54AM -0700, syzbot wrote:
> > >> Hello,
> > >>
> > >> syzbot found the following issue on:
> > >>
> > >> HEAD commit:    8d2be868b42c Add linux-next specific files for 20230623
> > >> git tree:       linux-next
> > >> console+strace: https://syzkaller.appspot.com/x/log.txt?x=12872950a80000
> > >> kernel config:  https://syzkaller.appspot.com/x/.config?x=d8ac8dd33677e8e0
> > >> dashboard link: https://syzkaller.appspot.com/bug?extid=8540db210d403f1aa214
> > >> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> > >> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=15c1b70f280000
> > >> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=122ee4cb280000
> > >>
> > >> Downloadable assets:
> > >> disk image: https://storage.googleapis.com/syzbot-assets/2a004483aca3/disk-8d2be868.raw.xz
> > >> vmlinux: https://storage.googleapis.com/syzbot-assets/5688cb13b277/vmlinux-8d2be868.xz
> > >> kernel image: https://storage.googleapis.com/syzbot-assets/76de0b63bc53/bzImage-8d2be868.xz
> > >>
> > >> The issue was bisected to:
> > >>
> > >> commit 21a18f4a51896fde11002165f0e7340f4131d6a0
> > >> Author: Mike Christie <michael.christie@oracle.com>
> > >> Date:   Tue Jun 13 01:32:46 2023 +0000
> > >>
> > >>     vhost: allow userspace to create workers
> > >>
> > >> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=130850bf280000
> > >> final oops:     https://syzkaller.appspot.com/x/report.txt?x=108850bf280000
> > >> console output: https://syzkaller.appspot.com/x/log.txt?x=170850bf280000
> > >>
> > >> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> > >> Reported-by: syzbot+8540db210d403f1aa214@syzkaller.appspotmail.com
> > >> Fixes: 21a18f4a5189 ("vhost: allow userspace to create workers")
> > > 
> > > Mike, would appreciate prompt attention to this as I am preparing
> > > a pull request for the merge window and need to make a
> > > decision on whether to include your userspace-controlled
> > > threading patchset.
> > > 
> > 
> > Do you want me to resubmit the patchset or submit a patch against your vhost
> > branch?
> 
> Resubmit pls.

Closing this out from syzbot's perspective since v9 (now in linux-next and Linus'
tree) added back Mike's fix.

#syz invalid