Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e0fe4f98d28e98d04611c06bd9320bee53998e65.camel@kernel.org>
Subject: Re: [PATCH 21/26] x86/sgx: use array_size
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Julia Lawall <Julia.Lawall@inria.fr>
Cc:     keescook@chromium.org, kernel-janitors@vger.kernel.org,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 11 Jul 2023 01:02:57 +0300
In-Reply-To: <20230623211457.102544-22-Julia.Lawall@inria.fr>
References: <20230623211457.102544-1-Julia.Lawall@inria.fr>
         <20230623211457.102544-22-Julia.Lawall@inria.fr>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.1-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-06-23 at 23:14 +0200, Julia Lawall wrote:
> Use array_size to protect against multiplication overflows.
>=20
> The changes were done using the following Coccinelle semantic patch:
>=20
> // <smpl>
> @@
>     expression E1, E2;
>     constant C1, C2;
>     identifier alloc =3D {vmalloc,vzalloc};
> @@
>    =20
> (
>       alloc(C1 * C2,...)
> >=20
>       alloc(
> -           (E1) * (E2)
> +           array_size(E1, E2)
>       ,...)
> )
> // </smpl>
>=20
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>=20
> ---
>  arch/x86/kernel/cpu/sgx/main.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/arch/x86/kernel/cpu/sgx/main.c b/arch/x86/kernel/cpu/sgx/mai=
n.c
> index 166692f2d501..3a234942c586 100644
> --- a/arch/x86/kernel/cpu/sgx/main.c
> +++ b/arch/x86/kernel/cpu/sgx/main.c
> @@ -628,7 +628,8 @@ static bool __init sgx_setup_epc_section(u64 phys_add=
r, u64 size,
>  	if (!section->virt_addr)
>  		return false;
> =20
> -	section->pages =3D vmalloc(nr_pages * sizeof(struct sgx_epc_page));
> +	section->pages =3D vmalloc(array_size(nr_pages,
> +					    sizeof(struct sgx_epc_page)));
>  	if (!section->pages) {
>  		memunmap(section->virt_addr);
>  		return false;
>=20

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko