Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Jul 2023 17:54:36 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Zheng Yejian <zhengyejian1@huawei.com>
Cc:     <mhiramat@kernel.org>, <shuah@kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-trace-kernel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/ftrace: Test toplevel-enable for instance
Message-ID: <20230710175415.2ec0061f@gandalf.local.home>
In-Reply-To: <20230609174626.66659892@gandalf.local.home>
References: <20230509203659.1173917-1-zhengyejian1@huawei.com>
        <20230609174626.66659892@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk


Hi Shuah,

I think this dropped through the cracks. Can you take this through your
tree?

-- Steve

On Fri, 9 Jun 2023 17:46:26 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 10 May 2023 04:36:59 +0800
> Zheng Yejian <zhengyejian1@huawei.com> wrote:
> 
> > 'available_events' is actually not required by
> > 'test.d/event/toplevel-enable.tc' and its Existence has been tested in
> > 'test.d/00basic/basic4.tc'.
> > 
> > So the require of 'available_events' can be dropped and then we can add
> > 'instance' flag to test 'test.d/event/toplevel-enable.tc' for instance.
> > 
> > Test result show as below:
> >  # ./ftracetest test.d/event/toplevel-enable.tc
> >  === Ftrace unit tests ===
> >  [1] event tracing - enable/disable with top level files [PASS]
> >  [2] (instance)  event tracing - enable/disable with top level files [PASS]
> > 
> >  # of passed:  2
> >  # of failed:  0
> >  # of unresolved:  0
> >  # of untested:  0
> >  # of unsupported:  0
> >  # of xfailed:  0
> >  # of undefined(test bug):  0
> > 
> > Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>  
> 
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> 
> -- Steve
> 
> > ---
> >  tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> > index 93c10ea42a68..8b8e1aea985b 100644
> > --- a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> > @@ -1,7 +1,8 @@
> >  #!/bin/sh
> >  # SPDX-License-Identifier: GPL-2.0
> >  # description: event tracing - enable/disable with top level files
> > -# requires: available_events set_event events/enable
> > +# requires: set_event events/enable
> > +# flags: instance
> >  
> >  do_reset() {
> >      echo > set_event