Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Tue, 11 Jul 2023 03:26:26 +0300
Message-Id: <CTYX04LNR79S.H0RECMGHF1BM@suppilovahvero>
Cc:     <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] tpm: remove redundant variable len
From:   "Jarkko Sakkinen" <jarkko@kernel.org>
To:     "Colin Ian King" <colin.i.king@gmail.com>,
        "Peter Huewe" <peterhuewe@gmx.de>,
        "Jason Gunthorpe" <jgg@ziepe.ca>, <linux-integrity@vger.kernel.org>
References: <20230616170730.2343540-1-colin.i.king@gmail.com>
In-Reply-To: <20230616170730.2343540-1-colin.i.king@gmail.com>
Precedence: bulk

On Fri Jun 16, 2023 at 8:07 PM EEST, Colin Ian King wrote:
> Variable len is being accumulated but the value is never read. It is
> redundant and can be removed. Cleans up clang scan build warning:
>
> drivers/char/tpm/eventlog/tpm1.c:276:2: warning: Value stored to 'len' is=
 never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/char/tpm/eventlog/tpm1.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog=
/tpm1.c
> index 8aa9057601d6..12ee42a31c71 100644
> --- a/drivers/char/tpm/eventlog/tpm1.c
> +++ b/drivers/char/tpm/eventlog/tpm1.c
> @@ -251,7 +251,6 @@ static int tpm1_binary_bios_measurements_show(struct =
seq_file *m, void *v)
> =20
>  static int tpm1_ascii_bios_measurements_show(struct seq_file *m, void *v=
)
>  {
> -	int len =3D 0;
>  	char *eventname;
>  	struct tcpa_event *event =3D v;
>  	unsigned char *event_entry =3D
> @@ -273,7 +272,7 @@ static int tpm1_ascii_bios_measurements_show(struct s=
eq_file *m, void *v)
>  	/* 3rd: event type identifier */
>  	seq_printf(m, " %02x", do_endian_conversion(event->event_type));
> =20
> -	len +=3D get_event_name(eventname, event, event_entry);
> +	get_event_name(eventname, event, event_entry);
> =20
>  	/* 4th: eventname <=3D max + \'0' delimiter */
>  	seq_printf(m, " %s\n", eventname);
> --=20
> 2.39.2

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko