Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp36076690rwd; Mon, 10 Jul 2023 17:43:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlHPUMfqVMaM4uh2uXHW9s/SQGXcm4iDMbvg4ri6eC8rUnU4yAj/qo5+JYLWoaWNVl+nMli+ X-Received: by 2002:a05:6512:b96:b0:4fb:a990:bb28 with SMTP id b22-20020a0565120b9600b004fba990bb28mr14640298lfv.18.1689036230176; Mon, 10 Jul 2023 17:43:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689036230; cv=none; d=google.com; s=arc-20160816; b=aSSPQFbAqKxdcmeb8FvO9gXKjmeqO5O2+Jz5IomlkuPbOLJvcoJD0KnDOwlv+W1tKm WUedMfYwFBrHSSYckXhsdSONrQWO6yTEUCwYd2KUA5ADMm/dQnE1ienFyLItQ8/LtQkR F2OKQ8IA62kUMIQqwhzziWR/16d0XVQSXqVuS1xdxRSjzdedxukzwJllz1gtjfhRzVnt YU0HWqzgAIDySW3J/mDybUXYWXpIPML2tg1KyNMI+somqNUQ6afUCKGwQbw3ko+7C8lf +LXt43FW8xogxyHU3wfo0XB585ozt8HHJehDoX+1sdzmb9mKGQDwUPbl1tBwwBTTRbzJ aPdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=phtS90SFWoSB2M/4/0tBAboFQka70onYYgDuF8Bnzxc=; fh=N6jG6feUCYyI8rNycqLbH8cdgu9nQPnStUppAWdycIM=; b=ZAhWgWlJi1U+UQfsldd4x9Go6wDUzL5TOoUIoNBYauAJ8+pgJP6MmyelTvc3CunKP3 ziHdBfJ2Qc3S+0vxfaOuxjgUlyi89w+ZCJR81Y77IQoSVm52Xau8+k5oL6B09hzyg/iU ZT8z+7SSSPmkL+Enrz+LSl37QHw67fUH1Gdn35biYpkjM4GQqrXYw0MMEGd8u6TvQKsz itizbWZEqrQZpI27h2Vh6ozfTUo82oeuZM9uQvpLTNx6bDRwqp7tIS0ZiifdI70PnCrc rBWrixzXqXABmqhyxAED1EOhCgPwRTq/fkWK9Nk5Bkquk5UQLLdk65XmY9zv7+Q38F4o JHFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=H2lFKBB4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b24-20020a05640202d800b0051e5ca7a5e6si799704edx.681.2023.07.10.17.43.27; Mon, 10 Jul 2023 17:43:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=H2lFKBB4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229668AbjGKAZq (ORCPT + 99 others); Mon, 10 Jul 2023 20:25:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbjGKAZp (ORCPT ); Mon, 10 Jul 2023 20:25:45 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D01DFB for ; Mon, 10 Jul 2023 17:25:44 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so3669197a12.1 for ; Mon, 10 Jul 2023 17:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689035143; x=1691627143; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=phtS90SFWoSB2M/4/0tBAboFQka70onYYgDuF8Bnzxc=; b=H2lFKBB4nwZykWf0S6hXoh87mX9BBwJym1C/L2D29S/MCmY0+k5ss2gWud7lsrybyE 92SMnd4c0fCXGYKHvgla6sUD2I02yhzxAQvmTYC1hdddf+f0Bd517tq8mWCf14elW2RR S+vgMUHkpRTtel8PwB6cQfvwWpK8+tkhTcn1c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689035143; x=1691627143; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=phtS90SFWoSB2M/4/0tBAboFQka70onYYgDuF8Bnzxc=; b=BaomTKVcXl11T4/Bw5FSHAk6Xprn4HxyW8NRssxyb2GbHD5oCDybdwCpcHzPVt41wp RVSh3cqhyYt/kF2gXWVYxLE9KzZQpDooR0O0uc8PdKsTv7ukIriEZDqUff5YNf1OSW05 RwN2cnJxUGPkGbkRhbMWZR5G3cinMjQWY4fME0F5YO+4rJjTRH68iegg6jHtlJesMHCA qDDBOZAQg3HaBx+BSUx04sLDMXChImel7GZn1iWCkWlMt6CnI8zdJYOmv9+i8Ucydpvb QaqsL3dlxFKsScLvcjXFtC8FvPydZQptyO9pIwn0MkaZ8pFuBrphdnYjmtvJ6Lfez1gO FZtA== X-Gm-Message-State: ABy/qLbfmbB61putUG2P7x9jXeg3+eEKo5ccbXvtmFbgFuuquvlETxE0 0LAy3FstTU2s4cnlyprZrKwwxA== X-Received: by 2002:a17:903:48a:b0:1b8:72e2:9c4 with SMTP id jj10-20020a170903048a00b001b872e209c4mr13853651plb.60.1689035143415; Mon, 10 Jul 2023 17:25:43 -0700 (PDT) Received: from google.com ([110.11.159.72]) by smtp.gmail.com with ESMTPSA id c2-20020a170902d90200b001b88af04175sm480789plz.41.2023.07.10.17.25.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 17:25:43 -0700 (PDT) Date: Tue, 11 Jul 2023 09:25:36 +0900 From: Sergey Senozhatsky To: John Ogness Cc: Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, Jason Wessel , Daniel Thompson , Douglas Anderson , Aaron Tomlin , kgdb-bugreport@lists.sourceforge.net Subject: Re: [PATCH printk v2 1/5] kdb: do not assume write() callback available Message-ID: <20230711002536.GB12154@google.com> References: <20230710134524.25232-1-john.ogness@linutronix.de> <20230710134524.25232-2-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710134524.25232-2-john.ogness@linutronix.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FSL_HELO_FAKE, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (23/07/10 15:51), John Ogness wrote: > It is allowed for consoles to provide no write() callback. For > example ttynull does this. > > Check if a write() callback is available before using it. > > Signed-off-by: John Ogness > Reviewed-by: Petr Mladek > Reviewed-by: Douglas Anderson > Reviewed-by: Daniel Thompson Reviewed-by: Sergey Senozhatsky