Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f2f23ca1-0881-4601-7ea5-c5e42ab83f62@intel.com>
Date:   Tue, 11 Jul 2023 09:40:37 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 0/5] iommu/vt-d: debugfs: Enhancements to IOMMU debugfs
Content-Language: en-US
To:     "Tian, Kevin" <kevin.tian@intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20230625150442.42197-1-Jingqi.liu@intel.com>
 <BN9PR11MB5276885D6A142BC94D80C2618C29A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <4f18a7ca-3a57-0097-51f0-490f876831dc@intel.com>
 <BN9PR11MB5276ECF766C4F89F5083992F8C2EA@BN9PR11MB5276.namprd11.prod.outlook.com>
From:   "Liu, Jingqi" <jingqi.liu@intel.com>
In-Reply-To: <BN9PR11MB5276ECF766C4F89F5083992F8C2EA@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0lpU001R3kwckU2V3RyRGZ6dUlBeWp5WlhRNUdrUmNpNHh6TzBNL1RtSEpy?=
 =?utf-8?B?b3pZRlc0R0g5Z1QydS91dDNDZzBHcm1WemtiSVZqZmJXK1c2emxuMzZ0MWlt?=
 =?utf-8?B?MWYrNk5kc2dJMVdKTW4wZWowa0c2QkIwRnF6SVVkVldaM293ZFNYZGVZK1kv?=
 =?utf-8?B?YUg0cW0vV2FWOTlObkhneWZDUDg2ZHJoSXVqeWNzd1VDYUN4Yys1OVEzdzNq?=
 =?utf-8?B?YWFBWHVGYVVNVkswRUtCUVRuRkxCc0lSc2VjOXFDRjFva3ZoNlY1Y0xBNzk0?=
 =?utf-8?B?WndlYmJKMERLSTZKQ3VORmNJOGtyWDlyOEdCNTQvNE9KR3N4ZmFkanM0SXFM?=
 =?utf-8?B?Tktua1pWMUFtMEdYamdSNC9LNnZrRWlwMnFWdDhEM2RVYUN3TW4rbXlTSG94?=
 =?utf-8?B?aTJyLzk4b1pRcDFDVzlSRnZraTVOOTIycWVTVEVpT2RDVXk4RlpTSWs3alF1?=
 =?utf-8?B?aVJoZE93OCtNQUhZaHErNW1aZWV6TnAyNDVCMXlJbzQ5dHR1M2JXbnZ0UTc3?=
 =?utf-8?B?MzdqL3NOSVpFN29TeDd4Z3JlSTFUQlMyYnRxMVorVGRIOWVPVkhCRVZEL0tu?=
 =?utf-8?B?MTRWR05VUmpNQUFGU2hwcEVXSHkrOGxabHVMMXQ5Qk5RUmxmVGFXOTZZSklj?=
 =?utf-8?B?UFZGZWRjSVRmdU90c0NsR2FSNVRlNGJGK1VKQ3RvUEdpODRXVWVTbWVobFcr?=
 =?utf-8?B?cENaejh4VUFXYktTTWp4dGJNVFo1VW9zeS94eDB1SmRNa2wyODRGOHJxTkpO?=
 =?utf-8?B?bVNvRnZqVXBKMDFWcWI5OVFDRytqalRzWjdVNzNvVnR5dGh6UjFKaEw2Y3V3?=
 =?utf-8?B?clhDK090eEgwMlVmSTZPQkM2RER6WGtzd0RMTjZHRXJRRjRyK0dLWnZJdlp2?=
 =?utf-8?B?UkxQYUNVYXZpYnErTktJaDBtdVF4RW03WVAzRnRZZkp0N212SzJVTXNieXFj?=
 =?utf-8?B?ekV3Uzhra01WanNUOU5HT1gwMmMvcTBjM1VYejUwVUpCMjNDM29vTTcvcmJ0?=
 =?utf-8?B?MEY0S2dEUnNuaTJVb0JMQ0RSV2tqTlRLSmw3S1YrWE5hWUY3aVBCUm95aGh1?=
 =?utf-8?B?U0ZXMFJ4WkhmbVhPcXcxSzRjNWZrSmttMENiTHJXUTl6U3E3ZC9OMDJ2VUpJ?=
 =?utf-8?B?bnhJd2dmcEVPWU94Rlh5aWpOYW1icnFyWFZWWFo2NDBnL2xNZmNRWnFnK1h1?=
 =?utf-8?B?RHpDOHVCU0I4Z2JEcC9iUm9vVzE4SVQ2OWM5SlUrc0dzdkxNQXJha1JEQSsr?=
 =?utf-8?B?R1BBWXdDcjBmNEVsWU1lVFVxaytBZTV6YmwrdWR6d3l5Wml2ZThLQjJoTHFy?=
 =?utf-8?B?OXBFTWh5RU1Ybm1KUXV3UWw5RnJCbnIwNWZUNEZDbnFDSkFQT29mRWlWL3F5?=
 =?utf-8?B?TkYrWHo0VVlGWlhqMVo1QzlpdGx4cExYdnZJWTJoWi94Q3g3WVlZWHdDQU5i?=
 =?utf-8?B?aXlEaW5QZlZLSGV6UFdKTVZiNVU0SGRTdEtqOCswemdBMnR4eXdQZ2VhejRX?=
 =?utf-8?B?Z3RlNTlSYno5T1BUeDY3V1k0UDloMW9aNWdXVUFXRUZQdG1weThrZE14ZGht?=
 =?utf-8?B?S3BUZVRKSGJWM1RSMEdCWkdHZXBBL0lFUHBHYW1HRFczeTQ5RWpqZFJ4N2NK?=
 =?utf-8?B?bWZyS3FaVjVCUXdMWmRaV0lxTlFwb3Rjd1JZQkhZbmNDc1ovWTExM1JXMWh2?=
 =?utf-8?B?S2w2SlVSQVF4dk8wLzVGMW1SdkdJOFNqN0dsb0RKOVlXMm1CN0x4R0FoSUFk?=
 =?utf-8?B?S1Y0VTUyTVIxMjlhWDM4Nll3UmdoejRzS2YrOSswSXFmVkU3aitFaFpyenFh?=
 =?utf-8?B?dWhVbkxsU3lhTm9RRHFEelFjQWREK0Z5Q2JLTnVnbllxTVhpL3ptUkhiV3lL?=
 =?utf-8?B?dGgvMkVGZWNvYlY1cHVNc1pjN2hZd0VjMnhMT2FtWCthNU5EWjRzRElRb3hU?=
 =?utf-8?B?eFlZRUwrTnlaYkpFOFNoYVlLRDJEYzY2d3p5QjdaYkpRbVJYRXpMcVZSU2xv?=
 =?utf-8?B?bFB1bXpSbzFMcG1uSGlBd2ZzdG1lc2cxZU03TDdrckZLcGZvQmlOaXQ0RmU0?=
 =?utf-8?B?U0xCcW9qSnVlNkxISHNEUng4bVhtd3RvWkxlMXFQaU1oSllKZFZlTGI5RVFT?=
 =?utf-8?Q?tFeoIqSwbuFN0xAnvR3KzUUYV?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7aa889a8-202c-4d7a-0998-08db81afd984
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5469.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 01:40:47.5036
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1XkLDNzYbFVnzHh8SIdRebvTYh0Xmg/9PIrT591AtHCxmcB5p8E17Mfx8yc3CYOfs/tzk4iuhV03SXYHIfgTqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6257
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/4/2023 3:54 PM, Tian, Kevin wrote:
>> From: Liu, Jingqi <jingqi.liu@intel.com>
>> Sent: Monday, July 3, 2023 10:37 PM
>>
>> On 7/3/2023 3:15 PM, Tian, Kevin wrote:
>>>> From: Liu, Jingqi <jingqi.liu@intel.com>
>>>> Sent: Sunday, June 25, 2023 11:05 PM
>>>>
>>>> The original debugfs only dumps all IOMMU page tables without pasid
>>>> supported. It traverses all devices on the pci bus, then dumps all page
>>>> tables based on device domains. This traversal is from software
>>>> perspective.
>>>>
>>>> This series dumps page tables by traversing root tables, context tables,
>>>> pasid directories and pasid tables from hardware perspective. By
>>>> specifying source identifier and PASID, it supports dumping specified
>>>> page table or all page tables in legacy mode or scalable mode.
>>>>
>>>> For a device that only supports legacy mode, specify the source
>>>> identifier, and search the root table and context table to dump its
>>>> page table. It does not support to specify PASID.
>>>>
>>>> For a device that supports scalable mode, specify a
>>>> {source identifier, PASID} pair and search the root table, context table
>>>> and pasid table to dump its page table.  If the pasid is not specified,
>>>> it is set to RID_PASID.
>>>>
>>>> Switch to dump all page tables by specifying "auto".
>>>>
>>>> Examples are as follows:
>>>> 1) Dump the page table of device "00:1f.0" that only supports legacy
>>>> mode.
>>>>
>>>> $ sudo echo 00:1f.0 >
>>>> /sys/kernel/debug/iommu/intel/domain_translation_struct
>>>> $ sudo cat /sys/kernel/debug/iommu/intel/domain_translation_struct
>>>> Device 0000:00:1f.0 @0x105407000
>>>> IOVA_PFN                PML5E                   PML4E
>>>> 0x0000000000000 |       0x0000000000000000      0x0000000105408003
>>>> 0x0000000000001 |       0x0000000000000000      0x0000000105408003
>>>> 0x0000000000002 |       0x0000000000000000      0x0000000105408003
>>>> 0x0000000000003 |       0x0000000000000000      0x0000000105408003
>>>>
>>>> PDPE                    PDE                     PTE
>>>> 0x0000000105409003      0x000000010540a003      0x0000000000000003
>>>> 0x0000000105409003      0x000000010540a003      0x0000000000001003
>>>> 0x0000000105409003      0x000000010540a003      0x0000000000002003
>>>> 0x0000000105409003      0x000000010540a003      0x0000000000003003
>>>>
>>>> [...]
>>>>
>>>> 2) Dump the page table of device "00:0a.0" with pasid "2".
>>>>
>>>> $ sudo echo 00:0a.0,2 >
>>>> /sys/kernel/debug/iommu/intel/domain_translation_struct
>>>> $ sudo cat /sys/kernel/debug/iommu/intel/domain_translation_struct
>>> What about creating a directory layout per {dev, pasid} so the user can
>>> easily figure out and dump?
>>>
>>> e.g.
>>>
>>> /sys/kernel/debug/iommu/intel/00:0a.0/0/domain_translation_struct
>>> /sys/kernel/debug/iommu/intel/00:0a.0/2/domain_translation_struct
>> Thanks.
>>
>> Do you mean create a directory for each device, whether it supports
>> PASID or not ?
> every device has PASID#0 valid, i.e. RID2PASID.
Sorry for the late response.
Got it. Thanks.
>> Seems the PASID can be assigned at runtime.
>> So it needs to support creating debugfs file at runtime in IOMMU driver.
>> Looks like this requires modifying IOMMU driver.
>>
> Isn't this patch trying to modify the driver?
I just tried not to modify the driver except debugfs.
I'll try this implementation.

Thanks,
Jingqi