Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Zi Yan <ziy@nvidia.com>
To:     Hugh Dickins <hughd@google.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Mike Rapoport <rppt@kernel.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        David Hildenbrand <david@redhat.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Qi Zheng <zhengqi.arch@bytedance.com>,
        Yang Shi <shy828301@gmail.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        Peter Xu <peterx@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Will Deacon <will@kernel.org>, Yu Zhao <yuzhao@google.com>,
        Alistair Popple <apopple@nvidia.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Steven Price <steven.price@arm.com>,
        SeongJae Park <sj@kernel.org>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        Huang Ying <ying.huang@intel.com>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Zack Rusin <zackr@vmware.com>, Jason Gunthorpe <jgg@ziepe.ca>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Pasha Tatashin <pasha.tatashin@soleen.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Minchan Kim <minchan@kernel.org>,
        Christoph Hellwig <hch@infradead.org>,
        Song Liu <song@kernel.org>,
        Thomas Hellstrom <thomas.hellstrom@linux.intel.com>,
        Ryan Roberts <ryan.roberts@arm.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 07/32] mm/page_vma_mapped: reformat map_pte() with less
 indentation
Date:   Mon, 10 Jul 2023 21:56:49 -0400
Message-ID: <04F5CA21-1E02-4D15-AB8B-BB89D6409484@nvidia.com>
In-Reply-To: <bf723f59-e3fc-6839-1cc3-c0631ee248bc@google.com>
References: <c1c9a74a-bc5b-15ea-e5d2-8ec34bc921d@google.com>
 <bf723f59-e3fc-6839-1cc3-c0631ee248bc@google.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_4D666C7D-C05C-4184-BADA-BBC0698D6306_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?L2keRPB/q8dDgC67HiQoCFPSxgQE6ExXmFfMBh/tgrwJ1k7nOYW7+yKkSXZl?=
 =?us-ascii?Q?m8IDEheU2fR1Ic2HgeFdShtnzNsZ6PMPGBAfbaVj9S4hXYW2hphT37oOha2y?=
 =?us-ascii?Q?io9VjMeRbMLT8Vsc6GA+SAU8gMKR7+BbMmoeMZPf+WbMDbXh4IaIKhK/yyZO?=
 =?us-ascii?Q?2v1mJ92tvyMnZPh78EnuJ/ALMzb05B1N8T3R/3KDjc8Yoc9KV895OzVPGhAO?=
 =?us-ascii?Q?KbF915SKqf7AeSYqTLlZHpW9FDgyRrs1788guWr7kQYAKm9wRvvcXADlD0qj?=
 =?us-ascii?Q?ZVTyNNbJSwYVLZSbE9LOZGnHo5QOrXJcD5hzzP4oHPmDrOS+JXu2fNBweCMS?=
 =?us-ascii?Q?ZDqdaliAx582eEPRrJMIAl1AM9h5EQRtDhFldj8JgsvvCxULs2y2RRzuiCKQ?=
 =?us-ascii?Q?a6XRz+EZjdQGF7iUSOh5HLlt9O8kRhyPvzD5/Zx6JG7IdGzBaNm9/74WHA60?=
 =?us-ascii?Q?mHt9TZ7qzPqVS6xGpuaxHSEWotkH8JeYRQJXum0xivEM5miQY+Z+YzR5GauI?=
 =?us-ascii?Q?lfA5uckII25fLaAbekOnLMC3mUJmMbYwUVJyii8g0NYrNgBqqqrnE2ehb6YJ?=
 =?us-ascii?Q?uAQ6TVPfWA3ivqIjiU6fZvbgQ0HcWhedNxDFW8cLmGlZhpkNZWsvUBUZ96zL?=
 =?us-ascii?Q?JLWVQa5jBjom8i8YrztKxQ2KM4QeZTkWgVkIUDBF9rJK0/2rhYtXenyDtr2A?=
 =?us-ascii?Q?qdPQTXCBRguQSaWlNw0qUfgRqmeH/7HNvPDyPpgmqcLGDipMRxyUWBWPzm0t?=
 =?us-ascii?Q?jH6/nt9qFudIbgm7WqCYrOVc76dtrED8I9Gjxv6GCkpV8QLCf5RlcqElCcQY?=
 =?us-ascii?Q?C6kGC3L9ZGf1eQiwOvD7/gyZ4tGEljtz+pwyHMjbpwPV2Fay1/sFLLTMHbIw?=
 =?us-ascii?Q?YGiKDK9BIu/lLh6TcZZa6zB4PXEvX+cGJJq/iF4ztW5B8Hhd532rfTmjEa/I?=
 =?us-ascii?Q?ybtwPn5f1Rf992zi7sLObxPdViR9c/ttOa3HmCHN/PxRH80DDEytg4TXUy9S?=
 =?us-ascii?Q?hbD6SppMtG9Bu4s1ZEbGQqkr2iV4DqIM7lMX5/1gsdpTGZZMQJyuebNnP3Eh?=
 =?us-ascii?Q?2T+SuvuKvaj5SipIPNoBKX5Zr2WIeO/u5EceKlxqhtfJx6EBLcAN2SHqwvg1?=
 =?us-ascii?Q?FZPDjHZtE+/pRl0eMt8DAsRWQITfwO1sOzNDIoWOHGlTdwOzD/oM01UpJOVf?=
 =?us-ascii?Q?+y4DM8v2BO+DPSSmux3X3OBIpSsBUBNnvgSkJYlZd9LvyoVitIZf9gSZzcFA?=
 =?us-ascii?Q?o83SXlZ6e/6NNqh9jsN2qC7WJOvRL8BQ77DDzbgRHChf8yUslXpoYdwFtRHD?=
 =?us-ascii?Q?9MlE9iVLlI9ZgqqfOKG6CsKJnsCPGTN515oqn/AQofl/vko7LsHHLrRbBTDv?=
 =?us-ascii?Q?M2ANsyw+1zJS+eEjHtS/1/MiVvXsw8ZY+DHOEwzN7HmvNSetru2GH+axByQ5?=
 =?us-ascii?Q?kA1zJkE1hbgi4l+4jsCY8gfmydF62bmfEDMGZ2U+7IqwZt8XAkceRq189nJP?=
 =?us-ascii?Q?ijwDwRXh08iqFH91dJXSFvx7sBwGXe6g6memmatp+Y8ZAxSKBFWflBUQmNMa?=
 =?us-ascii?Q?ps1tIv5sf4EJBomul3g=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea3ae204-10d0-42f9-40ad-08db81b218ab
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 01:56:52.3204
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PXvv8y653Bs98hekG6IIzNxHxNsOGvnVSO7F7aZ2/J1I8cHVHPedlP3LQZ6fAuSU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7788
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_4D666C7D-C05C-4184-BADA-BBC0698D6306_=
Content-Type: text/plain

On 8 Jun 2023, at 21:14, Hugh Dickins wrote:

> No functional change here, but adjust the format of map_pte() so that the
> following commit will be easier to read: separate out the PVMW_SYNC case
> first, and remove two levels of indentation from the ZONE_DEVICE case.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
> ---
>  mm/page_vma_mapped.c | 65 +++++++++++++++++++++++---------------------
>  1 file changed, 34 insertions(+), 31 deletions(-)
>
LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

--=_MailMate_4D666C7D-C05C-4184-BADA-BBC0698D6306_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmSstuEPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUH20QAId3NCPLc50csb3AzRbmJeuKEKDOj+A9DrUO
Cmx4iiWDuT6fI+x70XosgLywf6PgQMjjtFeq3fhYTRk0HG8F/FUvydO3duB/Tvvz
iHeQUaBQbv4teCMknlQy8Y79I1yRqbp8w83E5GZUeBNvuP+OH4ILnWoZvIHLciQ5
i0eMwEBTh6/usSfhZiNNSrpqomfBbfiy+s7lanStYtCqMPveFI9wuwA36NoWuSVa
MqeIUhc2mzf0xNVSauEX8roR55kVp9FoBCwBWOAPa4irfFCBYBoVcGeINMqVp0lu
1yfXK3D3Q1dq3vn7bdT8QdqW6hK0zis/pgFh6TG7sDZzRFgKZ8SK42c+C96FRW/Y
wRlPz+xCzux+W7QwPxpEGgx4E8/O5l78prSh5KikViM2XDBTZ0Bj/XPx+z6GxpPi
CtuYGtwDBUFH/16hGYEX9vazMjTWA7ipzVctN+KayETep9yUYZnCTZxTjndgBcaM
NwhGB7Q9ULI0bG9S4SbQ6sWDSMeoLYGUz2L08Ybs2JiR9HSwvqYQyrWfqWv2q4bQ
P6YcNrDXpBsdPdoBRcsxONuyEpigRHnqfK1IMbKiXs4F0qKw8QmpKldl92lKzk2H
/gD5xH0sKw6LTQE2raTdk3SrGB/fhLLv+Ku0mOeOJVM2VpCAbkSGtnEghKEvLqqa
K3G149qe
=5o6x
-----END PGP SIGNATURE-----

--=_MailMate_4D666C7D-C05C-4184-BADA-BBC0698D6306_=--