Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Jul 2023 10:33:03 +0900
From:   Masami Hiramatsu (Google) <mhiramat@kernel.org>
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Petr Pavlu <petr.pavlu@suse.com>, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        hpa@zytor.com, samitolvanen@google.com, x86@kernel.org,
        linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, ndesaulniers@google.com
Subject: Re: [RFC PATCH 0/2] x86: kprobes: Fix CFI_CLANG related issues
Message-Id: <20230711103303.287af608cc47dcf70d709070@kernel.org>
In-Reply-To: <20230710155703.GA4021842@dev-arch.thelio-3990X>
References: <168899125356.80889.17967397360941194229.stgit@devnote2>
        <20230710155703.GA4021842@dev-arch.thelio-3990X>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 10 Jul 2023 08:57:03 -0700
Nathan Chancellor <nathan@kernel.org> wrote:

> On Mon, Jul 10, 2023 at 09:14:13PM +0900, Masami Hiramatsu (Google) wrote:
> > I just build tested, since I could not boot the kernel with CFI_CLANG=y.
> > Would anyone know something about this error?
> > 
> > [    0.141030] MMIO Stale Data: Unknown: No mitigations
> > [    0.153511] SMP alternatives: Using kCFI
> > [    0.164593] Freeing SMP alternatives memory: 36K
> > [    0.165053] Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: start_kernel+0x472/0x48b
> > [    0.166028] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.4.2-00002-g12b1b2fca8ef #126
> > [    0.166028] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014
> > [    0.166028] Call Trace:
> > [    0.166028]  <TASK>
> > [    0.166028]  dump_stack_lvl+0x6e/0xb0
> > [    0.166028]  panic+0x146/0x2f0
> > [    0.166028]  ? start_kernel+0x472/0x48b
> > [    0.166028]  __stack_chk_fail+0x14/0x20
> > [    0.166028]  start_kernel+0x472/0x48b
> > [    0.166028]  x86_64_start_reservations+0x24/0x30
> > [    0.166028]  x86_64_start_kernel+0xa6/0xbb
> > [    0.166028]  secondary_startup_64_no_verify+0x106/0x11b
> > [    0.166028]  </TASK>
> > [    0.166028] ---[ end Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: start_kernel+0x472/0x48b ]---
> 
> This looks like https://github.com/ClangBuiltLinux/linux/issues/1815 to
> me. What version of LLVM are you using? This was fixed in 16.0.4. Commit
> 514ca14ed544 ("start_kernel: Add __no_stack_protector function
> attribute") should resolve it on the Linux side, it looks like that is
> in 6.5-rc1. Not sure if we should backport it or just let people upgrade
> their toolchains on older releases.

Thanks for the info. I confirmed that the commit fixed the boot issue.
So I think it should be backported to the stable tree.

Thanks!

> 
> Cheers,
> Nathan


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>