Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp36173693rwd; Mon, 10 Jul 2023 19:33:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlEKXmTzq/wprGnMY6+Nu26CdFO5wEZgEGj1JwcJPDb1dE4PhnDWJ3ZALyBYWfsc3dLqujNv X-Received: by 2002:a05:6a21:9991:b0:130:898:632b with SMTP id ve17-20020a056a21999100b001300898632bmr19450927pzb.2.1689042828828; Mon, 10 Jul 2023 19:33:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689042828; cv=none; d=google.com; s=arc-20160816; b=Aq+TC+kQHDUB+EzZAKnDSQ1Vy54UPSOPM2Q9EyH9RxH6yyt3UkyXH1Df2QXOOGdV1K Jrp44oVY7GBAcffL95I2ILqY5JFc8J6c/wVP5vP10peDpMBLxGauzXVGsjx0l47srofT qKINboRthGlzwEFjvNkTSSfX93P4W20P/J/cqQk/zmCbBg5vyQ6Z0pZxVbecZH4TaqNn TEUwQdg+6O8lIGvgOycS9z6Y5BPIa0XjY4+GYsMoxcBq6RPDElT/epEzAc2zaWrfYEwp sIn7PUNe5lSoFCIXw+18HMbFhGIM0bfSa6mYdWtjQNY3TzLJOA7+ES1FTe1ruJ6SMv9A voKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=rXf0c7Til6z7jCCMIgYIUKE234bLJvcBiQhMLeC1HjA=; fh=3MPwfdM552gd0+k3d3ssTvROBRuZrU0pzCWHREs7OGY=; b=R+2x9r38TvR1Jo+ZtKo1YeRU6JP2jxlSCAwPdLodl0sSwgN1u5fQ/NT1mdrJjHSngS LQgDvAePKl6dpAkAlprTS00wYMrc+7tX5wlJiZjWlWrRhjK2c43dcaOXEEfzP0ncRyV5 vAwbGmltBk6S7fJlOi3mhmyZR9JNL28CYKMrMOHRMr4Zv8K1pJ5UscqnY5ZLh0dAq83J mv2B4EMb+V7xJReKjaD7+Pya92RHb6Tuja1chWj6gbRV/DdUzBwkK4z7YqsSPskLV0nT ZP05Bsb68R/94Jj56EDAqdA9yv/f0/7ZZCsL13W656eek8kklzGQg545qdpjKokT9pBZ qsKQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j62-20020a638b41000000b0055ac5fed588si640871pge.154.2023.07.10.19.33.36; Mon, 10 Jul 2023 19:33:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230397AbjGKCG5 (ORCPT + 99 others); Mon, 10 Jul 2023 22:06:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbjGKCG4 (ORCPT ); Mon, 10 Jul 2023 22:06:56 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B84290; Mon, 10 Jul 2023 19:06:55 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4R0PP80QK5z1FDgN; Tue, 11 Jul 2023 10:06:20 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 11 Jul 2023 10:06:52 +0800 Subject: Re: linux-next: build warning after merge of the cgroup tree To: Tejun Heo , Stephen Rothwell CC: Linux Kernel Mailing List , Linux Next Mailing List References: <20230711111509.1045f32e@canb.auug.org.au> From: Miaohe Lin Message-ID: <9031f42f-6ff3-3e60-049b-fc1917915da9@huawei.com> Date: Tue, 11 Jul 2023 10:06:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/7/11 9:22, Tejun Heo wrote: > On Tue, Jul 11, 2023 at 11:15:09AM +1000, Stephen Rothwell wrote: >> Hi all, >> >> After merging the cgroup tree, today's linux-next build (arm >> multi_v7_defconfig) produced this warning: >> >> kernel/cgroup/cgroup.c:503:36: warning: 'cgroup_tryget_css' defined but not used [-Wunused-function] >> 503 | static struct cgroup_subsys_state *cgroup_tryget_css(struct cgroup *cgrp, >> | ^~~~~~~~~~~~~~~~~ >> >> Introduced by commit >> >> 1299eb2b0ad5 ("cgroup: minor cleanup for cgroup_extra_stat_show()") > > Miaohe, can you send a patch to either add __maybe_unused to > cgroup_tryget_css() or also put it inside CONFIG_CGROUP_SCHED? Will do. Sorry for my mistake. Thanks.