Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yang Rong <yangrong@vivo.com>
To:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>,
        linux-mtd@lists.infradead.org (open list:MEMORY TECHNOLOGY DEVICES
        (MTD)), linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com,
        Yang Rong <yangrong@vivo.com>
Subject: [PATCH v3] mtd: core: Fix resource leak in a for_each_child_of_node() loop
Date:   Tue, 11 Jul 2023 10:03:10 +0800
Message-ID: <20230711020752.2344-1-yangrong@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tcv1yY0Bzd/cBgdAHf7WlS3GrWowbKwV8aO0Pix9wuWo/EiV8AsmIPMQffMx?=
 =?us-ascii?Q?r38/XYf5xJsDCCcvxyCW3RIQfGrhTURCH5DyonsLN3UpeozP9q1TGw0fticD?=
 =?us-ascii?Q?6n1C6UhH1J5ruUsZdYwWpyCOo9Uza0AaiHpKYwPrbEFQzXnS/6nSquljngq4?=
 =?us-ascii?Q?TW3WKmZSeuHf1WD9UZkIPvmbki2lmrFir0c/aaAflYCJjhiQsLYyfcLsAeiq?=
 =?us-ascii?Q?pSuJdyKcdOSrxvW2zb4XWmTyg4bkGPCywiZa1OXgYJMHEp8P7kIiQN2Ageev?=
 =?us-ascii?Q?OZ89DSTd5yDuAVMK/ctXcQtbuggmZXhnz+le/wVXrDGr2X6J/t0HciY6SrQI?=
 =?us-ascii?Q?Ot581sj7N4G0VXANVMjLDA//aGEUOIuuPr9dSr8EWM4XetDXW1taBk2RJ7wh?=
 =?us-ascii?Q?1lCozRIocstld4WCoJai2G91WjpSmCIQ/xrVjGwD/Yh5Oyc7BRfnpBFY8N0t?=
 =?us-ascii?Q?D/I4fAFks/xjCnC6xopHBgif2heUbLudtPbBWgBuE8BQjRMkF9+/mwap1BaA?=
 =?us-ascii?Q?oeoSw5C3hB0jNPY3vekudoRvYD5y6A3YRm8jlIAyqkt9nLsvUMsHtrRI85LX?=
 =?us-ascii?Q?/Xz/Lh2ZI6ipW+9EHDuUFmFlEMzdfPAUwh4SP5dbl7bC8Yw233z5KYRdu/+Y?=
 =?us-ascii?Q?+Ykc4P4FGMrXdWVsPdM8hPtvXeFTZ+Vl69Qv3939m+b3fNNx11pnDtCZCXTG?=
 =?us-ascii?Q?6hWCXWM0LTvI+qV1blzaQLRYbO1PTkZn5XMC4vVb8sMPvuq7uzNEKazBX38Z?=
 =?us-ascii?Q?ShSUtLy7zknGLw5Yg6aEE3j6v8/7/r/IAaIpLDQkTxwFV7O98bOVLcepLmjL?=
 =?us-ascii?Q?Gui8UApv1A0AVH9fVot6yGQUUfdE06DKaE0TpOpXgQ5kW/PV+HoXGTVi6mvT?=
 =?us-ascii?Q?lxwa8DFrZ9a4aBDdW9LcnSNVhdq5GesIK7eyEBW9EdeahBUyhUZv+ieSTqB/?=
 =?us-ascii?Q?tF71PhTVVY9KNPIUL8kMzMcVbLuCA3vclVStMi6xH7DM/y6c+CLSEZVakBTc?=
 =?us-ascii?Q?zqr14+2cSMLyToiAD/Gdaiwsa3bcS5sACC5kLjNs6Zt6a6FtdsHYYs19x6q6?=
 =?us-ascii?Q?BzbB7CoFk69xE/+uamUGc3xjvsEt1RBgnZ1zO3WPTsLHOl9hAoLUkPmdtu/u?=
 =?us-ascii?Q?8fhCbTUcaP5aqhKbHnCJ6arlY91U0R+mriIKYTwo5iqCvw7V4aYnAo2sG7we?=
 =?us-ascii?Q?gyza1NHFCLsAVZVkXwhneZlPE4Dm+jT51FcQmmMLhW1VFa0OVufBWm1FqxYp?=
 =?us-ascii?Q?jmKF37VmPCB7e9R8fB+nOAR4b9yWKdxQT6CL04Dpd8RN0OynSklTHQ1zsvNB?=
 =?us-ascii?Q?/uOco8I7lOQAolXrgRtWR6X8sIIzg20VYIQ83uoym5GQpvsGi0o4NJWi6wON?=
 =?us-ascii?Q?utDT5TaOtp1vpWk63q3xdAl1RYds1j0wfIsVjFPy9sH+/ea32mk7jN61t6Go?=
 =?us-ascii?Q?I33E/pm5BuYGPCBTesI0Ekvk9Szug64BtvQc/WrunDm4jVaeH+W4jnB3kMj0?=
 =?us-ascii?Q?YB957xyRQt3gYNnBJgIsoRgGT/h745Aoj0sKmVp9nW90roK8eeT5K2Ml6edD?=
 =?us-ascii?Q?xtEyMqCEMo4rErOEG7zMjfVAXaCx1hWW1122CJ5j?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18e6e008-b9c3-482c-1db1-08db81b4cc34
X-MS-Exchange-CrossTenant-AuthSource: SEYPR06MB6615.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 02:16:12.5542
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2ltQYKAhd+axV/iUAjJKBRJb/knl+Xz6ZiHoVIW/pCypsa8AudHPTtL4520nDGYbG++jDE8c0i6JJkS5MG90AA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6505
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ensure child node references are properly decremented in the error path
  of this function implementation.

Fixes: 2df11f00100d ("mtd: core: try to find OF node for every MTD partition")
Signed-off-by: Yang Rong <yangrong@vivo.com>
---
v2: https://lore.kernel.org/all/20230710061412.2272-1-yangrong@vivo.com/
The modifications made copared to the previous version are as follows:
1.Optimized the expression of the Subject, making it more accurate.
2.Optimized the content of the commit message.
3.Add the tag "Fixes".

 drivers/mtd/mtdcore.c | 1 +
 1 file changed, 1 insertion(+)
 mode change 100644 => 100755 drivers/mtd/mtdcore.c

diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index e00b12aa5ec9..b02cb8b1a38d
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -591,6 +591,7 @@ static void mtd_check_of_node(struct mtd_info *mtd)
 		if (plen == mtd_name_len &&
 		    !strncmp(mtd->name, pname + offset, plen)) {
 			mtd_set_of_node(mtd, mtd_dn);
+			of_node_put(mtd_dn);
 			break;
 		}
 	}
-- 
2.35.3