Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ea32a1cf-3a77-d63b-034f-0f80d2dd80ea@nvidia.com>
Date:   Tue, 11 Jul 2023 10:34:33 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH net-next V1 0/4] virtio_net: add per queue interrupt
 coalescing support
Content-Language: en-US
To:     Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc:     virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org, mst@redhat.com,
        jasowang@redhat.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, ast@kernel.org,
        daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
        jiri@nvidia.com, dtatulea@nvidia.com,
        Heng Qi <hengqi@linux.alibaba.com>
References: <20230710092005.5062-1-gavinl@nvidia.com>
 <1688981109.6377137-1-xuanzhuo@linux.alibaba.com>
From:   Gavin Li <gavinl@nvidia.com>
In-Reply-To: <1688981109.6377137-1-xuanzhuo@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmdXS3FiV3FXbk9JTW1TblUvYS9LZ1NoNWY1dE1meW9YOWFFbmlESy9kdkpL?=
 =?utf-8?B?SkNNbUU0bnhDTFlsSEZQLzJqMzVEci9CeFVIdjhVV3NBMUU4L2c4YUtBbTls?=
 =?utf-8?B?eXgyRU9PcXQrT0FCN3ZjSU5LZk85MzFZZVpnVTkvN1ZkdTZ3dFp6TTJOcUJ0?=
 =?utf-8?B?VzFyVTZ1bkNSTmdla1QrRkcxZEpFQmpiNG1VWk1RMEFXWWVFaXQvYkR3cTN0?=
 =?utf-8?B?TFhKWVp0OEYrVnVWdUpnU1V0YXg0K1B4NjNQVGlPUitkODIwYk92S0VETmpu?=
 =?utf-8?B?VllWcnNmVjYyZmFMZG1laXU1N2svUWhIOGFDVHJmZHIrRDdUK1hWMlA0RkIr?=
 =?utf-8?B?OUdDaDF0b2tuejNLOWNwbWtyeVByRUJ5VzBGenFxVVFlYXVIT3U5Y3VOUVFV?=
 =?utf-8?B?cFpaQ2g5S1NDclE4UjIrdmZrcTdYdDRsajFkSVBSYnNqUXhFbDU5QkN6Y205?=
 =?utf-8?B?RzBUaWpDK1dqZWMybE01OGN6L3VuNHhHckY2aXp1QkRkVG1OL2orbVNtK2Zr?=
 =?utf-8?B?bFdVQVBPcFBzek5FYzJpTm11bWcvWEJEUTV0UlNGay9CWVFKK01MQjE1ZWZm?=
 =?utf-8?B?WFo3d0p4SHF6WGJ0QmtHdGlhSDhVVFZ5cmJheGtYbThVeTV4clVUMVZuNWpl?=
 =?utf-8?B?My84SXFVWFV1c3VjaEVjV0lFTGhyZmJxZTNCRzRLS1VtNnpoOE9aMXZjRVVJ?=
 =?utf-8?B?R3ZOcGNWcDArai9ycTFYdTZ1a1BtNGlHbnM1NDRPa1d2dGlMM2t4K1d2akVU?=
 =?utf-8?B?eU9XcFQ2czRrOEs3dU9OVnRpeTJKL0ZUU2JJYy9vVm1oNzkrNkpFb0dTOVVq?=
 =?utf-8?B?enYyc1V2Y1VsUyswNWRhbUxlcVFPa1VaVHlEUWFhRjM4djlLcUk5bmJrNkRv?=
 =?utf-8?B?ZVcyaENWSTlERDV3TXZGTmJUWno0NzNIRSs4RTdzdXM4MEhZTzI4SzlNYXNP?=
 =?utf-8?B?eG93UzJRZit2d0xHODh4aTFDRjEyVmZBY0Q2U1pVSUt0MWIwWnFKTnM3bnJG?=
 =?utf-8?B?cmdzY09idTRNOG1NN2psV2dTMVBrMTBTemNFUDJnUFBzblN3MXBhdzl6dlRU?=
 =?utf-8?B?U3cwNnRzbHFPaU5SRmlkbGREMjI3WVRmU3d0Rno4ekpUdWU1VmkzVkZNSEVN?=
 =?utf-8?B?L3pubnhwM3FIeG9zUmJjODJHeC8xUVJ5Tm9UZlZ1ZUIxV2tqRlJpNUNqeFN1?=
 =?utf-8?B?N2k3Q244RDl1YVpTWWRzejE1Nk1MNkxtSjV1M2NQOUhZa2NZcjdkMTFVMWxz?=
 =?utf-8?B?NWpFWFhTU2NiUHRJT1JaQjhtbGoyZzBmZXl2Wk5vZjZUcm1zM1ZtaUpyNjdJ?=
 =?utf-8?B?MFJZV21NdWtyVnNOcGpBYzBxa3RGR0hxZElSTkJkZUpaTjY2NTg3M2MwTEJv?=
 =?utf-8?B?bm5aRytzZXdDTTNFZjJoZ2hZZ1BzMW9vNkc2QTVUdE9OazN0V1JuK0V4RkZ3?=
 =?utf-8?B?bWtGOUpHL2Rzc1hwZ3QwZVpMVEJjRHdRVmdvQ2h0M1hTc1djSWh6N0h6a2J6?=
 =?utf-8?B?eHdPakxJYlNEZDY4S1VpcjkvdHlTNDgvZjN6ei9HSzBWd0wraDVEQityeVVh?=
 =?utf-8?B?NlpVNTM2RzN2bk5vdkdVUG5BeWJhVjVua1hJb2dCZk9UaXBlSEtSZVNHd0Rl?=
 =?utf-8?B?UHlZcURLd3pLNXJvRUJubCtpUVRTYkFtRElZVFp1S2E1VHl5eGhJVW1MZ1JF?=
 =?utf-8?B?TWMzVHEya0xyZy9IVGRXQ3VBRW43S2VrYTBWeFhVUjBwSGFYMmNSZG9EWkFU?=
 =?utf-8?B?VFFDWnhCNHBoQ0xHS1JMQi8wUUJyZUk5YmFZOUkvajI1ZzkyZ3JlM1RiRlNk?=
 =?utf-8?B?N0E2STJ6aCtrV1Q3US9VWmFxQ2QyZWVzTHFvWXlmUFpDK0RZUFRFMWRWN1ll?=
 =?utf-8?B?R0NSUDhIdmxUaitrTEtCT3FlbHRBSWJPcklXUXI0cktUZmdoL0pHVUNMamNJ?=
 =?utf-8?B?MjdQWER3Y0ljZjJRcmZUQnlEKzdZZG5EdVhQeW9nN1oxQlMyTFlZQUFPeHE4?=
 =?utf-8?B?dUhmTUpUUkw2WklhNVFOeWpoMG1rd2g5SHllaEtTakxmcDJDTnd3OHkxVkor?=
 =?utf-8?B?UUw5a3FRUUw0UkxTRWRNOXpOWVpNNXJ1RlNqWlU3dzVrbWxjMlBSZE9VMWcy?=
 =?utf-8?Q?Yr71CGKjVbZVqDAwT9bCfVGe2?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 191e98eb-f2d1-4955-5f85-08db81b7659d
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6036.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 02:34:49.4651
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qFabHfntQIg0uduGE3Wo1E0eE824E8RQH0dVmt+ZundliFGz+mtSXVFt+zgs9vY3vCe0xCV2qHhjLeEqtjT7Kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7420
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/10/2023 5:25 PM, Xuan Zhuo wrote:
> External email: Use caution opening links or attachments
>
>
> On Mon, 10 Jul 2023 12:20:01 +0300, Gavin Li <gavinl@nvidia.com> wrote:
>
> As far as I know, Heng Qi does that. I'm not sure, it's the same piece.
>
> cc @Heng Qi
>
> Thanks.
Do you mean the one below?

https://lists.oasis-open.org/archives/virtio-dev/202303/msg00415.html

The code is to implement what it described and I don't have better 
words. So, I copied the text from Heng Qi's.

>
>
>> Currently, coalescing parameters are grouped for all transmit and receive
>> virtqueues. This patch series add support to set or get the parameters for
>> a specified virtqueue.
>>
>> When the traffic between virtqueues is unbalanced, for example, one virtqueue
>> is busy and another virtqueue is idle, then it will be very useful to
>> control coalescing parameters at the virtqueue granularity.
>>
>> Example command:
>> $ ethtool -Q eth5 queue_mask 0x1 --coalesce tx-packets 10
>> Would set max_packets=10 to VQ 1.
>> $ ethtool -Q eth5 queue_mask 0x1 --coalesce rx-packets 10
>> Would set max_packets=10 to VQ 0.
>> $ ethtool -Q eth5 queue_mask 0x1 --show-coalesce
>>   Queue: 0
>>   Adaptive RX: off  TX: off
>>   stats-block-usecs: 0
>>   sample-interval: 0
>>   pkt-rate-low: 0
>>   pkt-rate-high: 0
>>
>>   rx-usecs: 222
>>   rx-frames: 0
>>   rx-usecs-irq: 0
>>   rx-frames-irq: 256
>>
>>   tx-usecs: 222
>>   tx-frames: 0
>>   tx-usecs-irq: 0
>>   tx-frames-irq: 256
>>
>>   rx-usecs-low: 0
>>   rx-frame-low: 0
>>   tx-usecs-low: 0
>>   tx-frame-low: 0
>>
>>   rx-usecs-high: 0
>>   rx-frame-high: 0
>>   tx-usecs-high: 0
>>   tx-frame-high: 0
>>
>> In this patch series:
>> Patch-1: Extract interrupt coalescing settings to a structure.
>> Patch-2: Extract get/set interrupt coalesce to a function.
>> Patch-3: Support per queue interrupt coalesce command.
>> Patch-4: Enable per queue interrupt coalesce feature.
>>
>> Gavin Li (4):
>>    virtio_net: extract interrupt coalescing settings to a structure
>>    virtio_net: extract get/set interrupt coalesce to a function
>>    virtio_net: support per queue interrupt coalesce command
>>    virtio_net: enable per queue interrupt coalesce feature
>>
>>   drivers/net/virtio_net.c        | 169 ++++++++++++++++++++++++++------
>>   include/uapi/linux/virtio_net.h |  14 +++
>>   2 files changed, 154 insertions(+), 29 deletions(-)
>>
>> --
>> 2.39.1
>>