Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ab6ab3d2-d168-8c10-b7f5-94a669e212fc@infradead.org>
Date:   Mon, 10 Jul 2023 21:37:10 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 02/13] Add TSEM specific documentation.
Content-Language: en-US
To:     "Dr. Greg" <greg@enjellic.com>,
        linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, corbet@lwn.net
References: <20230710102319.19716-1-greg@enjellic.com>
 <20230710102319.19716-3-greg@enjellic.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230710102319.19716-3-greg@enjellic.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 7/10/23 03:23, Dr. Greg wrote:
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 9e5bab29685f..0e6640a78936 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -6468,6 +6468,24 @@
>  			with CPUID.16h support and partial CPUID.15h support.
>  			Format: <unsigned int>
>  

These 3 entries should be in alphabetical order: tsem_cache, tsem_digest, tsem_mode.

> +	tsem_mode=	[TSEM] Set the mode that the Trusted Security Event
> +			Modeling LSM is to run in.
> +			Format: 1
> +			1 -- Disable root domain modeling.
> +
> +	tsem_cache=	[TSEM] Define the size of the caches used to hold
> +			pointers to structures that will be used to model
> +			security events occurring in the root modeling
> +			namespace that are called in atomic context.
> +			Format: <integer>
> +			Default: 96

What unit?  KB, MB, bytes, pages?

> +
> +	tsem_digest=	[TSEM] Define the cryptographic hash function that
> +			will be used to create security event coefficients
> +			for in the root modeling namespace.

			for in
?

> +			Format: {name of the cryptographic hash function}
> +			Default: sha256

-- 
~Randy