Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Jul 2023 22:06:22 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Gabriel Krisman Bertazi <krisman@suse.de>
Cc:     Lu Hongfei <luhongfei@vivo.com>, Jens Axboe <axboe@kernel.dk>,
        Pavel Begunkov <asml.silence@gmail.com>,
        io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
        opensource.kernel@vivo.com
Subject: Re: [PATCH] io_uring: Redefined the meaning of io_alloc_async_data's
 return value
Message-ID: <ZKzjTg1xaoikN9Hh@infradead.org>
References: <20230710090957.10463-1-luhongfei@vivo.com>
 <87o7kjr9d9.fsf@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87o7kjr9d9.fsf@suse.de>
Precedence: bulk

On Mon, Jul 10, 2023 at 12:58:58PM -0400, Gabriel Krisman Bertazi wrote:
> practice to change the symbol, making the change hard to miss.  Or
> make the function return int instead of bool, which preserves the
> interface and is a common C idiom.  Or leave it as it is, which is quite
> readable already..

Yeah, returning -ENOMEM and 0 would make a lot more sense here.  But I'd
only change it if we have any good reason to touch the interface anyway.